[PHP-DEV] CVS Account Request: cardoe

2007-03-18 Thread Doug Goldstein
Hi, I'm going to be taking over maintaining ext/ldap as per my discussions with Antony Dovgal and Ilia Alshanetsky. So I need to get setup with a CVS account to be able to commit. Thanks. -- Doug Goldstein <[EMAIL PROTECTED]> http://dev.gentoo.org/~cardoe/ signature.asc Descripti

Re: [PHP-DEV] LDAP functions implemented poorly

2007-03-06 Thread Doug Goldstein
spec for LDAP C API, the ldap_get_values_len() function basically returns you a char * as well as the length of the data. Instead of just returning you the char * and relying on your code to call strlen(). Which when it comes to binary data is not safe. So it shouldn't affect what LDAP server

Re: [PHP-DEV] LDAP functions implemented poorly

2007-03-03 Thread Doug Goldstein
Antony Dovgal wrote: > On 03/01/2007 01:11 AM, Doug Goldstein wrote: >> Antony Dovgal wrote: >>> On 03/01/2007 12:35 AM, Doug Goldstein wrote: >>>>> Did you really test it with non-NULL terminated strings? >>>>> Don't you need to add '\0

Re: [PHP-DEV] LDAP functions implemented poorly

2007-02-28 Thread Doug Goldstein
Antony Dovgal wrote: > On 03/01/2007 12:35 AM, Doug Goldstein wrote: >>> Did you really test it with non-NULL terminated strings? >>> Don't you need to add '\0' manually? >> >> The test is that you run the example code from bug #38819, watch PHP

Re: [PHP-DEV] LDAP functions implemented poorly

2007-02-28 Thread Doug Goldstein
Antony Dovgal wrote: > On 03/01/2007 12:04 AM, Doug Goldstein wrote: >>> Wait, I thought the DEPRECATED thing fixed it (I can't test it myself >>> as I >>> don't use LDAP). >>> If not, then what was it all about? >> >> The test case s

Re: [PHP-DEV] LDAP functions implemented poorly

2007-02-28 Thread Doug Goldstein
Antony Dovgal wrote: > Hello. > Thanks for sending the patch here. > > On 02/28/2007 11:33 PM, Doug Goldstein wrote: >> Referencing Bug #38819 & Bug #40671 >> http://bugs.php.net/bug.php?id=38819 >> http://bugs.php.net/bug.php?id=40671 >> >> Essent

[PHP-DEV] LDAP functions implemented poorly

2007-02-28 Thread Doug Goldstein
Referencing Bug #38819 & Bug #40671 http://bugs.php.net/bug.php?id=38819 http://bugs.php.net/bug.php?id=40671 Essentially I looked through the above mentioned bug, the bugs opened with OpenLDAP developers, and then reviewed ext/ldap/ldap.c and it appears the API calls made by PHP are not necessari