[PHP-DEV] Re: [PATCH] PHP5 RC1: Breakage in ext/sybase

2004-03-19 Thread David Brown
Hi: On Fri, Mar 19, 2004 at 01:24:39PM -0500, David Brown wrote: | + /* Get rid of extra nulls */ | + while (res_length > 0 && res_buf[res_length] == '\0') | + res_length--; | + | Z_STRVAL_P(result) = res_buf; | + Z_STRLEN_P(result) = res_lengt

[PHP-DEV] [PATCH] PHP5 RC1: Breakage in ext/sybase

2004-03-19 Thread David Brown
Hi: Attached are three patches for ext/sybase. The first two fix bugs. The third adds a function, while at the same time removing a lot of redundant code. In order: php5_sybase-fetch_object.diff: The sybase extension does not currently compile, since sybase_fetch_object was never conve

Re: [PHP-DEV] [PCRE] Undefined POSIX_MALLOC_THRESHOLD is back...

2003-07-30 Thread David Brown
On Tue, Jul 29, 2003 at 10:12:25PM +0300, Jani Taskinen wrote: | | Get more recent snapshot, it compiles just fine on win32 | already. | | On Tue, 29 Jul 2003, David Brown wrote: | | >Hi Everyone: | > | >The PCRE breakage on Windows referenced here: | > http://www.zend.c

[PHP-DEV] [PCRE] Undefined POSIX_MALLOC_THRESHOLD is back...

2003-07-29 Thread David Brown
Hi Everyone: The PCRE breakage on Windows referenced here: http://www.zend.com/lists/php-dev/200306/msg00781.html ...appears to be back once again, but this time on a regular Linux box with GCC 3.2.2. I get: ext/pcre/pcrelib/pcre.c: In function `pcre_config': ext/pcre/pcrelib/pcre.c:611: `PO

[PHP-DEV] [PATCH] Fixes for Sybase-DB in PHP 5 HEAD

2003-06-06 Thread David Brown
Hi: The enclosed patch makes the Sybase DBLib support compile against PHP 5 and ZE 2, fixes crashes in sybase_select_db() and sybase_affected_rows() related to incorrect zval initialization, implements the missing sybase_fetch_assoc(), removes a bunch of redundant calls to Z_STRLEN_PP() in php_syb

Re: [PHP-DEV] Re: CVS commit in ZendEngine2/zend_execute.c

2003-06-01 Thread David Brown
On Sun, Jun 01, 2003 at 02:34:41AM +0200, Marcus B?rger wrote: | Yes David, | | in ZTS mode it causes much problems, i found them some hours ago. But | the main reason for revert is that the patch was done in the wrong | way. Currently we are trying to figure out a new way since the | performance

[PHP-DEV] Re: CVS commit in ZendEngine2/zend_execute.c

2003-06-01 Thread David Brown
> zend_execute.c, 1.468 (sterling) > Sat May 31 14:31:28 2003 (5 hours, 35 minutes ago) > revert the function call caching patch until a new solution is decided > upon. Hi: Is this being reverted due to a reported crash? If not, I'm currently seeing several with the patch applied (which go away w

[PHP-DEV] Bug #22510: Working toward a fix...

2003-06-01 Thread David Brown
Hi: I believe there's a missing refcount increment causing this bug, and I think I may have uncovered some evidence that could get us closer to a fix. I've added opcode dumps to zend_execute.c with a well-placed perl command, so as to see the instructions as they're executed. All of the following

[PHP-DEV] [PATCH] Fix off-by-one in zend_register_standard_constants

2003-06-01 Thread David Brown
Hi: The function zend_register_constant expects c->name_len to equal sizeof(c->name) for any struct _zend_constant named c. In zend_register_standard_constants, sizeof() is used to compute the length of the constant name correctly, but ZEND_STRL() is used to allocate the string. ZEND_STRL() alloca

[PHP-DEV] ZE2 and assert()

2003-05-31 Thread David Brown
Hi: Given the following script, which uses assert to eval() a string that references the current class: foo == 1'); } function as_expr() { assert($this->foo == 1); } } $foo = new foo(); $foo->as_expr(); $foo->as_string(); ?> PHP 4.3-cvs executes it correctly, but PHP 5.0-cvs wi

[PHP-DEV] [PATCH (resend)] Add an optional size limit to debug_backtrace

2003-05-29 Thread David Brown
Hi: Attached is a patch that adds an optional 'limit' parameter to debug_backtrace, which limits the size of the returned array. In cases where a script wants debug information only for the current function, or for the function levels above that, we can save a lot of unnecessary call-stack traver

Re: [PHP-DEV] CVS Account Request: imran

2003-03-20 Thread David Brown
On Thu, Mar 20, 2003 at 07:54:14AM -, imran asghar wrote: | to know with new bugs. If you're looking for information on existing PHP bugs (or are interested in reporting new ones), you probably want http://bugs.php.net/, not a CVS account. -- PHP Internals - PHP Runtime Development Mailing