Re: [Fwd: [PHP-DEV] PATCH: zend_alloc.c x86_64 optimization]

2007-12-20 Thread Brian Shire
ssage Subject: [PHP-DEV] PATCH: zend_alloc.c x86_64 optimization Date: Wed, 28 Nov 2007 14:27:29 -0800 From: Brian Shire <[EMAIL PROTECTED]> To: internals@lists.php.net I noticed that there where some x86_64 assembly optimizations missing from Zend/zend_alloc.c, it only accounts for i386. Th

Re: [PHP-DEV] ignored patches

2007-12-03 Thread Brian Shire
On Dec 3, 2007, at 9:16 PM, Gregory Beaver wrote: Brian Shire wrote: On Dec 3, 2007, at 2:17 PM, Stanislav Malyshev wrote: I am a developer on a CMS also which uses the auto-include functionality to include many classes over many files. Each request can include up to 30 different files

Re: [PHP-DEV] ignored patches

2007-12-03 Thread Brian Shire
On Dec 3, 2007, at 2:17 PM, Stanislav Malyshev wrote: I am a developer on a CMS also which uses the auto-include functionality to include many classes over many files. Each request can include up to 30 different files. The speed increase is around the 15% mark when combining the files.

[PHP-DEV] PATCH: zend_alloc.c x86_64 optimization

2007-11-28 Thread Brian Shire
I noticed that there where some x86_64 assembly optimizations missing from Zend/zend_alloc.c, it only accounts for i386. The following patch should add x86_64 support (I don't have karma for Zend of course, patch is against 5.2.5), I've included a bench mark with a simple test script to

Re: [PHP-DEV] zend_mm_set_heap()

2007-04-25 Thread Brian Shire
n PHP heap, so all emalloc() function will work with new one. Thanks. Dmitry. -Original Message- From: Brian Shire [mailto:[EMAIL PROTECTED] Sent: Wednesday, April 25, 2007 1:22 AM To: PHP internals Subject: [PHP-DEV] zend_mm_set_heap() It seems like zend_mm_set_heap() isn

[PHP-DEV] zend_mm_set_heap()

2007-04-24 Thread Brian Shire
It seems like zend_mm_set_heap() isn't very useful outside zend_alloc.c because the zend_mm_heap structure definition is within the zend_alloc.c file rather than zend_alloc.h. Could we move the AG () and associated structures to the header file, or perhaps I missed something? - Shire

Re: [PHP-DEV] Trapping "memory exhausted" error

2007-04-17 Thread Brian Shire
I have code at Facebook that currently does something similar by catching fatal errors but there's a lot of gotcha's obviously that need to be handled properly when the engine is in this state. When possible we enable the printing of backtraces and other debug information, however you ru

[PHP-DEV] [PATCH] segfault with string dimensions

2007-03-07 Thread Brian Shire
Let me know if I have any issues with my patch/thinking here: Reproduce code: The zend_binary_assign_op_helper_* function isn't checking that the value returned from _get_zval_ptr_ptr_var is set, so it faults instead of letting zend_fetch_dimension_address trigger the "Cannot use strin

[PHP-DEV] extract() optimization

2006-12-09 Thread Brian Shire
if (php_valid_var_name(final_name.c)) { + if (php_valid_var_name(final_name.c, final_name.len)) { if (extract_refs) { zval **orig_var; -Brian Shire [EMAIL PROTECTED] [EMAIL PROTECTED]

Re: [PHP-DEV] make test flag?

2006-12-09 Thread Brian Shire
this existed, would it be preferred to try and have a DSO extensions set TEST_PHP_ARGS to avoid this situation? Thanks, -Brian Shire [EMAIL PROTECTED] [EMAIL PROTECTED] aim: int80h -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] INI Includes

2006-12-06 Thread Brian Shire
y larger configurations especially when using a configuration management tool. Just wondering if this is a confirmed "not going to happen" item or if it's still something that may be of interest. Thanks, -Brian Shire [EMAIL PROTECTED] [EMAIL PROTECTED] aim: int80h -- PHP

Re: [PHP-DEV] make test flag?

2006-12-01 Thread Brian Shire
in an ini file. When make test is ran it will attempt to load the DSO twice, and gives: "PHP Warning: Module 'apc' already loaded in Unknown on line 0". I thought the preference would be to ignore installed ini files, but if that's not the intention, then my prop

Re: [PHP-DEV] make test flag?

2006-12-01 Thread Brian Shire
roposed patch of course is bad. -Brian Shire [EMAIL PROTECTED] [EMAIL PROTECTED] aim: int80h -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] make test flag?

2006-11-30 Thread Brian Shire
s.php -n -d 'extension_dir=modules/' -d `( . $(PHP_MODULES) ; echo extension=$$dlname)` tests/; \ elif test ! -z "$(SAPI_CLI_PATH)" && test -x "$(SAPI_CLI_PATH)"; then \ TEST_PHP_EXECUTABLE=$(top_builddir)/$(SAPI_CLI_PATH) \

[PHP-DEV] Anyone know why this isn't safe?

2006-09-28 Thread Brian Shire
Ran into a problem with the following APC code change. I'm not seeing the error message on duplicate function definitions in different files when compiled/cached individually then both included in another file. ie: file a.php and file b.php both contain the function foo(). If I request a

[PHP-DEV] CVS Account Request: shire

2006-03-22 Thread Brian Shire
Access to pecl/apc to committ bug fixes/modifications directly. Recieved invitation from Rasums. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php