[PHP-DEV] Re: New RFC : empty() function

2023-10-31 Thread Brady Wetherington via internals
> I have posted a new RFC at this link https://wiki.php.net/rfc/empty_function > where I suggested some improvements to the standard built-in empty() > function and provided a number of examples. Is your "is_empty()" function equivalent to something like: function is_empty($param = null) { re

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-12-01 Thread Brady Wetherington via internals
On Wed, Dec 1, 2021 at 9:16 PM Sara Golemon wrote: > > On Tue, Nov 30, 2021 at 10:18 PM Brady Wetherington > wrote: >> >> >>> …It's been merged to master, so you could stand up a build now and point >> >>> to the many deprecation warnings you're expecting. I'm not saying send >> >>> PRs to fi

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-30 Thread Brady Wetherington via internals
>>> …It's been merged to master, so you could stand up a build now and point to >>> the many deprecation warnings you're expecting. I'm not saying send PRs to >>> fix them all, just show real impact rather than theoretical guessing. … > > > That’s a totally fair ask, and I’ll try and get that do

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-26 Thread Brady Wetherington via internals
> > …It's been merged to master, so you could stand up a build now and point >> to the many deprecation warnings you're expecting. I'm not saying send PRs >> to fix them all, just show real impact rather than theoretical guessing. … > > That’s a totally fair ask, and I’ll try and get that done and

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Brady Wetherington via internals
> > That's 1.5 million hours, which is 171 developer-years. > > If we're going to imagine numbers; there are 6 million PHP developers > in the world*. If on average they each lose just 1 hour per year by > making typos and accidentally creating a properties dynamically, > that's 6 million hours, or

Re: [PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Brady Wetherington via internals
> This is a little bit overly dramatic. This isn't such a huge change that > would affect 50% of existing projects. It's likely to affect a small number > of projects in a very limited way. > It's also not true that developers will slap #[AllowDynamicProperties] on > every class. That would impl

[PHP-DEV] Re: [VOTE] Deprecate dynamic properties

2021-11-25 Thread Brady Wetherington via internals
Sorry for the 11th hour chime-in, but I wanted to add some context about this proposed change, and how it would likely affect our project and many others. I know the prospect of opt-in was already addressed, but I wanted to talk about what our experience would be here. (We make Snipe-IT, which is o