Re: [PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

2017-08-22 Thread Andrew Nester
> On Aug 19, 2017, at 4:30 PM, Nikita Popov wrote: > > On Thu, Aug 17, 2017 at 5:03 PM, Andrew Nester <mailto:andrew.nester@gmail.com>> wrote: > > > > 13 авг. 2017 г., в 21:39, Andrew Nester > <mailto:andrew.nester@gmail.com>> написал(а):

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

2017-08-17 Thread Andrew Nester
> 13 авг. 2017 г., в 21:39, Andrew Nester > написал(а): > > > >> 11 авг. 2017 г., в 15:53, Andrew Nester написал(а): >> >> >>> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: >>> >>> Hello everyone! >>> >>

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

2017-08-13 Thread Andrew Nester
> 11 авг. 2017 г., в 15:53, Andrew Nester написал(а): > > >> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: >> >> Hello everyone! >> >> I was working on following request https://bugs.php.net/bug.php?id=75053 >> which resulted in followin

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

2017-08-13 Thread Andrew Nester
> 11 авг. 2017 г., в 15:53, Andrew Nester написал(а): > > >> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: >> >> Hello everyone! >> >> I was working on following request https://bugs.php.net/bug.php?id=75053 >> which resulted in followin

Re: [PHP-DEV] Re: [Bug] [Discussion] filter_var and reserved IP address range

2017-08-13 Thread Andrew Nester
> 13 авг. 2017 г., в 18:46, Dan Ackroyd написал(а): > >> On 3 August 2017 at 18:08, Andrew Nester wrote: >> >>> On Jun 13, 2017, at 6:03 PM, Andrew Nester wrote: >>> >>> Hello! >>> Currently I am working on bug #74699 (Thanks brianlmoo

[PHP-DEV] Re: [Request][Discussion] Double value as array key improvement

2017-08-11 Thread Andrew Nester
> On Aug 11, 2017, at 2:10 PM, Andrew Nester wrote: > > Hello everyone! > > I was working on following request https://bugs.php.net/bug.php?id=75053 > <https://bugs.php.net/bug.php?id=75053> which resulted in following pull > request https://github.com/php/

[PHP-DEV] [Request][Discussion] Double value as array key improvement

2017-08-11 Thread Andrew Nester
Hello everyone! I was working on following request https://bugs.php.net/bug.php?id=75053 which resulted in following pull request https://github.com/php/php-src/pull/2676 The problem here is following: when we’r

Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface and PDOStatementInterface

2017-08-06 Thread Andrew Nester
> 6 авг. 2017 г., в 16:30, Dan Ackroyd написал(а): > > Andrew Nester wrote: >> I am thinking about writing an RFC for this and continue discussion there. >> Will it be a good idea? > > You're apparently not very good at listening to suggestions, so I'll

[PHP-DEV] Re: [Bug] [Discussion] filter_var and reserved IP address range

2017-08-03 Thread Andrew Nester
> On Jun 13, 2017, at 6:03 PM, Andrew Nester wrote: > > Hello! > Currently I am working on bug #74699 (Thanks brianlmoon for pointing this > issue). > > Here is some details: > In patch applied for bug #72972 IP address block 240.0.0.0/4 has been removed > from

Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface and PDOStatementInterface

2017-08-03 Thread Andrew Nester
> On Jul 31, 2017, at 6:33 PM, Johannes Schlüter wrote: > > (off-list as this is distracting the discussion) > > On Mo, 2017-07-31 at 18:00 +0300, Andrew Nester wrote: >> >>> On Jul 31, 2017, at 5:54 PM, Johannes Schlüter >> .de> wrote: >>> >

Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface and PDOStatementInterface

2017-07-31 Thread Andrew Nester
> On Jul 31, 2017, at 5:54 PM, Johannes Schlüter wrote: > > On Mo, 2017-07-31 at 14:49 +0300, Andrew Nester wrote: >> That’s actually the thing that you can’t use >> PDO::ATTR_STATEMENT_CLASS with persistent PDO. > > The actually question is: Why not? - From a quick

Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface and PDOStatementInterface

2017-07-31 Thread Andrew Nester
> On Jul 31, 2017, at 2:59 PM, Dan Ackroyd wrote: > > On 31 July 2017 at 12:49, Andrew Nester wrote: >> >> To make it possible to have persistent PDO with custom PDOStatement you >> should have: >> >> 1) custom `CustomPDO implements PDOInterface`

Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface and PDOStatementInterface

2017-07-31 Thread Andrew Nester
> On Jul 31, 2017, at 2:17 PM, Dan Ackroyd wrote: > > On 31 July 2017 at 08:21, Andrew Nester wrote: >> >> when we are using persistent PDO we can’t use PDO::ATTR_STATEMENT_CLASS and >> return our custom PDOStatement class >> >> But just implementing

Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface and PDOStatementInterface

2017-07-31 Thread Andrew Nester
explains a bit how interfaces could help here. > On Jul 31, 2017, at 2:17 PM, Dan Ackroyd wrote: > > On 31 July 2017 at 08:21, Andrew Nester wrote: >> >> when we are using persistent PDO we can’t use PDO::ATTR_STATEMENT_CLASS and >> return our custom PDOStat

Re: [PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface and PDOStatementInterface

2017-07-31 Thread Andrew Nester
Thanks! > On Jul 29, 2017, at 1:13 PM, Dan Ackroyd wrote: > > On 28 July 2017 at 07:40, Andrew Nester wrote: >> Hello! >> >> the only way to add some custom classes and behavior is to approach this is >> by subclassing PDO and PDOStatement. > > >

[PHP-DEV] [Request][Discussion] Introduce interfaces PDOInterface and PDOStatementInterface

2017-07-27 Thread Andrew Nester
Hello! I’ve been working on request introduced here https://bugs.php.net/bug.php?id=74957 related to implementing new PDOInterface and PDOStatementInterfaces. At this point of time classes PDO and PDOStatement do not implement any interfaces that’s why co

[PHP-DEV] [Bug] [Discussion] filter_var and reserved IP address range

2017-06-13 Thread Andrew Nester
Hello! Currently I am working on bug #74699 (Thanks brianlmoon for pointing this issue). Here is some details: In patch applied for bug #72972 IP address block 240.0.0.0/4 has been removed from list of reserved. But according to IP Multicast Address Specification: “The range of addresses betwee

[PHP-DEV] Re: Fix for NumberFormatter did not work properly when restored from session

2017-06-07 Thread Andrew Nester
Bump on this thread because I would like to hear some feedback. Thanks! > On Mar 31, 2017, at 10:55 PM, Andrew Nester wrote: > > > Hello everyone! > > I’ve been working on fix for following bug: > https://bugs.php.net/bug.php?id=74063 <https://bugs.php.net/bug.php?i

[PHP-DEV] Fix for NumberFormatter did not work properly when restored from session

2017-03-31 Thread Andrew Nester
ow us to use wakeup-based unserialization without leaking additional (PHP-level) properties.” Thanks! Andrew Nester