Re: [PHP-DEV] Proposal for a new basic function: str_contains

2020-02-14 Thread Aegir Leet
I generally like the idea, but it seems many (most?) real-world implementations actually use mb_strpos() !== false by default. https://github.com/danielstjules/Stringy/blob/df24ab62d2d8213bbbe88cc36fc35a4503b4bd7e/src/Stringy.php#L206-L215 https://github.com/illuminate/support/blob/6eff6cff19f7ad

Re: [PHP-DEV] Build instructions for Ubuntu 18.04 (and other systems)

2019-09-15 Thread Aegir Leet
Not super familiar with building PHP, but this should be a reasonable starting point, tested on a fresh install of Ubuntu 18.04.3: apt install -y autoconf gcc bison re2c libxml2-dev libssl-dev libsqlite3-dev libcurl4-openssl-dev libpng-dev libwebp-dev libjpeg-dev vflib3-dev libc-client-dev libkrb5

Re: [PHP-DEV] [RFC] Union Types v2

2019-09-04 Thread Aegir Leet
On the subject of using GitHub for this RFC: Personally, I think GitHub is a much better platform than the mailing list for this kind of discussion. Mailing list threads are just not very accessible to the average PHP user. Reading them through externals.io is an OK experience, but actually con

Re: [PHP-DEV] [RFC] Reclassifying engine warnings

2019-08-29 Thread Aegir Leet
but I don't see any point in discussing it further here, so I'll go back to lurking now. On 29.08.2019 16:22, Zeev Suraski wrote: > > > On Thu, Aug 29, 2019 at 4:02 PM Aegir Leet via internals > mailto:internals@lists.php.net>> wrote: > > I know what the manua

Re: [PHP-DEV] [RFC] Reclassifying engine warnings

2019-08-29 Thread Aegir Leet via internals
t semantics, don't you think a program that generates a constant stream of notices is a bit strange? That sounds like something everyone would naturally want to avoid. You don't drive your car with the check engine light permanently on and say "this is fine", right? On 29

Re: [PHP-DEV] Re: [RFC] Reclassifying engine warnings

2019-08-29 Thread Aegir Leet via internals
I'm sorry, but if you seriously believe doing something that generates a notice (or warning, or error, ...) is not a bug - you're delusional. That is the very definition of a bug and notices/warnings/errors etc. are the mechanism the language uses to report these bugs to the developer. If doing