Re: [PHP-DEV] [RFC] Consolidate Coding Standards Policy Document

2024-12-22 Thread Ben Ramsey
On Wed, Dec 18, 2024 at 11:39 Derick Rethans wrote: > Hi, > > I would like to propose the "Consolidate Coding Standards Policy > Document" RFC, which follows up from the Policy Repository RFC[1]'s > future scope section. > > This proposal suggests adopting the changes to the Coding Standards and

Re: [PHP-DEV] Discussion: Remove file statcache?

2024-12-22 Thread Rowan Tommins [IMSoP]
On 22 December 2024 20:32:47 GMT, Niels Dossche wrote: >All in all though, I'm not convinced by the parameter approach. >I'd like a proper solution rather than some plaster. >There are some options: >1) Try to fix the stat cache. >2) Put stat cache behind an ini knob. >3) Get rid of the stat ca

Re: [PHP-DEV] Discussion: Remove file statcache?

2024-12-22 Thread Niels Dossche
On 22/12/2024 13:16, Rowan Tommins [IMSoP] wrote: > On 21/12/2024 20:50, Niels Dossche wrote: >> Adding a parameter for a cache, which should've been transparent in the >> first place, to every file operation is messy. > > > I would say it's less messy than having to work out when to turn a glob

Re: [PHP-DEV] Discussion: Remove file statcache?

2024-12-22 Thread Calvin Buckley
On Dec 22, 2024, at 10:57 AM, Kévin Dunglas wrote: > > On Sun, Dec 22, 2024 at 10:44 AM Jakub Zelenka wrote: > Thinking about it, there might be a possibility to address it (at least on > Linux) using fanotify. Not sure about other platforms but maybe there are > some solutions to address it.

Re: [PHP-DEV] C Unit testing and mocking

2024-12-22 Thread Jakub Zelenka
On Thu, Dec 19, 2024 at 1:10 PM Christoph M. Becker wrote: > On 16.12.2024 at 21:05, Christoph M. Becker wrote: > > > Especially on Windows, where we have different code paths, and sometimes > > even completely different code, it would be great to also have these > > unit tests. Given that link.

Re: [PHP-DEV] C Unit testing and mocking

2024-12-22 Thread Jakub Zelenka
On Mon, Dec 16, 2024 at 9:05 PM Christoph M. Becker wrote: > On 16.12.2024 at 14:18, Jakub Zelenka wrote: > > There was a suggestion of RFC but that might be a bit too much as it's > just > > an internal change / addition. But certainly some overview on internals > > should be done so writing thi

Re: [PHP-DEV] Discussion: Remove file statcache?

2024-12-22 Thread Kévin Dunglas
On Sun, Dec 22, 2024 at 10:44 AM Jakub Zelenka wrote: > Thinking about it, there might be a possibility to address it (at least on > Linux) using fanotify. Not sure about other platforms but maybe there are > some solutions to address it. Also it might get a bit complex and not sure > how much th

Re: [PHP-DEV] Discussion: Remove file statcache?

2024-12-22 Thread Rowan Tommins [IMSoP]
On 21/12/2024 20:50, Niels Dossche wrote: Adding a parameter for a cache, which should've been transparent in the first place, to every file operation is messy. I would say it's less messy than having to work out when to turn a global setting on or off. In particular, it would be horrible fo

Re: [PHP-DEV] Discussion: Remove file statcache?

2024-12-22 Thread Jakub Zelenka
> I suppose a possible alternative would be to modify all file system >> mutation functions (file_put_contents(), touch(), etc.) to flush the cache, >> which for whatever reason doesn't happen now. That would be above my skill >> level, though, so someone else would need to do it. Also, I don't k