Re: [PHP-DEV] Asymmetric visibility is a BC break

2024-10-13 Thread Valentin Udaltsov
On Mon, 14/10/2024 at 06:01, Larry Garfield wrote: > > On Sun, Oct 13, 2024, at 9:37 PM, Valentin Udaltsov wrote: > > > > First of all, I have already agreed above that PHP does not have a BC > > break here. Now we are discussing the potential problems in the PHP > > ecosystem and how they could b

Re: [PHP-DEV] Asymmetric visibility is a BC break

2024-10-13 Thread Larry Garfield
On Sun, Oct 13, 2024, at 9:37 PM, Valentin Udaltsov wrote: > First of all, I have already agreed above that PHP does not have a BC > break here. Now we are discussing the potential problems in the PHP > ecosystem and how they could be mitigated. Ilija and I have discussed this issue a bit. The

Re: [PHP-DEV] Asymmetric visibility is a BC break

2024-10-13 Thread Valentin Udaltsov
On Mon, 14/10/2024 05:01, Jordan LeDoux : > > > > On Sun, Oct 13, 2024 at 5:03 PM Valentin Udaltsov > wrote: >> >> On Mon, 14 Oct 2024 at 01:28, Jordan LeDoux : >> > Backwards compatible has never, in any work I've done through my entire >> > career, meant something like "if you take old code an

Re: [PHP-DEV] Asymmetric visibility is a BC break

2024-10-13 Thread Jordan LeDoux
On Sun, Oct 13, 2024 at 5:03 PM Valentin Udaltsov < udaltsov.valen...@gmail.com> wrote: > On Mon, 14 Oct 2024 at 01:28, Jordan LeDoux : > > Backwards compatible has never, in any work I've done through my entire > career, meant something like "if you take old code and then update it to > the new v

Re: [PHP-DEV] Asymmetric visibility is a BC break

2024-10-13 Thread Valentin Udaltsov
On Mon, 14/10/2024 04:07, Bilge wrote: > > On 14/10/2024 01:02, Valentin Udaltsov wrote: > > The problem is that in practice most of the PHP libraries consider > > themselves to be compatible with newer PHP versions. > > > > For instance, Symfony PropertyInfo uses `"php": ">=8.2"` constraint in >

[PHP-DEV][DISCUSSION][RFC] Grapheme cluster for levenshtein function

2024-10-13 Thread youkidearitai
Hi, internals. I creating grapheme_levenshtein function that measure levenshtein distance based on grapheme cluster in Unicode. https://github.com/php/php-src/pull/16428 RFC is here: https://wiki.php.net/rfc/grapheme_levenshtein I want to discussion about grapheme_levenshtein function. Feel free

Re: [PHP-DEV] Asymmetric visibility is a BC break

2024-10-13 Thread Bilge
On 14/10/2024 01:02, Valentin Udaltsov wrote: The problem is that in practice most of the PHP libraries consider themselves to be compatible with newer PHP versions. For instance, Symfony PropertyInfo uses `"php": ">=8.2"` constraint in its `composer.json`. That seems like a problem they have

Re: [PHP-DEV] Asymmetric visibility is a BC break

2024-10-13 Thread Valentin Udaltsov
On Mon, 14 Oct 2024 at 01:28, Jordan LeDoux : > Backwards compatible has never, in any work I've done through my entire > career, meant something like "if you take old code and then update it to the > new version incorrectly, it doesn't work"... that seems... obvious? > > What exactly is the clai

Re: [PHP-DEV] Asymmetric visibility is a BC break

2024-10-13 Thread Jordan LeDoux
On Fri, Oct 11, 2024 at 3:34 AM Rob Landers wrote: > On Fri, Oct 11, 2024, at 12:20, Jonathan Vollebregt wrote: > > > A "proper" implementation won't break, but there may be subtle ways that > "improper" implementations will break and thus it should be considered a BC > break. > > This thread is