Re: [PHP-DEV][DISCUSSION] Multibyte for levenshtein function

2024-10-04 Thread Tim Düsterhus
Hi Am 2024-09-25 09:21, schrieb youkidearitai: I tried implement mb_levenshtein function and create an RFC. https://wiki.php.net/rfc/mb_levenshtein https://github.com/php/php-src/pull/16043 I would like discussion, feel free to comment. Thank you for your RFC. I share the concern raised by cm

Re: [PHP-DEV] Asymmetric visibility Reflection API problems

2024-10-04 Thread Ilija Tovilo
Hi Valentin Thank you for bringing up your concerns. On Thu, Oct 3, 2024 at 3:32 PM Valentin Udaltsov wrote: > > We are going to talk about the asymmetric visibility RFC [2] and the > new `ReflectionProperty::is(Private|Protected)Set()` > methods. Consider a class and reflected facts about it's

Re: [PHP-DEV] [RFC] Policy on 3rd party code

2024-10-04 Thread Larry Garfield
On Fri, Oct 4, 2024, at 6:22 AM, Derick Rethans wrote: > On Wed, 2 Oct 2024, Larry Garfield wrote: > >> Since Jim's RFC proposal was criticized for being too vague, I hereby >> offer a somewhat more prescriptive policy proposal on using 3rd party >> code. (With JIm's blessing.) It's still more

Re: [PHP-DEV] Asymmetric visibility Reflection API problems

2024-10-04 Thread Tim Düsterhus
Hi This thread is a good example why RFCs with a large impact should ideally be implemented well in advance of feature freeze. Am 2024-10-03 15:32, schrieb Valentin Udaltsov: Here's why it works this way. Internally properties with symmetric visibility do not have an asymmetric flag. That is

Re: [PHP-DEV] [RFC] [Discussion] Add get_declared_enums() function

2024-10-04 Thread Tim Düsterhus
Hi Am 2024-10-04 13:44, schrieb Nicolas Grekas: # Introduction of the new function: get_declared_enums() About this proposal, I shared a one-liner in the previous thread that shows listing only enums is trivial already. IMHO we don't need this function since the engine already provides everyt

Re: [PHP-DEV] [RFC] [Discussion] Add get_declared_enums() function

2024-10-04 Thread Tim Düsterhus
Hi Am 2024-10-03 14:01, schrieb Gina P. Banyard: As a counterpoint to the argument presented on the list that Enums should still be returned by get_declared_list() because they are "classes": Interfaces and traits are also "classes" internally, and yet they are not returned. We make a distinct

Re: [PHP-DEV] [RFC] Policy on 3rd party code

2024-10-04 Thread Tim Düsterhus
Hi Am 2024-10-02 20:36, schrieb Larry Garfield: Since Jim's RFC proposal was criticized for being too vague, I hereby offer a somewhat more prescriptive policy proposal on using 3rd party code. Thank you. I'm not yet sure if I'm completely happy with it, but for me it's already a much more a

Re: [PHP-DEV] [RFC] [Discussion] Add get_declared_enums() function

2024-10-04 Thread Nicolas Grekas
Hi Juliette, L.S., > > After the earlier discussion [1] regarding this topic in August, it is our > pleasure to present the RFC to add a `get_declared_enums()` function to PHP > for discussion. > > https://wiki.php.net/rfc/get_declared_enums > > We look forward to your feedback and hope for a cons

Re: [PHP-DEV] [RFC] Policy on 3rd party code

2024-10-04 Thread Derick Rethans
On Wed, 2 Oct 2024, Larry Garfield wrote: > Since Jim's RFC proposal was criticized for being too vague, I hereby > offer a somewhat more prescriptive policy proposal on using 3rd party > code. (With JIm's blessing.) It's still more heuristics than rules, > but I think that's the right approa

Re: [PHP-DEV] [RFC] [Discussion] Add get_declared_enums() function

2024-10-04 Thread Derick Rethans
On Wed, 2 Oct 2024, Juliette Reinders Folmer wrote: > L.S., > > After the earlier discussion [1] regarding this topic in August, it is our > pleasure to present the RFC to add a `get_declared_enums()` function to PHP > for discussion. > > https://wiki.php.net/rfc/get_declared_enums > > We look