Hi internals
I opened a PR for PHP 8.5 to add $outerHTML to the DOM extension.
PR link: https://github.com/php/php-src/pull/15887
This is in line with adding more functionality from the DOM spec into PHP.
Just checking here if anyone objects to this or thinks this needs an RFC.
Kind regards
Niels
On Sep 28, 2024, at 13:23, Jonathan Vollebregt wrote:
>
>> Okay. My point is that you cannot know (unless there are no circular
>> dependencies) *when* a destructor is called by the engine;
>
> The benefit of non-public visibility isn't when it's called, but how many
> times it's called. If yo
On Sat, 28 Sept 2024 at 13:03, Christoph M. Becker
wrote:
> On 27.09.2024 at 18:22, Arvids Godjuks wrote:
>
> > I agree with the general sentiment that alpha/beta/rc should be followed
> in
> > their canonical form:
> > - Alpha - API/ABI gets broken, new stuff gets introduced, big
> > implementat
Okay. My point is that you cannot know (unless there are no circular
dependencies) *when* a destructor is called by the engine;
The benefit of non-public visibility isn't when it's called, but how
many times it's called. If you can declare your destructor non-public
you can be confident it'll
On Sat, Sep 28, 2024, at 16:46, Christoph M. Becker wrote:
> On 28.09.2024 at 16:21, Jonathan Vollebregt wrote:
>
> >> Hmm, I wonder about the use-cases of userland destructors. It seems to
> >> me they are mostly useful for sanity checks, and maybe to close
> >> resources. Are there others?
> >
On 28.09.2024 at 16:21, Jonathan Vollebregt wrote:
>> Hmm, I wonder about the use-cases of userland destructors. It seems to
>> me they are mostly useful for sanity checks, and maybe to close
>> resources. Are there others?
>>
>> If not, I wouldn't worry much about the visibility of destructors,
Hmm, I wonder about the use-cases of userland destructors. It seems to
me they are mostly useful for sanity checks, and maybe to close
resources. Are there others?
If not, I wouldn't worry much about the visibility of destructors,
because resources are scheduled for replacement anyway.
Beside
On 27.09.2024 at 18:22, Arvids Godjuks wrote:
> I agree with the general sentiment that alpha/beta/rc should be followed in
> their canonical form:
> - Alpha - API/ABI gets broken, new stuff gets introduced, big
> implementations happen
> - Beta - new big additions are not allowed any more and int
On 27.09.2024 at 14:32, Jonathan Vollebregt wrote:
> Long story short I'd like to suggest:
>
> 1. Allow the engine to call protected destructors (again)
> 2. Warning when declaring a private destructor as with other magic methods
> 3. Documentation update to confirm private destructors aren't allo
