Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4

2024-07-23 Thread Peter Stalman
On Mon, Jul 22, 2024 at 9:06 AM Derick Rethans wrote: > - Deprecate md5(), sha1(), md5_file(), and sha1_file() (just says "large > impact") About 1.2 million. https://github.com/search?q=%28md5+OR+md5_file+OR+sha1+OR+sha1_file%29+language%3APHP+&type=code The proposed deprecation of these fu

Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2

2024-07-23 Thread Larry Garfield
On Mon, Jul 22, 2024, at 7:07 PM, Tim Düsterhus wrote: > Hi > > On 7/20/24 03:14, Larry Garfield wrote: >> Baring any new developments, we plan to start the vote early next week. > > I've went through the RFC once more. I have the following remarks: > >> For that reason, a private(set) property is

Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4

2024-07-23 Thread Larry Garfield
On Tue, Jul 23, 2024, at 4:00 PM, Matthew Weier O'Phinney wrote: >> However, a few people indicated a desire to have an explicit wildcard _ >> anyway, even if it's redundant, as it's a more common and standard approach >> in other languages. We've indicated that we are open to making that an >

Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4

2024-07-23 Thread Matthew Weier O'Phinney
On Tue, Jul 23, 2024 at 9:06 AM Larry Garfield wrote: > On Tue, Jul 23, 2024, at 1:42 PM, Matthew Weier O'Phinney wrote: > > On Fri, Jul 19, 2024 at 12:41 PM Gina P. Banyard > wrote: > >> Hello internals, > >> > >> I have opened the vote for the mega deprecation RFC: > >> https://wiki.php.net/rf

Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4

2024-07-23 Thread Larry Garfield
On Tue, Jul 23, 2024, at 2:41 PM, Christoph M. Becker wrote: > On 23.07.2024 at 16:04, Larry Garfield wrote: > >> On Tue, Jul 23, 2024, at 1:42 PM, Matthew Weier O'Phinney wrote: >> >>> On Fri, Jul 19, 2024 at 12:41 PM Gina P. Banyard wrote: >>> I have opened the vote for the mega deprecation

Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4

2024-07-23 Thread Christoph M. Becker
On 23.07.2024 at 16:04, Larry Garfield wrote: > On Tue, Jul 23, 2024, at 1:42 PM, Matthew Weier O'Phinney wrote: > >> On Fri, Jul 19, 2024 at 12:41 PM Gina P. Banyard wrote: >> >>> I have opened the vote for the mega deprecation RFC: >>> https://wiki.php.net/rfc/deprecations_php_8_4 >> >> The sec

Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4

2024-07-23 Thread Christoph M. Becker
Hi Jakub! On 22.07.2024 at 12:59, Jakub Zelenka wrote: > On Fri, Jul 19, 2024 at 6:42 PM Gina P. Banyard wrote: > >> I have opened the vote for the mega deprecation RFC: >> https://wiki.php.net/rfc/deprecations_php_8_4 > > Just wanted to send some reasoning of my no votes. > > The CSV one is als

Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4

2024-07-23 Thread Larry Garfield
On Tue, Jul 23, 2024, at 1:42 PM, Matthew Weier O'Phinney wrote: > On Fri, Jul 19, 2024 at 12:41 PM Gina P. Banyard wrote: >> Hello internals, >> >> I have opened the vote for the mega deprecation RFC: >> https://wiki.php.net/rfc/deprecations_php_8_4 >> >> Reminder, each vote must be submitted i

Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4

2024-07-23 Thread Matthew Weier O'Phinney
On Fri, Jul 19, 2024 at 12:41 PM Gina P. Banyard wrote: > Hello internals, > > I have opened the vote for the mega deprecation RFC: > https://wiki.php.net/rfc/deprecations_php_8_4 > > Reminder, each vote must be submitted individually. > > > Best regards, > > > Gina P. Banyard > The section "De

Re: [PHP-DEV] Request for opinions: bug vs feature -changeintokenization of yield from

2024-07-23 Thread Christoph M. Becker
On 21.07.2024 at 13:28, Tim Düsterhus wrote: > On 7/20/24 20:31, Christoph M. Becker wrote: > >> If the tokenizer would tokenize a whole file as a single token, would >> that also be correct?  Of course, I'm exaggerating, but > > The function is documented as: > >> token_get_all() parses the given