Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Larry Garfield
On Sat, Jul 20, 2024, at 11:51 AM, Tim Düsterhus wrote: > Hi > > On 7/20/24 18:40, Juliette Reinders Folmer wrote: >> Tim, you're making my point for me. This is *exactly* why the current >> change should be reverted. > > I am not sure how you read "PHP users have no idea what a token is" as > an

Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2

2024-07-20 Thread Larry Garfield
On Sat, Jul 20, 2024, at 7:22 AM, Rodrigo Vieira wrote: > Will the alternative syntax on hook not even be put to a vote? It was, a year and a half ago when Aviz was first proposed. The preference was split, but leaned toward the prefix-style syntax. So we went with that. I don't think we'll e

Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2

2024-07-20 Thread Larry Garfield
On Sat, Jul 20, 2024, at 10:47 AM, Ilija Tovilo wrote: > Hi Rob > > On Sat, Jul 20, 2024 at 3:47 PM Rob Landers wrote: >> >> On Sat, Jul 20, 2024, at 03:14, Larry Garfield wrote: >> >> On Wed, May 29, 2024, at 2:15 PM, Larry Garfield wrote: >> > >> > https://wiki.php.net/rfc/asymmetric-visibility-

Re: [PHP-DEV] Request for opinions: bug vs feature - changeintokenization of yield from

2024-07-20 Thread Christoph M. Becker
On 20.07.2024 at 18:51, Tim Düsterhus wrote: > >> And not, like it is now, an undocumented, random change creating an >> inconsistency in the Tokenizer. > > The tokenizer is doing the right thing: It tokenizes the PHP source > code. It is absolutely normal that PHP first and second-digit updates >

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Deleu
On Sat, Jul 20, 2024 at 1:53 PM Tim Düsterhus wrote: > Hi > > On 7/20/24 18:40, Juliette Reinders Folmer wrote: > > Tim, you're making my point for me. This is *exactly* why the current > > change should be reverted. > > I am not sure how you read "PHP users have no idea what a token is" as > an

Re: [PHP-DEV] Lock down old bug tracker to developers only?

2024-07-20 Thread Jim Winstead
On Sat, Jul 20, 2024, at 10:20 AM, Christoph M. Becker wrote: > Quite a while ago, Damian had suggested to "don't allow any further > edits, comments, uploads, or other activity except by php.net developer > accounts."[1] In my opinion, this is overdue, so after a very brief > "discussion" on this

[PHP-DEV] Lock down old bug tracker to developers only?

2024-07-20 Thread Christoph M. Becker
Hi all! I think the proper mailing list to discuss this is php-webmaster, but since many whom this may concern are not subscribed there, so I'm cross-posting to internals, too. Sorry if this is not appropriate. Quite a while ago, Damian had suggested to "don't allow any further edits, comments,

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Tim Düsterhus
Hi On 7/20/24 18:40, Juliette Reinders Folmer wrote: Tim, you're making my point for me. This is *exactly* why the current change should be reverted. I am not sure how you read "PHP users have no idea what a token is" as an argument in favor of reverting the change, because reverting the cha

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Juliette Reinders Folmer
On 20-7-2024 18:04, Tim Düsterhus wrote: PHP users have no idea what a token is internally. I'm looking at this from a PHP user perspective. It looks like two keywords, it walks like two keywords and it quacks like two keywords. I find it reasonable for users to consider this as two keywords an

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Tim Düsterhus
Hi On 7/20/24 17:42, Juliette Reinders Folmer wrote: I already mentioned cast tokens before. Whitespace is perfectly acceptable within the parentheses of these. Comments are not: https://3v4l.org/A6Sgj and https://3v4l.org/nE9H8 Now you may argue that cast tokens "feel like" a single operator,

Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2

2024-07-20 Thread Ilija Tovilo
Hi Rob On Sat, Jul 20, 2024 at 3:47 PM Rob Landers wrote: > > On Sat, Jul 20, 2024, at 03:14, Larry Garfield wrote: > > On Wed, May 29, 2024, at 2:15 PM, Larry Garfield wrote: > > > > https://wiki.php.net/rfc/asymmetric-visibility-v2 > > Hi folks. After a side quest to polish off hooks, we're ne

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Matthew Weier O'Phinney
On Sat, Jul 20, 2024, 9:31 AM Tim Düsterhus wrote: > Hi > > On 7/19/24 00:51, Christoph M. Becker wrote: > > And frankly, how much code would be affected? I mean, does anybody > > actually put a comment between `yield` and `from`? Is there a case > > where this may make sense? "Because we can"

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Tim Düsterhus
Hi On 7/19/24 07:22, Juliette Reinders Folmer wrote: More than anything, I find it concerning that this change sets a precedent for tokens to include comments. Just as an example: what does this mean for the PHP 8.0 nullsafe object operator ? Should we now suddenly allow that to be written as `

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Rob Landers
On Sat, Jul 20, 2024, at 16:35, Marco Aurélio Deleu wrote: > > > On 20 Jul 2024, at 11:30, Tim Düsterhus wrote: > > > > Hi > > > >> On 7/19/24 00:51, Christoph M. Becker wrote: > >> And frankly, how much code would be affected? I mean, does anybody > >> actually put a comment between `yield

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Marco Aurélio Deleu
> On 20 Jul 2024, at 11:30, Tim Düsterhus wrote: > > Hi > >> On 7/19/24 00:51, Christoph M. Becker wrote: >> And frankly, how much code would be affected? I mean, does anybody >> actually put a comment between `yield` and `from`? Is there a case >> where this may make sense? "Because we ca

Re: [PHP-DEV] Request for opinions: bug vs feature - change intokenization of yield from

2024-07-20 Thread Tim Düsterhus
Hi On 7/19/24 00:51, Christoph M. Becker wrote: And frankly, how much code would be affected? I mean, does anybody actually put a comment between `yield` and `from`? Is there a case where this may make sense? "Because we can" isn't a strong argument, in my opinion. I don't really follow thi

Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2

2024-07-20 Thread Rob Landers
On Sat, Jul 20, 2024, at 03:14, Larry Garfield wrote: > On Wed, May 29, 2024, at 2:15 PM, Larry Garfield wrote: > > As promised, Ilija and I offer this revised version of asymmetric > > visibility. > > > > https://wiki.php.net/rfc/asymmetric-visibility-v2 > > > > It's still essentially the same

Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2

2024-07-20 Thread Rodrigo Vieira
Will the alternative syntax on hook not even be put to a vote? I think the "prefix-style" syntax breaks the standard property signature template that exists since PHP 5! Natural syntax: $; With prefix-style: (set) $; This introduces a syntax that is totally unexpected to natural reading.