Re: [PHP-DEV] automatic formatting checks for pull requests?

2024-02-17 Thread Hans Henrik Bergan
i have tested running clang-format against the entire php-src codebase, and there is only 1 file it breaks: ext/spl/spl_directory_arginfo.h more details at https://github.com/php/php-src/pull/13417#issuecomment-1950920114 On Sun, 18 Feb 2024 at 01:45, Derick Rethans wrote: > > On 17 February 202

Re: [PHP-DEV] automatic formatting checks for pull requests?

2024-02-17 Thread Hans Henrik Bergan
On Sun, 18 Feb 2024 at 00:51, Ilija Tovilo wrote: > > Hi Hans > > On Sat, Feb 17, 2024 at 3:31 PM Gina P. Banyard wrote: > > > > On Saturday, 17 February 2024 at 11:24, Hans Henrik Bergan > > wrote: > > > > > Can we add automatic formatting checks for pull requests? > > > Made a PR: https://git

Re: [PHP-DEV] RFC Proposal : Allows calling non-static public methods through the __callStatic magic method instead of throwing an error.

2024-02-17 Thread Jorg Sowa
For the reference to the others: https://3v4l.org/UmPVo Kind regards, Jorg

Re: [PHP-DEV] automatic formatting checks for pull requests?

2024-02-17 Thread Derick Rethans
On 17 February 2024 22:18:05 GMT, Ilija Tovilo wrote: >Hi Hans > >On Sat, Feb 17, 2024 at 3:31 PM Gina P. Banyard wrote: >> >> On Saturday, 17 February 2024 at 11:24, Hans Henrik Bergan >> wrote: >> >> > Can we add automatic formatting checks for pull requests? >> > Made a PR: https://github.co

[PHP-DEV] New ext-dom features

2024-02-17 Thread Niels Dossche
Hi internals After (and if) my current in-voting RFC about spec-compliance DOM passes, some features become more easily possible to implement due to the necessary building blocks becoming in place in the extension code. I would like to start implementing those. Therefore, I'd like to gauge the

Re: [PHP-DEV] automatic formatting checks for pull requests?

2024-02-17 Thread Ilija Tovilo
Hi Hans On Sat, Feb 17, 2024 at 3:31 PM Gina P. Banyard wrote: > > On Saturday, 17 February 2024 at 11:24, Hans Henrik Bergan > wrote: > > > Can we add automatic formatting checks for pull requests? > > Made a PR: https://github.com/php/php-src/pull/13417 > > It would be nice to have some forma

Re: [PHP-DEV] RFC Proposal : Allows calling non-static public methods through the __callStatic magic method instead of throwing an error.

2024-02-17 Thread Claude Pache
> Le 17 févr. 2024 à 16:51, Larry Garfield a écrit : > > On Fri, Feb 16, 2024, at 7:56 PM, 하늘아부지 wrote: >> Hi. >> I'd like to propose an RFC, but I don't have the authority. >> Below is my suggestion. >> If you think this makes sense, please write an RFC for me. >> Sincerely. >> >> --

Re: [PHP-DEV] automatic formatting checks for pull requests?

2024-02-17 Thread Hans Henrik Bergan
On Sat, Feb 17, 2024, 15:27 Gina P. Banyard wrote: > On Saturday, 17 February 2024 at 11:24, Hans Henrik Bergan < > h...@loltek.net> wrote: > > > Can we add automatic formatting checks for pull requests? > > Made a PR: https://github.com/php/php-src/pull/13417 > > > > php-src use "tabs" instead o

[PHP-DEV] Re: Testing new list server

2024-02-17 Thread Calvin Buckley
On Feb 14, 2024, at 11:16 AM, Derick Rethans wrote: > > Please don't be alarmed, we're moving the lists over to a new machine. I've been getting a ton of spam from php-general@ recently. I suspect the changeover might be related.

Re: [PHP-DEV] Re: [RFC] OOP API for cURL extension

2024-02-17 Thread Larry Garfield
On Thu, Feb 15, 2024, at 9:44 AM, Sara Golemon wrote: > Summarizing replies so far. Won't be able to update the RFC > immediately as my day job needs me, but some great discussions already, > gang. Thanks! > > * Define the conditions under which exceptions will be thrown (and > which exceptions

Re: [PHP-DEV] RFC Proposal : Allows calling non-static public methods through the __callStatic magic method instead of throwing an error.

2024-02-17 Thread Larry Garfield
On Fri, Feb 16, 2024, at 7:56 PM, 하늘아부지 wrote: > Hi. > I'd like to propose an RFC, but I don't have the authority. > Below is my suggestion. > If you think this makes sense, please write an RFC for me. > Sincerely. > > -- > > = Introductio

Re: [PHP-DEV] RE: Testing new list server

2024-02-17 Thread tag Knife
On Fri, 16 Feb 2024 at 23:50, Jorg Sowa wrote: > Hello Derick, > there is something wrong. I don't get all of the emails from the new > setup, only part. Examples of emails I didn't receive: > - https://externals.io/message/122391 > - https://externals.io/message/122390 > - https://externals.io/m

Re: [PHP-DEV] Re: [RFC] OOP API for cURL extension

2024-02-17 Thread Gina P. Banyard
On Saturday, 17 February 2024 at 07:41, Kalle Sommer Nielsen wrote: > Hi Sara > > Den tors. 15. feb. 2024 kl. 21.08 skrev Sara Golemon poll...@php.net: > > > * Better typing for setOpt() methods. > > Comment: Yep, this is a good and fair point. It's going to take a little > > more dicing up o

Re: [PHP-DEV] automatic formatting checks for pull requests?

2024-02-17 Thread Gina P. Banyard
On Saturday, 17 February 2024 at 11:24, Hans Henrik Bergan wrote: > Can we add automatic formatting checks for pull requests? > Made a PR: https://github.com/php/php-src/pull/13417 > > php-src use "tabs" instead of "spaces", that is... quite unusual, > and I'm probably not the first person to a

Re: [PHP-DEV] Requesting RFC karma

2024-02-17 Thread Hans Henrik Bergan
On Sat, 17 Feb 2024 at 08:22, Hans Henrik Bergan wrote: > > My name is "Hans Henrik Bergan", usually go by the nickname > "divinity76", I've contributed to OSS (including PHP) for years, and > am currently involved in 3 things that might require an RFC, and > requesting RFC karma for wiki account

Re: [PHP-DEV] Re: [RFC] OOP API for cURL extension

2024-02-17 Thread Kalle Sommer Nielsen
Hi Sara Den tors. 15. feb. 2024 kl. 21.08 skrev Sara Golemon : > * Better typing for setOpt() methods. > Comment: Yep, this is a good and fair point. It's going to take a little > more dicing up of the current implementation, but hopefully not too rough. > Proposal: Keep untyped setOption()

Re: [PHP-DEV] int|float for sleep? sleep(0.1) => sleep 0.1 seconds

2024-02-17 Thread Hans Henrik Bergan
On Fri, 16 Feb 2024 at 09:36, Alexandru Pătrănescu wrote: > > > On Fri, Feb 16, 2024 at 10:18 AM Hans Henrik Bergan wrote: >> >> Can we make sleep accept int|float? >> Made a PR: https://github.com/php/php-src/pull/13401 >> >> For years when I wanted to sleep for 0.1 seconds, it annoyed me that I

Re: [PHP-DEV] RE: Testing new list server

2024-02-17 Thread Ilija Tovilo
Hi On Sat, Feb 17, 2024 at 12:17 AM Jorg Sowa wrote: > > Hello Derick, > there is something wrong. I don't get all of the emails from the new setup, > only part. Examples of emails I didn't receive: > - https://externals.io/message/122391 > - https://externals.io/message/122390 > - https://exter

[PHP-DEV] Re: [RFC] OOP API for cURL extension

2024-02-17 Thread Rowan Tommins
On 16 February 2024 16:09:32 GMT, Rowan Tommins wrote: >public function executeAndReturn(): string >public function executeAndOutput(): void I guess I missed: public function executeToFile(Stream $fileHandle): void public function executeWithCallback(callable $wrIteFunction): void which would

[PHP-DEV] automatic formatting checks for pull requests?

2024-02-17 Thread Hans Henrik Bergan
Can we add automatic formatting checks for pull requests? Made a PR: https://github.com/php/php-src/pull/13417 php-src use "tabs" instead of "spaces", that is... quite unusual, and I'm probably not the first person to accidentally use spaces instead of tabs, ref https://github.com/php/php-src/pull

Re: [PHP-DEV] Requesting RFC karma

2024-02-17 Thread Ilija Tovilo
Hi Hans On 16.02.24 13:05, Hans Henrik Bergan wrote: My name is "Hans Henrik Bergan", usually go by the nickname "divinity76", I've contributed to OSS (including PHP) for years, and am currently involved in 3 things that might require an RFC, and requesting RFC karma for wiki account "divinity76

[PHP-DEV] R: [RFC] OOP API for cURL extension

2024-02-17 Thread ssil...@libero.it
Hi Sara, i like this proposal. Silvio From: Sara Golemon Sent: Wednesday, February 14, 2024 7:47 PM To: PHP internals Subject: [RFC] OOP API for cURL extension Good afternoon folks, I'd like to open discussion on adding OOP APIs to the cURL extension. https://w

[PHP-DEV] RFC Proposal : Allows calling non-static public methods through the __callStatic magic method instead of throwing an error.

2024-02-17 Thread 하늘아부지
Hi. I'd like to propose an RFC, but I don't have the authority. Below is my suggestion. If you think this makes sense, please write an RFC for me. Sincerely. -- = Introduction = Allows calling non-static public methods through the __

Re: [PHP-DEV] int|float for sleep? sleep(0.1) => sleep 0.1 seconds

2024-02-17 Thread Alexandru Pătrănescu
On Fri, Feb 16, 2024 at 10:18 AM Hans Henrik Bergan wrote: > Can we make sleep accept int|float? > Made a PR: https://github.com/php/php-src/pull/13401 > > For years when I wanted to sleep for 0.1 seconds, it annoyed me that I > couldn't do > `sleep(0.1);` > instead I had to do > `usleep(figure o

Re: [PHP-DEV] int|float for sleep? sleep(0.1) => sleep 0.1 seconds

2024-02-17 Thread Claude Pache
Hi, > > FWIW Python's `time.sleep` also works like this: > https://docs.python.org/3/library/time.html#time.sleep Python also implements the following: > If the sleep is interrupted by a signal and no exception is raised by the > signal handler, the sleep is restarted with a recomputed timeou

[PHP-DEV] Re: [RFC] OOP API for cURL extension

2024-02-17 Thread Rowan Tommins
On 15 February 2024 15:44:13 GMT, Sara Golemon wrote: >* CurlHandle::exec() mixed typing of return values. > Comment: Agreed. The `true` return value becomes meaningless in the >RETURNTRANSFER==false case. > Proposal: Update the RFC for CurlHandle::execute() to return ?string. Should we take t

Re: [PHP-DEV] [RFC] Deprecate implicitly nullable parameter type

2024-02-17 Thread Máté Kocsis
Hi Nicolas, Thanks for your input and proactive measures! I've just finished the analysis you asked for: - code: https://gist.github.com/kocsismate/c0d10c820606dfe297f09374aa634df5 - results: https://gist.github.com/kocsismate/cf3bdfbf35eb10224ee5ecd29b39656b TLDR: there are 880 packages out of 2

Re: [PHP-DEV] Registration apply for php wiki

2024-02-17 Thread Ilija Tovilo
Hi JaeHan! On Fri, Feb 16, 2024 at 10:53 AM 하늘아부지 wrote: > > Hi, My name is JaeHan Seo. (wiki username is daddyofsky) > > I hope I can make a proposal by registering on the php wiki. I can give you karma. Usually, RFC karma (which is what I'm guessing you're asking for) is granted for specific R