Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-13 Thread Marc Bennewitz
Hi Robert, On 13.10.23 13:44, Robert Landers wrote: On Fri, Oct 13, 2023 at 1:26 PM Jakub Zelenka wrote: On Tue, Sep 26, 2023 at 11:39 AM Marc Bennewitz wrote: Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding I would personally prefer a

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-13 Thread Marc Bennewitz
Hi Jakub, On 13.10.23 13:25, Jakub Zelenka wrote: On Tue, Sep 26, 2023 at 11:39 AM Marc Bennewitz wrote: Hi internals I'd like to put a new RFC under discussion: https://wiki.php.net/rfc/integer-rounding I would personally prefer a new function for rounding integers if anyone wants to rou

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-13 Thread Tim Düsterhus
Hi On 10/13/23 17:59, Michał Marcin Brzuchalski wrote: Considering the function supports two formats multipart/form-data or the application/x-www-form-urlencodedand the fact that the return type and required arguments differ in regards to format: content-type needed for multipart which returns t

Re: [PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-13 Thread Michał Marcin Brzuchalski
Hi Ilija, pt., 13 paź 2023, 13:15 użytkownik Ilija Tovilo napisał: > Hi everyone > > On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo > wrote: > > https://wiki.php.net/rfc/rfc1867-non-post > > Thank you for the feedback so far. I made a handful of changes to the RFC. > > * The function is renamed to

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-13 Thread Robert Landers
On Fri, Oct 13, 2023 at 1:26 PM Jakub Zelenka wrote: > > On Tue, Sep 26, 2023 at 11:39 AM Marc Bennewitz wrote: > > > Hi internals > > > > I'd like to put a new RFC under discussion: > > https://wiki.php.net/rfc/integer-rounding > > > > > I would personally prefer a new function for rounding inte

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-13 Thread Jakub Zelenka
On Thu, Oct 5, 2023 at 8:57 PM Tim Düsterhus wrote: > While this is not a bug fix that is appropriate for the current stable > branches, I don't see why it would not be appropriate for PHP 8.4 if > there's an RFC for it. > > In fact there is already a rounding bugfix (no RFC for that) in PHP 8.4:

Re: [PHP-DEV] [RFC] [Discussion] Rounding Integers as int

2023-10-13 Thread Jakub Zelenka
On Tue, Sep 26, 2023 at 11:39 AM Marc Bennewitz wrote: > Hi internals > > I'd like to put a new RFC under discussion: > https://wiki.php.net/rfc/integer-rounding > > I would personally prefer a new function for rounding integers if anyone wants to round large integers. The things is that the cur

[PHP-DEV] Re: [RFC][Under discussion] RFC1867 for non-POST HTTP verbs

2023-10-13 Thread Ilija Tovilo
Hi everyone On Fri, Oct 6, 2023 at 3:44 PM Ilija Tovilo wrote: > https://wiki.php.net/rfc/rfc1867-non-post Thank you for the feedback so far. I made a handful of changes to the RFC. * The function is renamed to request_parse_body() * The function will now throw instead of emitting warnings when

[PHP-DEV] [Round] Change the edge case of Round()

2023-10-13 Thread Saki Takamachi
Hi, internals I'm working on fixing a bug in `round()`. There was a discussion about what should be considered an edge case. For example, `0.285` is internally `0.28498`. Should this be considered an edge case? Or is it not an edge case? Regarding this issue, in 2008, the followin

Re: [PHP-DEV] Why did fibers get added to php core over something more fleshed out like swoole?

2023-10-13 Thread Robert Landers
On Fri, Oct 13, 2023 at 4:29 AM Deleu wrote: > > On Thu, Oct 12, 2023 at 10:00 PM Lanre Waju > wrote: > > > I find it puzzling that the PHP internals have chosen to delegate this > > specific functionality to userspace implementation. Fibers, in my view, > > seem somewhat limited without the addi