Re: [PHP-DEV] SimpleXML and JSON

2023-08-14 Thread Rowan Tommins
On 14 August 2023 13:40:40 BST, Niels Dossche wrote: >And you load it into simpleXML, the result of calling json_encode($the_simplexml_object) My usual reaction to this is "why would you take an object designed for accessing parts of an XML document, and serialise it to JSON?" Often, the ans

Re: [PHP-DEV] Removing support for the disable_classes INI setting

2023-08-14 Thread G. P. B.
On Mon, 14 Aug 2023 at 20:03, Larry Garfield wrote: > However, I think it should not get an exception for code-freeze. At best, > I could see a deprecation warning on it in 8.3 and remove in 8.4/9, but I > defer to the RMs on that front. > In its current state, this INI setting does nothing oth

Re: [PHP-DEV] Removing support for the disable_classes INI setting

2023-08-14 Thread Juliette Reinders Folmer
On 14-8-2023 16:17, G. P. B. wrote: Hello internals, While working on some DNF type bugs, I discovered some major issues around the disable_classes INI setting implementation. Such as: - A double-free of the type of a typed property - A use after free (which segfaults) when trying to access a p

Re: [PHP-DEV] Removing support for the disable_classes INI setting

2023-08-14 Thread Larry Garfield
On Mon, Aug 14, 2023, at 2:17 PM, G. P. B. wrote: > Hello internals, > > While working on some DNF type bugs, I discovered some major issues around > the disable_classes INI setting implementation. Such as: > > - A double-free of the type of a typed property > - A use after free (which segfaults) w

Re: [PHP-DEV] [RFC] Support optional suffix parameter in tempnam

2023-08-14 Thread Athos Ribeiro
On Mon, Aug 14, 2023 at 05:57:53PM +0200, Côme Chilliet wrote: Le mardi 8 août 2023, 21:11:01 CEST Athos Ribeiro a écrit : Hi internals, As a follow-up on my previous message here (https://marc.info/?l=php-internals&m=168912164828942&w=2), I would like to start the discussion on the "Support op

Re: [PHP-DEV] [RFC] Support optional suffix parameter in tempnam

2023-08-14 Thread Tim Düsterhus
Hi On 8/14/23 17:57, Côme Chilliet wrote: The RFC does not explain what benefits brings using tempnam($directory, $prefix, $suffix) over using tempnam($directory, $prefix).$suffix , which you can already use? As per the documentation of tempnam: Creates a file with a unique filename, with

Re: [PHP-DEV] [RFC] Support optional suffix parameter in tempnam

2023-08-14 Thread Côme Chilliet
Le mardi 8 août 2023, 21:11:01 CEST Athos Ribeiro a écrit : > Hi internals, > > As a follow-up on my previous message here > (https://marc.info/?l=php-internals&m=168912164828942&w=2), > I would like to start the discussion on the "Support optional suffix > parameter in tempnam" RFC. > https://wik

[PHP-DEV] Removing support for the disable_classes INI setting

2023-08-14 Thread G. P. B.
Hello internals, While working on some DNF type bugs, I discovered some major issues around the disable_classes INI setting implementation. Such as: - A double-free of the type of a typed property - A use after free (which segfaults) when trying to access a property defined on a disabled class th

[PHP-DEV] SimpleXML and JSON

2023-08-14 Thread Niels Dossche
Hi internals! While browsing through bugsnet I encountered this SimpleXML issue with 252 votes: https://bugs.php.net/bug.php?id=54632 TLDR: when you have a XML document (modified a bit from the example in the bugtracker): foobar And you load it into simpleXML, the result of calling json_enco