Re: [PHP-DEV] Re: [VOTE] Interface Default Methods

2023-07-13 Thread Deleu
Perhaps a little too late, but I was wondering whether folks that voted NO would reconsider in case this was made a bit more opt-in. There could be some bikesheding around syntax but essentially the idea would be a new RFC targeting 8.4 with the following adjustment: interface Foo { public fu

Re: [PHP-DEV] Security implications of parsing env variables in .ini

2023-07-13 Thread Dusk
On Jul 13, 2023, at 18:34, David Gebler wrote: > If you find any way to exploit this, you've already breached enough to > have sufficient access to read the entire environment available to the PHP > user anyway I think Sergii's concern is that an application might be using parse_ini_string() to

Re: [PHP-DEV] Security implications of parsing env variables in .ini

2023-07-13 Thread David Gebler
On Thu, Jul 13, 2023 at 10:25 PM Sergii Shymko wrote: > For instance, functions parse_ini_string() and parse_ini_file() do support > the aforementioned env variables syntax, because the underlying code is > reused. That means that these functions can potentially be exploited to > read sensitive i

Re: [PHP-DEV] Re: Default values for php.ini environment variables

2023-07-13 Thread Marc
On 13.07.23 17:39, Ben Ramsey wrote: On Jul 13, 2023, at 08:26, Derick Rethans wrote: Hi, coming forth out of an Xdebug issue (https://bugs.xdebug.org/view.php?id=2174) I made a pull request so that it is possible to use a fallback value in environment variables in INI files, such as in: xd

[PHP-DEV] Security implications of parsing env variables in .ini

2023-07-13 Thread Sergii Shymko
Hi internals team, The discussion of extending the .ini env variable parsing capabilities with ability to specify defaults it occurred to me that the while feature of env variables may have undesirable security implications. For instance, functions parse_ini_string() and parse_ini_file() do sup

Re: [PHP-DEV] [VOTE] Interface Default Methods

2023-07-13 Thread Larry Garfield
On Thu, Jul 13, 2023, at 3:09 PM, Robert Landers wrote: > I just want to say that between all of you, I get this feature now. > > Maybe someone should open an RFC where your vote doesn't count unless > you provide feedback on the list. (ban drive-by votes) > > We may not have the power to vote, but

Re: [PHP-DEV] [VOTE] Interface Default Methods

2023-07-13 Thread Tim Düsterhus
Hi On 7/12/23 06:00, G. P. B. wrote: I find the Rust Seek trait(/type class) a very concise example of the usefulness, and where the implementation of a default method is far from concrete. Requiring an implementation to provide the implementation for seek(int $position) But being able to provid

[PHP-DEV] Re: Default values for php.ini environment variables

2023-07-13 Thread Ben Ramsey
> On Jul 13, 2023, at 08:26, Derick Rethans wrote: > > Hi, > > coming forth out of an Xdebug issue > (https://bugs.xdebug.org/view.php?id=2174) I made a pull request so that > it is possible to use a fallback value in environment variables in INI > files, such as in: > > xdebug.start_with_reque

Re: [PHP-DEV] Default values for php.ini environment variables

2023-07-13 Thread Flávio Heleno
I don't have voting rights, but this is a very positive addition IMO. On Thu, Jul 13, 2023 at 10:27 AM Derick Rethans wrote: > Hi, > > coming forth out of an Xdebug issue > (https://bugs.xdebug.org/view.php?id=2174) I made a pull request so that > it is possible to use a fallback value in envir

Re: [PHP-DEV] [VOTE] Interface Default Methods

2023-07-13 Thread Robert Landers
I just want to say that between all of you, I get this feature now. Maybe someone should open an RFC where your vote doesn't count unless you provide feedback on the list. (ban drive-by votes) We may not have the power to vote, but we can open RFCs. -- PHP Internals - PHP Runtime Development Ma

[PHP-DEV] Default values for php.ini environment variables

2023-07-13 Thread Derick Rethans
Hi, coming forth out of an Xdebug issue (https://bugs.xdebug.org/view.php?id=2174) I made a pull request so that it is possible to use a fallback value in environment variables in INI files, such as in: xdebug.start_with_request = ${PHP_XDEBUG_START_WITH_REQUEST:-default} This is a syntax tha

Re: [PHP-DEV] [VOTE] Interface Default Methods

2023-07-13 Thread Wendell Adriel
>> I want to pitch in, agreeing with Larry's message here. >> >> - There are multiple real life use cases where the combo trait/interface >> could be replaced by interface default methods >> - Several modern language apply the technique in one form or another, so >> it's already proven to be valuab

Re: [PHP-DEV] [VOTE] Interface Default Methods

2023-07-13 Thread Deleu
On Thu, Jul 13, 2023 at 8:46 AM Brent Roose via internals < internals@lists.php.net> wrote: > I want to pitch in, agreeing with Larry's message here. > > - There are multiple real life use cases where the combo trait/interface > could be replaced by interface default methods > - Several modern lan

Re: [PHP-DEV] [VOTE] Interface Default Methods

2023-07-13 Thread Brent Roose via internals
I want to pitch in, agreeing with Larry's message here. - There are multiple real life use cases where the combo trait/interface could be replaced by interface default methods - Several modern language apply the technique in one form or another, so it's already proven to be valuable - There are

Re: [PHP-DEV] [RFC] [Vote] Path to Saner Increment/Decrement operators

2023-07-13 Thread Rowan Tommins
On 12 July 2023 15:12:24 BST, "G. P. B." wrote: > >The RFC was accepted unanimously, with 25 votes in favour. Fantastic news, George! Thanks for moving this forward after my aborted attempt, and fixing an inconsistency that's bugged me for years. Thanks for this and all your other work. -- Ro