Re: [PHP-DEV] Re: RFC [Discussion]: Randomizer Additions

2022-10-28 Thread Jordan LeDoux
On Fri, Oct 28, 2022 at 12:23 PM Joshua Rüsweg via internals < internals@lists.php.net> wrote: > Hi > > > You can find the RFC at: > > > > https://wiki.php.net/rfc/randomizer_additions > > Tim Düsterhus and I have updated the RFC and have broadly adopted the > proposals. > > Firstly we have rename

Re: [PHP-DEV] RFC [Discussion]: Randomizer Additions

2022-10-28 Thread Jordan LeDoux
On Fri, Oct 28, 2022 at 12:30 PM Joshua Rüsweg via internals < internals@lists.php.net> wrote: > Hello! > > [As Larry kindly pointed out to me, I only sent the email to Larry and > not to the mailing list.] > > > "Alphabet" here still, to me, implies a character set, not a byte > stream. Maybe ge

Re: [PHP-DEV] RFC [Discussion]: Randomizer Additions

2022-10-28 Thread Joshua Rüsweg via internals
Hello! [As Larry kindly pointed out to me, I only sent the email to Larry and not to the mailing list.] "Alphabet" here still, to me, implies a character set, not a byte stream. Maybe getBytesFromString? getBytesFromList? getBytesFrom() (because you're getting it "from" the string that's

[PHP-DEV] Re: RFC [Discussion]: Randomizer Additions

2022-10-28 Thread Joshua Rüsweg via internals
Hi You can find the RFC at: https://wiki.php.net/rfc/randomizer_additions Tim Düsterhus and I have updated the RFC and have broadly adopted the proposals. Firstly we have renamed the `getBytesFromAlphabet` to `getBytesFromString` as Larry Garfield suggested. Secondly, we have extended t

Re: [PHP-DEV] Proposal: Expanded iterable helper functions and aliasing iterator_to_array in `iterable\` namespace

2022-10-28 Thread Levi Morrison via internals
> > There's other functionality that I was less certain about proposing, such > > as `iterable\keys(iterable $iterable): array`, > > which would work similarly to array_keys but also work on Traversables > > (e.g. to be used with userland/internal collections, generators, etc.) > > I assume this

Re: [PHP-DEV] Proposal: Expanded iterable helper functions and aliasing iterator_to_array in `iterable\` namespace

2022-10-28 Thread Levi Morrison via internals
> Namespaces were chosen after feedback on my previous RFC, > and I believe `iterable\` follows the guidance from > https://wiki.php.net/rfc/namespaces_in_bundled_extensions and > https://wiki.php.net/rfc/namespaces_in_bundled_extensions#core_standard_spl I support this general direction :thumbsu

Re: [PHP-DEV] Adding the OpenSSF Scorecards GitHub Action

2022-10-28 Thread Tim Düsterhus
Hi as a heads up: Please do not top post (as per https://github.com/php/php-src/blob/master/docs/mailinglist-rules.md). Your previous replies were already correct. On 10/28/22 19:11, Pedro Nacht via internals wrote: And if there's interest, I'll happily fix that small inconsistency in the la

Re: [PHP-DEV] [VOTE] Improve unserialize() error handling

2022-10-28 Thread Tim Düsterhus
Hi On 10/28/22 18:25, Jeffrey Dafoe wrote: Informally, doesn't this mean that voters wanted a and c in PHP9? Not necessarily. It might be that a voter does not like the Exception wrapping at all (thus declining the proposal), but *if* it happens to be accepted then also increasing everything

Re: [PHP-DEV] Adding the OpenSSF Scorecards GitHub Action

2022-10-28 Thread Pedro Nacht via internals
Tim, Thank you for the feedback, I'll be sure to pass it on to the Scorecards team. And if there's interest, I'll happily fix that small inconsistency in the labeler.yml permissions. And with this I believe I'll go ahead and close the GH issue and PR. I'll stay in the mailing list for a few more

Re: RE: [PHP-DEV] [VOTE] Improve unserialize() error handling

2022-10-28 Thread Christoph M. Becker
On 28.10.2022 at 18:25, Jeffrey Dafoe wrote: >> a) "Add the \UnserializationFailedException and wrap any Throwables in PHP >> 8.x?" >> >> This proposal was declined with 20 (Yes) to 12 (No) Votes (62.5%). >> >> b) "Increase the severity of emitted E_NOTICE to E_WARNING in PHP 8.x?" >> >> This prop

RE: [PHP-DEV] [VOTE] Improve unserialize() error handling

2022-10-28 Thread Jeffrey Dafoe
> a) "Add the \UnserializationFailedException and wrap any Throwables in PHP > 8.x?" > > This proposal was declined with 20 (Yes) to 12 (No) Votes (62.5%). > > b) "Increase the severity of emitted E_NOTICE to E_WARNING in PHP 8.x?" > > This proposal was accepted with 33 (Yes) to 2 (No) Votes (94

Re: [PHP-DEV] Proposal: Expanded iterable helper functions and aliasing iterator_to_array in `iterable\` namespace

2022-10-28 Thread Tim Düsterhus
Hi On 10/28/22 15:45, tyson andre wrote: - `iterable\count(...)` (alias of iterator_count) - `iterable\to_array(Traversable $iterator, bool $preserve_keys = true): array` (alias of iterator_to_array, so that users can stop using a misleading name) I wonder if this should be made an alias or i

[PHP-DEV] PHP 8.1.12 Released

2022-10-28 Thread Ben Ramsey
The PHP development team announces the immediate availability of PHP 8.1.12. This is a security release. All PHP 8.1 users are encouraged to upgrade to this version. For source downloads of PHP 8.1.12 please visit our downloads page. Windows binaries can be found on the PHP for Windows site. The

Re: [PHP-DEV] [VOTE] Improve unserialize() error handling

2022-10-28 Thread Tim Düsterhus
Hi On 10/14/22 15:44, Tim Düsterhus wrote: Voting will run 2 weeks until: 2022-10-28 at 14:00 UTC Voting just closed. The RFC was partly accepted: a) "Add the \UnserializationFailedException and wrap any Throwables in PHP 8.x?" This proposal was declined with 20 (Yes) to 12 (No) Votes (6

[PHP-DEV] Proposal: Expanded iterable helper functions and aliasing iterator_to_array in `iterable\` namespace

2022-10-28 Thread tyson andre
Hi internals, https://wiki.php.net/rfc/iterator_xyz_accept_array recently passed in php 8.2, fixing a common inconvenience of those functions throwing a TypeError for arrays. However, from the `iterator_` name (https://www.php.net/manual/en/class.iterator.php), it's likely to become a source of

Re: [PHP-DEV] Microseconds to error log

2022-10-28 Thread tyson andre
Hi Mikhail, > >Basically, we have quite a high-loaded environment and we really want > >to see timestamps containing milli-/microseconds in our logs. > > I'm not knowledgeable enough to comment on the implementation details, but > from a user point of view I agree the feature would be useful. It

[PHP-DEV] PHP 8.0.25 Released

2022-10-28 Thread Gabriel Caruso
The PHP development team announces the immediate availability of PHP 8.0.25. This is a security fix release. All PHP 8.0 users are encouraged to upgrade to this version. For source downloads of PHP 8.0.25 please visit our downloads page. Windows binaries can be found on the PHP for Windows site.

Re: [PHP-DEV] Microseconds to error log

2022-10-28 Thread Mikhail Galanin via internals
Hello everyone, I tried following Derrek's approach (to introduce a new function). A couple of considerations: We used to have some pain when this format changed last time (I can't remember details, unfortunately) but I don't feel like making an option to provide backward compatibility is a good