Larry,
> On Oct 17, 2022, at 6:01 PM, Larry Garfield wrote:
>
> On Mon, Oct 17, 2022, at 12:33 PM, Tim Düsterhus wrote:
>
Okay, now the Exception message changed. Personally I do not consider
this a BC break: I believe Exception messages are meant for human
consumption, not for p
I'm going to vote against exception wrapping.
If I'm reading the implementation correctly, the original exception is
thrown away, there's no way to get the original message and backtrace.
That will make debugging more difficult.
I reviewed about 150 callers of unserialize() in the MediaWiki c
On Mon, Oct 17, 2022, at 12:33 PM, Tim Düsterhus wrote:
>>> Okay, now the Exception message changed. Personally I do not consider
>>> this a BC break: I believe Exception messages are meant for human
>>> consumption, not for programs. Otherwise fixing a typo in the message
>>> would be a BC break.
Sorry for double send Nicolas, I hit reply instead of reply-all on my first
message. :)
On Mon, Oct 17, 2022 at 1:57 AM Nicolas Grekas
wrote:
>
> Yes, the specific error message should be part of the BC promise. This
> allows building test suites that can assert the message in a stable way.
> Th
Hi
On 10/17/22 10:57, Nicolas Grekas wrote:
Thanks for taking the time to have a closer look. Unfortunately, you picked
the one failing test where there could be a discussion about whether the
original code needs improvement or not.
I disagree. The other locations are equally broken with curre
On Mon, 17 Oct 2022 at 09:57, Nicolas Grekas
wrote:
> I created this patch/PR to show the changes that would be required on
> Symfony to work around the BC break:
> https://github.com/symfony/symfony/pull/47882
>
> Note to readers: in this whole discussion, Symfony is just an example of
> affecte
Hi Tim,
Thanks for taking the time to have a closer look. Unfortunately, you picked
the one failing test where there could be a discussion about whether the
original code needs improvement or not.
The other failing tests involve "unserialize_callback_func" to gracefully
detect class-not-found, an
