Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling

2022-09-08 Thread Tim Düsterhus
Hi On 9/8/22 19:06, Nicolas Grekas wrote: From what I understand, there are two things in the RFC: 1. a proposal to wrap any throwables thrown during unserialization inside an UnserializationFailedException Correct. 2. a discussion to figure out a way to turn these notices+warn

Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling

2022-09-08 Thread Nicolas Grekas
Hi Tim, Thanks for the RFC. I've now written up an RFC as a follow-up for the "What type of > Exception to use for unserialize() failure?" thread [1]: > > > > RFC: Improve unserialize() error handling > https://wiki.php.net/rfc/improve_unserialize_error_handling > > Proof of concept implemen

Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling

2022-09-08 Thread Larry Garfield
On Thu, Sep 8, 2022, at 11:18 AM, Tim Düsterhus wrote: > Hi > > On 9/7/22 23:44, Larry Garfield wrote: >> Either I guess? Honestly we should decide that in advance on the list. :-) >> E_WARNING+Exception in 9 is what I'd probably favor, with "Exception now" as >> a second choice. >> > > I'm a

Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling

2022-09-08 Thread Tim Düsterhus
Hi On 9/7/22 23:44, Larry Garfield wrote: Either I guess? Honestly we should decide that in advance on the list. :-) E_WARNING+Exception in 9 is what I'd probably favor, with "Exception now" as a second choice. I'm a new-ish contributor here in internals, so I don't know how things were

Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte

2022-09-08 Thread Christoph M. Becker
On 08.09.2022 at 13:01, Andreas Heigl wrote: > On 08.09.22 12:35, Jakub Zelenka wrote: > >> On Wed, Sep 7, 2022 at 3:28 PM Christoph M. Becker >> wrote: >> >>> On 07.09.2022 at 15:57, Misha wrote: >>> We spend a lot of time to increase limits for uploads file in PHP. Can we increas

Re: [PHP-DEV] Increase maximum size of an uploaded file to 50Mbyte

2022-09-08 Thread Kamil Tekiela
I have it set to 32MB and nobody has complained yet. I think it might be a sweet spot between security and usability out of the box.

Re: [PHP-DEV] Increase maximum size of an uploaded file to 50Mbyte

2022-09-08 Thread Jakub Zelenka
On Wed, Sep 7, 2022 at 2:58 PM Misha wrote: > Hello everyone, > > We spend a lot of time to increase limits for uploads file in PHP. Can we > increase it in php.ini? > > Current value is 2Mb. Its so small value, when photo image can take 8Mb on > iPhone X. > We should increase it to 50Mb, because

Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte

2022-09-08 Thread Andreas Heigl
Hey all. On 08.09.22 12:35, Jakub Zelenka wrote: On Wed, Sep 7, 2022 at 3:28 PM Christoph M. Becker wrote: On 07.09.2022 at 15:57, Misha wrote: We spend a lot of time to increase limits for uploads file in PHP. Can we increase it in php.ini? Current value is 2Mb. Its so small value, when p

Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte

2022-09-08 Thread Jakub Zelenka
On Wed, Sep 7, 2022 at 3:28 PM Christoph M. Becker wrote: > On 07.09.2022 at 15:57, Misha wrote: > > > We spend a lot of time to increase limits for uploads file in PHP. Can we > > increase it in php.ini? > > > > Current value is 2Mb. Its so small value, when photo image can take 8Mb > on > > iPh