Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling

2022-09-05 Thread Larry Garfield
On Mon, Sep 5, 2022, at 12:20 PM, Tim Düsterhus wrote: > Hi > > I've now written up an RFC as a follow-up for the "What type of > Exception to use for unserialize() failure?" thread [1]: > > > > RFC: Improve unserialize() error handling > https://wiki.php.net/rfc/improve_unserialize_error_han

[PHP-DEV] RFC [Discussion]: Improve unserialize() error handling

2022-09-05 Thread Tim Düsterhus
Hi I've now written up an RFC as a follow-up for the "What type of Exception to use for unserialize() failure?" thread [1]: RFC: Improve unserialize() error handling https://wiki.php.net/rfc/improve_unserialize_error_handling Proof of concept implementation is in: https://github.com/ph

Re: [PHP-DEV] Re: Issues with readonly classes

2022-09-05 Thread Larry Garfield
On Mon, Sep 5, 2022, at 4:01 AM, Máté Kocsis wrote: > Regarding your main question: I understand your problem with readonly > classes, and I'd be happy if we found a solution which fits your use-cases > and keeps consistency for the engine at the same time. To give you more > context about the inh

[PHP-DEV] Re: Issues with readonly classes

2022-09-05 Thread Nicolas Grekas
Hi Mate For 2.: static properties are useful e.g. to cache some shared state (info >> extracted from reflection in my case) and I really don't see why readonly >> classes should forbid static properties. Readonly is only useful for >> instances, because it gives them immutability, but what's the l

[PHP-DEV] Re: Issues with readonly classes

2022-09-05 Thread Máté Kocsis
Hi Nicolas, For 2.: static properties are useful e.g. to cache some shared state (info > extracted from reflection in my case) and I really don't see why readonly > classes should forbid static properties. Readonly is only useful for > instances, because it gives them immutability, but what's the

Re: [PHP-DEV] Issues with readonly classes

2022-09-05 Thread Robert Landers
On Mon, Sep 5, 2022 at 9:57 AM Nicolas Grekas wrote: > > >Hi Marco, > > > > > >IMO good as-is: can be relaxed later (8.3 or later), if anybody believes > > >> it's a show-stopper. > > >> > > >Readonly classes don't really need to be lazy. > > >> > > > > > >"Break things and move slow" doesn't feel

Re: [PHP-DEV] Issues with readonly classes

2022-09-05 Thread Nicolas Grekas
>Hi Marco, > > > >IMO good as-is: can be relaxed later (8.3 or later), if anybody believes > >> it's a show-stopper. > >> > >Readonly classes don't really need to be lazy. > >> > > > >"Break things and move slow" doesn't feel right to me for the language. > > It's a new keyword that you have to opt