Re: [PHP-DEV] [RFC][Under discussion] Fetch properties in const expressions

2022-06-16 Thread Ilija Tovilo
Hi Alexandru, hi Shinji > Hey, sorry to bump here on this topic. > > My assumption was that the use of `->` in initializers would bear the same > limitations as using `new`. > That would mean it would not be supported for > - class constant initializers > - instance property initializers > - stat

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Pierrick Charron
Thanks for taking the time to answer and give feedback, that's really appreciated. Firstly, about the procedural API, if everyone agrees that we should not create it (and it looks like it) I will definitely not go against it. This was just to make it consistent with the current ext/curl api. Readi

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Larry Garfield
On Thu, Jun 16, 2022, at 2:10 AM, Pierrick Charron wrote: > Hi internals, > > Since its version 6.62.0 [1], libcurl features a brand new URL API [2] that > can be used to parse and generate URLs, using libcurl’s own parser. One of > the goals of this API is to tighten a problematic vulnerable area

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Jeffrey Chimene
On 6/16/22 07:26, Robert Landers wrote: On Thu, Jun 16, 2022 at 3:07 PM Kamil Tekiela wrote: First of all, thank you for working on this. I wanted OO API for Curl for a long time. Exceptions all the way. Code that's not using exceptions is usually more clunky and error-prone. The new OO API sh

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Robert Landers
On Thu, Jun 16, 2022 at 3:07 PM Kamil Tekiela wrote: > > First of all, thank you for working on this. I wanted OO API for Curl for a > long time. > > Exceptions all the way. Code that's not using exceptions is usually more > clunky and error-prone. The new OO API shouldn't have the possibility to

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-16 Thread Tim Düsterhus
Hi On 6/16/22 14:52, Tim Düsterhus wrote: (3) Naming of PCG64: I must admit that the fact that PCG is a full family of similar, but not identical generators is one thing that made me (and still makes me) prefer the xoshiro family which has clearer names for its variants. It was also pretty har

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Kamil Tekiela
First of all, thank you for working on this. I wanted OO API for Curl for a long time. Exceptions all the way. Code that's not using exceptions is usually more clunky and error-prone. The new OO API shouldn't have the possibility to return null/false on error. This is considered a thing of the pas

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Tim Düsterhus
Hi On 6/16/22 09:10, Pierrick Charron wrote: As of right now I still have some unanswered questions like how should we handle errors on the new CurlUrl API ? - Throw `CurlUrlException` on both the procedural and object oriented style API (that's how current implementation works [5]) - Throw `Cur

Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-16 Thread Tim Düsterhus
Hi On 6/16/22 12:14, Go Kudo wrote: If the content is acceptable, we would like to change the status of the RFC to Under Discussion and make an announcement thread to internals ML. Can anyone review the content? (1) Engines should be final: That was my suggestion and that paragraph looks goo

[PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x

2022-06-16 Thread Go Kudo
2022年6月14日(火) 9:01 Go Kudo : > Hello internals. > > Voting began on 2022-06-14 00:00:00 (UTC) and will end on 2022-06-28 > 00:00:00 (UTC). > > https://wiki.php.net/rfc/rng_extension > > The implementation is not yet complete and has some issues. > See TODO in Pull Request for details. > > https://

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Mel Dafert
On 16 June 2022 09:10:08 CEST, Pierrick Charron wrote: > [...] >- For consistency expose the new Curl URL API as functions mapped one to >one to libcurl functions : > >function curl_url(?string $url = null): CurlUrl|false {} >function curl_url_set(CurlUrl $url, int $part, string $content, int $fla

Re: [PHP-DEV] [RFC] [VOTE] Random Extension 5.x

2022-06-16 Thread Go Kudo
2022年6月16日(木) 2:23 Tim Düsterhus : > Hi > > On 6/14/22 02:01, Go Kudo wrote: > > Voting began on 2022-06-14 00:00:00 (UTC) and will end on 2022-06-28 > > 00:00:00 (UTC). > > > > https://wiki.php.net/rfc/rng_extension > > > > The implementation is not yet complete and has some issues. > > See TODO

Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Deleu
On Thu, Jun 16, 2022, 9:10 AM Pierrick Charron wrote: > Hi internals, > > Since its version 6.62.0 [1], libcurl features a brand new URL API [2] that > can be used to parse and generate URLs, using libcurl’s own parser. One of > the goals of this API is to tighten a problematic vulnerable area fo

[PHP-DEV] Discussion about new Curl URL API and ext/curl improvements

2022-06-16 Thread Pierrick Charron
Hi internals, Since its version 6.62.0 [1], libcurl features a brand new URL API [2] that can be used to parse and generate URLs, using libcurl’s own parser. One of the goals of this API is to tighten a problematic vulnerable area for applications where the URL parser library would believe one thi