[PHP-DEV] Re: [RFC] Deprecate and Remove utf8_encode and utf8_decode

2022-03-24 Thread Björn Larsson via internals
Den 2022-03-24 kl. 19:48, skrev Rowan Tommins: On 24/03/2022 15:51, Björn Larsson wrote: Well, the usecase I can provide is that we have a site with content in ISO9959-1 (Latin 1). Thanks for the data point. Out of curiosity, what language is the site in, and where are you based? It's in

Re: [PHP-DEV] Typed constants revisited

2022-03-24 Thread Mark Niebergall
On Thu, Mar 24, 2022 at 1:00 PM Rowan Tommins wrote: > On 23/03/2022 18:54, Mark Niebergall wrote: > > The next phase of work with different RFC would take > > this further with const inheritance, where const type must match. > > > I'm not sure it makes much sense to split this into two RFCs, and

Re: [PHP-DEV] Typed constants revisited

2022-03-24 Thread Rowan Tommins
On 23/03/2022 18:54, Mark Niebergall wrote: The next phase of work with different RFC would take this further with const inheritance, where const type must match. I'm not sure it makes much sense to split this into two RFCs, and as far as I can see, the previous RFC included both features:

Re: [PHP-DEV] Typed constants revisited

2022-03-24 Thread Sara Golemon
On Thu, Mar 24, 2022 at 10:20 AM Pierre wrote: > > That was exactly my point: the type could simply implicitely be the one > of the original value. > > That works when the initial value is a literal, but what about when it's another cost? class Foo { const BAR = Baz::BAR; const BLING = MY_QU

[PHP-DEV] Re: [RFC] Deprecate and Remove utf8_encode and utf8_decode

2022-03-24 Thread Rowan Tommins
On 24/03/2022 15:51, Björn Larsson wrote: Well, the usecase I can provide is that we have a site with content in ISO9959-1 (Latin 1). Thanks for the data point. Out of curiosity, what language is the site in, and where are you based? One of the things missing from Latin-1 is the Euro symbol

Re: [PHP-DEV] Typed constants revisited

2022-03-24 Thread Larry Garfield
On Thu, Mar 24, 2022, at 11:34 AM, Mark Niebergall wrote: > Pierre, > > On Thu, Mar 24, 2022 at 9:20 AM Pierre wrote: > >> Le 24/03/2022 à 16:06, Mark Niebergall a écrit : >> > So you are correct, the const value does have a value that has a type, >> but >> > there is no way to enforce which type

Re: [PHP-DEV] Typed constants revisited

2022-03-24 Thread Mark Niebergall
Pierre, On Thu, Mar 24, 2022 at 9:20 AM Pierre wrote: > Le 24/03/2022 à 16:06, Mark Niebergall a écrit : > > So you are correct, the const value does have a value that has a type, > but > > there is no way to enforce which type the value is or to use const with > > inheritance, which is part of

[PHP-DEV] Re: [RFC] Deprecate and Remove utf8_encode and utf8_decode

2022-03-24 Thread Björn Larsson via internals
Den 2022-03-23 kl. 14:46, skrev Rowan Tommins: On 20/02/2022 18:55, Rowan Tommins wrote: I would like to open discussion on an RFC to deprecate and later remove the functions utf8_encode() and utf8_decode() https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encode Final chance for feedb

Re: [PHP-DEV] Typed constants revisited

2022-03-24 Thread Pierre
Le 24/03/2022 à 16:06, Mark Niebergall a écrit : So you are correct, the const value does have a value that has a type, but there is no way to enforce which type the value is or to use const with inheritance, which is part of the bigger picture here. That was exactly my point: the type could si

Re: [PHP-DEV] Typed constants revisited

2022-03-24 Thread Mark Niebergall
Pierre, On Thu, Mar 24, 2022 at 1:04 AM Pierre wrote: > Le 23/03/2022 à 23:10, Larry Garfield a écrit : > > Is there a benefit to it other than "well everything else has types now, > so..."? Even if it's esoteric, like in reflection-based meta programming? > (I've been dabbling too much in that

Re: [PHP-DEV] [RFC] Deprecate and Remove utf8_encode and utf8_decode

2022-03-24 Thread Rowan Tommins
On 24/03/2022 09:52, Christian Schneider wrote: If these functions were proposed today, under better names but the same feature set, I don't think mbstring being optional would be accepted as reasoning for adding them to core. So the only reason to keep them is if they're widely (and successfu

Re: [PHP-DEV] [RFC] Deprecate and Remove utf8_encode and utf8_decode

2022-03-24 Thread Christian Schneider
Am 24.03.2022 um 10:32 schrieb Rowan Tommins : > On 23/03/2022 23:39, Juliette Reinders Folmer wrote: >> >> While I agree the functions are often used incorrectly, what worries me >> about this RFC is that the only viable alternatives for these functions are >> in two optional extensions, which

[PHP-DEV] Re: [RFC] Deprecate and Remove utf8_encode and utf8_decode

2022-03-24 Thread Rowan Tommins
On 23/03/2022 23:39, Juliette Reinders Folmer wrote: While I agree the functions are often used incorrectly, what worries me about this RFC is that the only viable alternatives for these functions are in two optional extensions, which in practice will mean lots of projects will need to start

Re: [PHP-DEV] Typed constants revisited

2022-03-24 Thread Pierre
Le 23/03/2022 à 23:10, Larry Garfield a écrit : Is there a benefit to it other than "well everything else has types now, so..."? Even if it's esoteric, like in reflection-based meta programming? (I've been dabbling too much in that lately. :-) ) "Everything else does" isn't a compelling argu