Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension 4.0

2022-02-16 Thread Go Kudo
2022年2月16日(水) 21:25 Tim Düsterhus : > Hi > > On 2/16/22 12:39, Go Kudo wrote: > >> Is the nextByteSize() method actually required? PHP strings already > know > > their own length. > > > > This is a convenience of the current implementation. > > You already said that you will think of some good i

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension 4.0

2022-02-16 Thread Tim Düsterhus
Hi On 2/16/22 12:39, Go Kudo wrote: Is the nextByteSize() method actually required? PHP strings already know their own length. This is a convenience of the current implementation. You already said that you will think of some good ideas, but I'd like to be clear that the convenience of the

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension 4.0

2022-02-16 Thread Go Kudo
2022年2月16日(水) 20:24 Tim Düsterhus : > Hi > > On 2/16/22 12:04, Go Kudo wrote: > > Thanks for the good idea. I changed the NumberGenerator to Engine and > > changed generate() to return a string as suggested. > > Thanks, I've already seen the updated PR and played around with it. This > feels much

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension 4.0

2022-02-16 Thread Tim Düsterhus
Hi On 2/16/22 12:04, Go Kudo wrote: Thanks for the good idea. I changed the NumberGenerator to Engine and changed generate() to return a string as suggested. Thanks, I've already seen the updated PR and played around with it. This feels much better now. As a test I implemented xoshiro128++

Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension 4.0

2022-02-16 Thread Go Kudo
2022年2月15日(火) 22:09 Tim Düsterhus : > Hi > > On 2/15/22 12:48, Go Kudo wrote: > > At first, I updated the RFC to the latest status. > > > > https://wiki.php.net/rfc/rng_extension > > Thank you, the examples are useful. > > > I need some time to think about the current issue. I understand its > > u