Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Christoph M. Becker
On 12.11.2021 at 23:34, Matthew Weier O'Phinney wrote: > On Fri, Nov 12, 2021, 3:41 PM Larry Garfield wrote: > >> The original version of the RFC would have (as of v9) allowed for the >> removal of some fugly code in property handling, resulting in engine >> improvements and some minor performanc

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Matthew Weier O'Phinney
On Fri, Nov 12, 2021, 3:41 PM Larry Garfield wrote: > On Fri, Nov 12, 2021, at 12:59 PM, Matthew Weier O'Phinney wrote: > > I recognize it's a bit late to be commenting, now that voting has > > started... but this feels like a solution for which we already have > > workable solutions, and which w

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Larry Garfield
On Fri, Nov 12, 2021, at 12:59 PM, Matthew Weier O'Phinney wrote: > I recognize it's a bit late to be commenting, now that voting has > started... but this feels like a solution for which we already have > workable solutions, and which will instead lead to a lot of > misunderstanding and breakage i

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Matthew Weier O'Phinney
I recognize it's a bit late to be commenting, now that voting has started... but this feels like a solution for which we already have workable solutions, and which will instead lead to a lot of misunderstanding and breakage in the user ecosystem. Our IDEs, coding standards, and static analysis too

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Deleu
On Fri, Nov 12, 2021 at 6:47 PM Chase Peeler wrote: > On Fri, Nov 12, 2021 at 12:44 PM Larry Garfield > wrote: > > > On Fri, Nov 12, 2021, at 10:56 AM, Nikita Popov wrote: > > > On Fri, Nov 12, 2021 at 5:34 PM Nikita Popov > > wrote: > > > > > >> On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrot

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Chase Peeler
On Fri, Nov 12, 2021 at 12:44 PM Larry Garfield wrote: > On Fri, Nov 12, 2021, at 10:56 AM, Nikita Popov wrote: > > On Fri, Nov 12, 2021 at 5:34 PM Nikita Popov > wrote: > > > >> On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrote: > >> > >>> > On Nov 12, 2021, at 10:10, Derick Rethans wrote: > >

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Larry Garfield
On Fri, Nov 12, 2021, at 10:56 AM, Nikita Popov wrote: > On Fri, Nov 12, 2021 at 5:34 PM Nikita Popov wrote: > >> On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrote: >> >>> > On Nov 12, 2021, at 10:10, Derick Rethans wrote: >>> > >>> > On 12 November 2021 13:07:42 GMT, Nikita Popov >>> wrote: >>>

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Nikita Popov
On Fri, Nov 12, 2021 at 5:34 PM Nikita Popov wrote: > On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrote: > >> > On Nov 12, 2021, at 10:10, Derick Rethans wrote: >> > >> > On 12 November 2021 13:07:42 GMT, Nikita Popov >> wrote: >> >> Hi internals, >> >> >> >> I've opened the vote on >> >> https

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Christoph M. Becker
On 12.11.2021 at 17:24, Ben Ramsey wrote: >> On Nov 12, 2021, at 10:10, Derick Rethans wrote: >> >> On 12 November 2021 13:07:42 GMT, Nikita Popov wrote: >>> Hi internals, >>> >>> I've opened the vote on >>> https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close >>> 2021-11-26.

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Nikita Popov
On Fri, Nov 12, 2021 at 5:25 PM Ben Ramsey wrote: > > On Nov 12, 2021, at 10:10, Derick Rethans wrote: > > > > On 12 November 2021 13:07:42 GMT, Nikita Popov > wrote: > >> Hi internals, > >> > >> I've opened the vote on > >> https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will > c

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Ben Ramsey
> On Nov 12, 2021, at 10:10, Derick Rethans wrote: > > On 12 November 2021 13:07:42 GMT, Nikita Popov wrote: >> Hi internals, >> >> I've opened the vote on >> https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close >> 2021-11-26. > > I've voted no on this one. Not because I do

Re: [PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Derick Rethans
On 12 November 2021 13:07:42 GMT, Nikita Popov wrote: >Hi internals, > >I've opened the vote on >https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close >2021-11-26. I've voted no on this one. Not because I don't like the idea, but because I think the timeline for deprecation an

[PHP-DEV] [VOTE] Deprecate dynamic properties

2021-11-12 Thread Nikita Popov
Hi internals, I've opened the vote on https://wiki.php.net/rfc/deprecate_dynamic_properties. Voting will close 2021-11-26. Regards, Nikita

Re: [PHP-DEV] Automatic implementation of Stringable may conflict with old, untyped arginfo declarations

2021-11-12 Thread Nikita Popov
On Wed, Nov 10, 2021 at 10:13 PM Jeremy Mikola wrote: > > > On Tue, Nov 9, 2021 at 4:30 AM Nikita Popov wrote: > >> >> In >> https://github.com/php/php-src/commit/a551b083073ea08f8fc53b0e1a6380b6de26cc6b >> I've added a hack to add the string return type if it is missing and thus >> make the sig

[PHP-DEV] Automatic performance benchmarking: PHP 8.1 is ~30% faster than PHP 7.4

2021-11-12 Thread Máté Kocsis
Hello Internals, I'm writing this email because lately, I've been working on an automatic benchmarking framework for PHP, and I'd like to share some news regarding it. The initial implementation was sponsored by Craig Francis, and it was used for the evaluation of the performance aspects of the is