Re: [PHP-DEV] VM kinds

2021-11-10 Thread Tim Starling
OK, thanks for the answer. My PR is up now, with a fixme comment for the GOTO and SWITCH VMs. I'm still not sure how to make them work. https://github.com/php/php-src/pull/7642 -- Tim Starling On 10/11/21 8:10 pm, Dmitry Stogov wrote: > I prefer to keep GOTO and SWITCH VMs. It's easy to drop so

Re: [PHP-DEV] Automatic implementation of Stringable may conflict with old, untyped arginfo declarations

2021-11-10 Thread Jeremy Mikola
On Tue, Nov 9, 2021 at 4:30 AM Nikita Popov wrote: > > In > https://github.com/php/php-src/commit/a551b083073ea08f8fc53b0e1a6380b6de26cc6b > I've added a hack to add the string return type if it is missing and thus > make the signature compatible with the interface. That should address the > imme

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-10 Thread Niklas Keller
Hey Nikita, I'd like to propose using HackerOne instead of bugs.php.net for security issues: https://www.hackerone.com/company/open-source-community Best, Niklas Am Di., 2. Nov. 2021 um 15:19 Uhr schrieb Nikita Popov : > Hi internals, > > The migration from bugs.php.net to GitHub issues has alr

Re: [PHP-DEV] [RFC] Migrating to GitHub issues

2021-11-10 Thread Nikita Popov
On Thu, Nov 4, 2021 at 5:58 PM Dan Ackroyd wrote: > On Tue, 2 Nov 2021 at 14:19, Nikita Popov wrote: > > > > I'd like to formally propose to use GitHub for PHP implementation issues > as > > well: https://wiki.php.net/rfc/github_issues > > In general, yes please. The only bit I'll chime in on is

[PHP-DEV] Re: [RFC] Deprecate dynamic properties

2021-11-10 Thread Nikita Popov
On Wed, Aug 25, 2021 at 12:02 PM Nikita Popov wrote: > Hi internals, > > I'd like to propose the deprecation of "dynamic properties", that is > properties that have not been declared in the class (stdClass and > __get/__set excluded, of course): > > https://wiki.php.net/rfc/deprecate_dynamic_prop

Re: [PHP-DEV] VM kinds

2021-11-10 Thread Dmitry Stogov
I prefer to keep GOTO and SWITCH VMs. It's easy to drop something, but it's going to be much more complex to reimplement it again. Note that HYBRID VM (based on CALL and GOTO VMs) was introduced only in PHP-7.2, because GOTO was already implemented a long time ago. In the future, it's possible to

[PHP-DEV] Re: Unwrap reference after foreach

2021-11-10 Thread Nikita Popov
On Fri, Aug 13, 2021 at 3:28 PM Nikita Popov wrote: > Hi internals, > > I'd like to address a common footgun when using foreach by reference: > https://wiki.php.net/rfc/foreach_unwrap_ref > > This addresses the issue described in the big red box at > https://www.php.net/manual/en/control-structur

Re: [PHP-DEV] VM kinds

2021-11-10 Thread Nikita Popov
On Wed, Nov 10, 2021 at 8:13 AM Tim Starling wrote: > What are VM kinds for? Are they just a prototyping tool to allow > different implementation strategies to be benchmarked? Or are they > permanent? Does anyone use them? > > I ask because I'm working on a VM bug, and non-default VM kinds make >