Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Hi. I read the requirements to ask for a feature. I have been following your list. Interesting. I just want to do this https://web.dev/fetch-upload-streaming/, https://glitch.com/edit/#!/fetch-request-stream. This works as expected with a Blob or File: fetch('index.php', { headers: { 'Conten

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Hi, On Thu, Aug 26, 2021, 1:09 AM Derick Rethans wrote: > On 25 August 2021 18:34:18 BST, Nicolas Grekas < > nicolas.grekas+...@gmail.com> wrote: > >Le mer. 25 août 2021 à 19:32, Marco Pivetta a écrit > : > , > > > >> On Wed, Aug 25, 2021 at 7:30 PM Nicolas Grekas < > >> nicolas.grekas+...@gmai

[PHP-DEV] Redirect git.php.net/repository/php-src to github.com/php/php-src

Hi everyone, I was reading and found references to clone repo using git.php.net, i opened a PR to fix it, but my questions is: is possible redirect clones from to ? I think has a

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

> On Aug 25, 2021, at 6:41 PM, Reindl Harald (privat) wrote: > Am 26.08.21 um 00:37 schrieb Mike Schinkel: >> That said, I'd be really interested in seeing use-cases where having dynamic >> properties is essential to an architecture and where it could not be easily >> refactored. I cannot envis

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

Hi. A chunk in the RFC: abstract class Constraint { public $groups; public function __construct() { unset($this->groups); } public function __get($name) { // Will get called on first access, but once initialized. $this->gro

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

> On Aug 25, 2021, at 10:04 AM, Chase Peeler wrote: > > On Wed, Aug 25, 2021 at 9:51 AM Rowan Tommins > wrote: > >> On 25/08/2021 13:45, Nikita Popov wrote: >> >>> We obviously need to keep support for dynamic properties on stdClass, >>> and if we do so, I would expect that to apply to subclas

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 3:03 AM Nikita Popov wrote: > > Hi internals, > > I'd like to propose the deprecation of "dynamic properties", that is > properties that have not been declared in the class (stdClass and > __get/__set excluded, of course): > > https://wiki.php.net/rfc/deprecate_dynamic_prop

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 2:02 PM Ben Ramsey wrote: > I'd feel better about this if we had that citation. In modern code, I > agree they are probably rare, but I think there's a lot of legacy code > that makes heavy use of dynamic properties as an important feature of > PHP. (I'm working on one suc

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

Sara Golemon wrote on 8/25/21 10:28: > My gut-check says an Attribute works well enough. This will unlock the > class (disable deprecation warning) in 8.2+ and be ignored in earlier > releases (8.0 and 8.1 would need an auto-loaded polyfill userspace > attribute obviously, but that's a tractable p

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

Chase Peeler wrote on 8/25/21 09:04: > Please don't do this. Call it bad coding practices or not, but this was > something I've considered a feature of PHP and have actually built things > around it. It's not something that can be easily refactored since it was > part of the design. Since the stdC

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

On Wed, Aug 25, 2021 at 10:25 PM Ben Ramsey wrote: > Deleu wrote on 8/24/21 13:53: > > The proposal is rooted in making it easier for release managers and rfc > > authors to refine code changes that may or may not be necessary to > > accomplish a previously approved RFC. > > I don't understand ho

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Deleu wrote on 8/24/21 13:53: > The proposal is rooted in making it easier for release managers and rfc > authors to refine code changes that may or may not be necessary to > accomplish a previously approved RFC. I don't understand how this proposal helps with this. If changes are necessary to acc

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Nicolas Grekas wrote on 8/25/21 12:29: > I would welcome a new RFC to clarify what is allowed during the feature > freeze. As Derick mentioned in another post (by essentially quoting the Wikipedia entry for "Feature freeze"), this period is a well-understood phase of software development. We use

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Deleu wrote on 8/25/21 14:35: > On Wed, Aug 25, 2021 at 8:52 PM Ben Ramsey wrote: >> I would be in favor of an "informational" RFC rather than a "policy" >> RFC. An informational RFC can define terms, such as "refinement RFC" and >> "feature freeze," without burdening the project with more policy

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

On Wed, Aug 25, 2021 at 9:00 PM Ben Ramsey wrote: > Derick Rethans wrote on 8/24/21 12:35: > > On Mon, 23 Aug 2021, Deleu wrote: > > > >> In order to not be empty-handed, I started a gist that can be seen as > >> the starting point for this discussion, available at > >> https://gist.github.com/de

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Derick Rethans wrote on 8/24/21 12:35: > On Mon, 23 Aug 2021, Deleu wrote: > >> In order to not be empty-handed, I started a gist that can be seen as >> the starting point for this discussion, available at >> https://gist.github.com/deleugpn/9d0e285f13f0b4fdcfc1d650b20c3105. > > 4. A Refinement

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Sara Golemon wrote on 8/24/21 14:29: > Agreed, and I would say that we DO have a policy. The policy is that the > RMs make a judgement call in the moment. I still think the attributes > syntax was appropriate to make an exception for (given it was a new feature > and this would be our last chance

[PHP-DEV] PHP-8.1 branch and RC1 in 6 days

Hi, internals folks! PHP 8.1 will have its first release candidate next week, which also means we will create a dedicated Git branch and the bugfix workflow will change. As with previous releases, we will tag RC1 on Tuesday (31 Aug) prior to its official release on Thursday (2 Sep). We will also

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

On 25 August 2021 17:58:55 BST, Nicolas Grekas wrote: >Le mar. 24 août 2021 à 21:09, Derick Rethans a écrit : > >> On 24 August 2021 19:53:57 BST, Deleu wrote: >> >On Tue, Aug 24, 2021, 19:28 Derick Rethans wrote: >> > >> >> On Mon, 23 Aug 2021, Deleu wrote: >> >> >> >> > We recently had the N

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

On 25 August 2021 18:34:18 BST, Nicolas Grekas wrote: >Le mer. 25 août 2021 à 19:32, Marco Pivetta a écrit : , > >> On Wed, Aug 25, 2021 at 7:30 PM Nicolas Grekas < >> nicolas.grekas+...@gmail.com> wrote: >> >>> I would welcome a new RFC to clarify what is allowed during the feature >>> freeze.

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Le mer. 25 août 2021 à 19:32, Marco Pivetta a écrit : > Hey Nicolas, > > > On Wed, Aug 25, 2021 at 7:30 PM Nicolas Grekas < > nicolas.grekas+...@gmail.com> wrote: > >> I would welcome a new RFC to clarify what is allowed during the feature >> freeze. >> > > See https://en.wikipedia.org/wiki/Freez

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Hey Nicolas, On Wed, Aug 25, 2021 at 7:30 PM Nicolas Grekas wrote: > I would welcome a new RFC to clarify what is allowed during the feature > freeze. > See https://en.wikipedia.org/wiki/Freeze_(software_engineering) Greets, Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Le mar. 24 août 2021 à 08:09, Pierre Joye a écrit : > Hi Marco, > > On Tue, Aug 24, 2021 at 3:49 AM Deleu wrote: > > > > Hello everyone! > > > > We recently had the Nullable Intersection Types RFC process in an > > unconventional way starting a new RFC post feature freeze. If memory > serves > >

Re: [PHP-DEV] Guidelines for RFC post feature-freeze

Le mar. 24 août 2021 à 21:09, Derick Rethans a écrit : > On 24 August 2021 19:53:57 BST, Deleu wrote: > >On Tue, Aug 24, 2021, 19:28 Derick Rethans wrote: > > > >> On Mon, 23 Aug 2021, Deleu wrote: > >> > >> > We recently had the Nullable Intersection Types RFC process in an > >> > unconvention

Re: [PHP-DEV] [VOTE] Nullable intersection types

Le lun. 23 août 2021 à 16:22, Larry Garfield a écrit : > On Sun, Aug 22, 2021, at 5:42 PM, Patrick ALLAERT wrote: > > > Either extra time, or having a way to influence the schedule of the > > releases. > > For now, we work with a fixed schedule and don't know (at least: me) how > > strict we must

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021, at 10:28 AM, Sara Golemon wrote: > On Wed, Aug 25, 2021 at 5:03 AM Nikita Popov wrote: > > I'd like to propose the deprecation of "dynamic properties", that is > > properties that have not been declared in the class (stdClass and > > __get/__set excluded, of course): > > > >

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 5:03 AM Nikita Popov wrote: > I'd like to propose the deprecation of "dynamic properties", that is > properties that have not been declared in the class (stdClass and > __get/__set excluded, of course): > > https://wiki.php.net/rfc/deprecate_dynamic_properties > > This RFC

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On 25/08/2021 15:00, Nikita Popov wrote: I'm not sure it will have a big impact for this use-case though, because using the new name would require polyfilling it, so I'd expect people would stick to the old name in the foreseeable future... Not necessarily - it depends what versions you need

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 4:26 PM tyson andre wrote: > Hi Nikita Popov, > > > I'd like to propose the deprecation of "dynamic properties", that is > > properties that have not been declared in the class (stdClass and > > __get/__set excluded, of course): > > > > https://wiki.php.net/rfc/deprecate_d

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

Hi Nikita Popov, > I'd like to propose the deprecation of "dynamic properties", that is > properties that have not been declared in the class (stdClass and > __get/__set excluded, of course): > > https://wiki.php.net/rfc/deprecate_dynamic_properties > > This has been discussed in various forms i

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

> And why not adding an extra keyword, such as: > > ``` > dynamic class Foo { } // Dynamic allowed > class Bar {} // Dynamic disallowed > ?> > ``` I am opposed. IMO it's not worth adding anything to the language to preserve this existing behavior other than allowing `__get`/`__set`, etc, which al

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

Le 25/08/2021 à 15:51, Rowan Tommins a écrit : On 25/08/2021 13:45, Nikita Popov wrote: We obviously need to keep support for dynamic properties on stdClass, and if we do so, I would expect that to apply to subclasses as well. Does that actually follow, though? Right now, there is no advantag

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 9:51 AM Rowan Tommins wrote: > On 25/08/2021 13:45, Nikita Popov wrote: > > > We obviously need to keep support for dynamic properties on stdClass, > > and if we do so, I would expect that to apply to subclasses as well. > > Does that actually follow, though? Right now, th

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 3:51 PM Rowan Tommins wrote: > On 25/08/2021 13:45, Nikita Popov wrote: > > > We obviously need to keep support for dynamic properties on stdClass, > > and if we do so, I would expect that to apply to subclasses as well. > > Does that actually follow, though? Right now, th

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On 25/08/2021 13:45, Nikita Popov wrote: We obviously need to keep support for dynamic properties on stdClass, and if we do so, I would expect that to apply to subclasses as well. Does that actually follow, though? Right now, there is no advantage to extending stdClass, so no reason to expect

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 12:45 PM Rowan Tommins wrote: > On 25/08/2021 11:02, Nikita Popov wrote: > > I'd like to propose the deprecation of "dynamic properties", that is > > properties that have not been declared in the class (stdClass and > > __get/__set excluded, of course): > > > > https://wik

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On 25.08.21 12:45, Rowan Tommins wrote: * Adding a parent to an existing class isn't always possible, if it already inherits from something else. Perhaps the behaviour could also be available as a trait, which defined stub __get and __set methods, allowing for the replacement of the internal impl

[PHP-DEV] Re: [RFC] Deprecate dynamic properties

Den 2021-08-25 kl. 12:02, skrev Nikita Popov: Hi internals, I'd like to propose the deprecation of "dynamic properties", that is properties that have not been declared in the class (stdClass and __get/__set excluded, of course): https://wiki.php.net/rfc/deprecate_dynamic_properties This has be

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

> > Hi internals, > > I'd like to propose the deprecation of "dynamic properties", that is > properties that have not been declared in the class (stdClass and > __get/__set excluded, of course): > > https://wiki.php.net/rfc/deprecate_dynamic_properties > > This has been discussed in various forms i

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

HI Nikita, What if you consider this instead? Rather allowing STD class as an exception to dynamic properties, why not introduce STDAbstract? ```php interface STDClassInterface { public function __get(string $name) : mixed; public function __set(string $name, mixed $value = null) : mixed; /* * oth

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

Hey Nikita On Wed, Aug 25, 2021 at 12:03 PM Nikita Popov wrote: > Hi internals, > > I'd like to propose the deprecation of "dynamic properties", that is > properties that have not been declared in the class (stdClass and > __get/__set excluded, of course): > > https://wiki.php.net/rfc/deprecate_

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 7:46 AM Rowan Tommins wrote: > On 25/08/2021 11:02, Nikita Popov wrote: > > I'd like to propose the deprecation of "dynamic properties", that is > > properties that have not been declared in the class (stdClass and > > __get/__set excluded, of course): > > > > https://wiki

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On 25.08.2021 13:02, Nikita Popov wrote: Hi internals, I'd like to propose the deprecation of "dynamic properties", that is properties that have not been declared in the class (stdClass and __get/__set excluded, of course): https://wiki.php.net/rfc/deprecate_dynamic_properties This has been di

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On 25/08/2021 11:02, Nikita Popov wrote: I'd like to propose the deprecation of "dynamic properties", that is properties that have not been declared in the class (stdClass and __get/__set excluded, of course): https://wiki.php.net/rfc/deprecate_dynamic_properties This is a bold move, and in p

Re: [PHP-DEV] [RFC] Deprecate dynamic properties

On Wed, Aug 25, 2021 at 12:03 PM Nikita Popov wrote: > This RFC takes the more direct route of deprecating this functionality > entirely. I expect that this will have relatively little impact on modern > code (e.g. in Symfony I could fix the vast majority of deprecation warnings > with a three-li

[PHP-DEV] [RFC] Deprecate dynamic properties

Hi internals, I'd like to propose the deprecation of "dynamic properties", that is properties that have not been declared in the class (stdClass and __get/__set excluded, of course): https://wiki.php.net/rfc/deprecate_dynamic_properties This has been discussed in various forms in the past, e.g.

Re: [PHP-DEV] mb_check_encoding slow performance?

On Mon, Aug 16, 2021 at 10:56 AM Alex wrote: > Dear Nikita, > > It looks like we think alike. > > I already have a local dev branch on my PC with the beginnings of the > internal interface change which you describe here. In some cases which I > tested, it makes mbstring encoding conversion operat