Re: [PHP-DEV] [RFC] [VOTE] is_literal

2021-07-09 Thread Craig Francis
On Fri, 9 Jul 2021 at 11:49, Lauri Kenttä wrote: > is there a compelling reason why the internal names couldn't be marked > literal > (even if it's technically "wrong")? Hi Lauri, Just again quickly noting we’re only talking about ~0.43% difference, nothing major in any way. But we wanted to

[PHP-DEV] Re: Fake Closure Comparison

2021-07-09 Thread Joe Watkins
The test included is quite comprehensive. Cheers Joe On Friday, 9 July 2021, Larry Garfield wrote: > On Fri, Jul 9, 2021, at 4:51 AM, Nikita Popov wrote: > > On Fri, Jul 9, 2021 at 10:45 AM Joe Watkins wrote: > > > > > Morning internals, > > > > > > While discussing some of the details of the

Re: [PHP-DEV] Fake Closure Comparison

2021-07-09 Thread Larry Garfield
On Fri, Jul 9, 2021, at 4:51 AM, Nikita Popov wrote: > On Fri, Jul 9, 2021 at 10:45 AM Joe Watkins wrote: > > > Morning internals, > > > > While discussing some of the details of the first class callable RFC, it > > became apparent that fake closures (created by Closure::fromCallable) are > > not

Re: [PHP-DEV] [RFC] [VOTE] is_literal

2021-07-09 Thread Lauri Kenttä
On 2021-07-07 12:23, Nikita Popov wrote: permanent interned strings, which will be predominantly (or entirely?) non-literal. At least it doesn't look to me like names of internal functions/classes/etc are considered literal. I think this may be problematic, in that now the permanent non-literal i

Re: [PHP-DEV] Fake Closure Comparison

2021-07-09 Thread Pierre
Le 09/07/2021 à 10:45, Joe Watkins a écrit : Morning internals, While discussing some of the details of the first class callable RFC, it became apparent that fake closures (created by Closure::fromCallable) are not currently comparable in a useful way. Although this is not directly related to t

Re: [PHP-DEV] Fake Closure Comparison

2021-07-09 Thread Nikita Popov
On Fri, Jul 9, 2021 at 10:45 AM Joe Watkins wrote: > Morning internals, > > While discussing some of the details of the first class callable RFC, it > became apparent that fake closures (created by Closure::fromCallable) are > not currently comparable in a useful way. > > Although this is not dir

[PHP-DEV] Fake Closure Comparison

2021-07-09 Thread Joe Watkins
Morning internals, While discussing some of the details of the first class callable RFC, it became apparent that fake closures (created by Closure::fromCallable) are not currently comparable in a useful way. Although this is not directly related to the first class callable feature, it's likely th