Re: [PHP-DEV] [RFC] New in initializers

2021-06-16 Thread Mike Schinkel
> On Jun 16, 2021, at 7:47 AM, Larry Garfield wrote: > > On Wed, Jun 16, 2021, at 3:16 AM, Nikita Popov wrote: > > Given that constructors that have side effects are arguably broken to begin > with (modulo debugging), I'd be comfortable with explicitly saying that the > evaluation order is und

Re: [PHP-DEV] Re: [RFC] is_literal

2021-06-16 Thread Craig Francis
On Wed, 16 Jun 2021 at 10:19 pm, Bruce Weirdan wrote: > On Thu, Jun 17, 2021 at 12:01 AM Craig Francis > wrote: > > is_literal can be used for strings because we can flag what’s > > user and what’s developer defined, and with Matthew’s request, it could > do > > integers (because an integer valu

Re: [PHP-DEV] Re: [RFC] is_literal

2021-06-16 Thread Bruce Weirdan
On Thu, Jun 17, 2021 at 12:01 AM Craig Francis wrote: > is_literal can be used for strings because we can flag what’s > user and what’s developer defined, and with Matthew’s request, it could do > integers (because an integer value alone is not inherently risky, and it’s > already used a lot). To

Re: [PHP-DEV] Re: [RFC] is_literal

2021-06-16 Thread Craig Francis
On Wed, 16 Jun 2021 at 9:13 pm, Dik Takken wrote: > On 16-06-2021 19:24, Craig Francis wrote: > > Matthew Brown wants to support integer values, simply because so much > code > > already includes them, and I cannot find a single way that integers alone > > can cause issues from an Injection Vulne

Re: [PHP-DEV] Re: [RFC] is_literal

2021-06-16 Thread Dik Takken
On 16-06-2021 19:24, Craig Francis wrote: > On Sat, 12 Jun 2021 at 18:00, Craig Francis > wrote: > >> I'd like to start the discussion on the is_literal() RFC: >> https://wiki.php.net/rfc/is_literal >> > > > > Hi Internals, > > Following up on the is_literal() RFC, thanks for the feedback. It

[PHP-DEV] Re: [RFC] is_literal

2021-06-16 Thread Craig Francis
On Sat, 12 Jun 2021 at 18:00, Craig Francis wrote: > I'd like to start the discussion on the is_literal() RFC: > https://wiki.php.net/rfc/is_literal > Hi Internals, Following up on the is_literal() RFC, thanks for the feedback. It looks like there are only 2 minor open issues - updating the i

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key&repeating keys)

2021-06-16 Thread Levi Morrison via internals
> Over half of the objections are to functionality, over half to unspecified > reasons, I support people choosing not to directly respond with their unspecified reasons, but if anyone is open to sharing I would appreciate them doing so. I agree with Nikita that the concept is useful, and with som

[PHP-DEV] [Vote] Partial Function Application

2021-06-16 Thread Larry Garfield
Hi folks. The vote for the Partial Function Application RFC is now open, and will run until 30 June. https://wiki.php.net/rfc/partial_function_application Of particular note, a few people had asked about using ...? instead of ... for the variadic placeholder. In the end we decided not to expl

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key&repeating keys)

2021-06-16 Thread tyson andre
Hi Nikita, > I like the concept here. I think the naming choice is unfortunate, and > causing confusion for people. > > What you're really proposing here is a data structure: A sequence of > key-value-pairs. That generally seems like a sensible thing to have, in that > we can implement it sign

Re: [PHP-DEV] [RFC] New in initializers

2021-06-16 Thread Larry Garfield
On Wed, Jun 16, 2021, at 3:16 AM, Nikita Popov wrote: > > Arguments and attributes are enough to justify this RFC on its own, but is > > there a way we can resolve the static property question? Right now the RFC > > says "these initializers are evaluated lazily the first time a class is > > used

Re: [PHP-DEV] [RFC] Deprecations for PHP 8.1

2021-06-16 Thread Larry Garfield
On Tue, Jun 15, 2021, at 10:59 PM, Mike Schinkel wrote: > > On Jun 15, 2021, at 6:53 AM, Nikita Popov wrote: > > > > As we're moving closer to feature freeze, I'd like to close down this RFC > > to further additions, and move towards voting. > > > > Feedback on the proposed deprecations is appre

Re: [PHP-DEV] [VOTE] ImmutableIterable (immutable, rewindable, allows any key&repeating keys)

2021-06-16 Thread Nikita Popov
On Tue, Jun 15, 2021 at 4:01 PM tyson andre wrote: > Hi internals, > > Voting has started on the ImmutableIterable RFC > https://wiki.php.net/rfc/cachediterable > > Previous discussion can be found in https://externals.io/message/114834 > > Recent changes: > - The name was renamed to `ImmutableIt

Re: [PHP-DEV] [RFC] New in initializers

2021-06-16 Thread Nikita Popov
On Tue, Jun 15, 2021 at 6:31 PM Larry Garfield wrote: > On Tue, Jun 15, 2021, at 10:06 AM, Nikita Popov wrote: > > On Fri, Jun 11, 2021 at 5:02 PM Larry Garfield > > wrote: > > > > > On Wed, Mar 3, 2021, at 9:03 AM, Nikita Popov wrote: > > > > Hi internals, > > > > > > > > I would like to propos