Re: [PHP-DEV] Changes to Git commit workflow

2021-04-18 Thread Casper Langemeijer
On 01-04-2021 06:54, Bishop Bettini wrote: I've documented why we need signing, and how to set it up: https://wiki.php.net/vcs/commit-signing Feedback welcomed! In "Step 5 of 7: Configure git to use that key ID" you set `git config --global --replace user.signingkey "${GPG_KEYID}"` I found

Re: [PHP-DEV] [RFC] [Draft] Final constants

2021-04-18 Thread Nikita Popov
On Sun, Apr 18, 2021 at 4:20 PM Máté Kocsis wrote: > Hi Internals, > > I've recently realized that class constant values cannot always be trusted > when late static binding is involved (e.g. static::FOO or $this::FOO), > since they can be freely overridden in child classes. That's why the engine

[PHP-DEV] [RFC] [Draft] Final constants

2021-04-18 Thread Máté Kocsis
Hi Internals, I've recently realized that class constant values cannot always be trusted when late static binding is involved (e.g. static::FOO or $this::FOO), since they can be freely overridden in child classes. That's why the engine knows neither the type and the value before run-time. Doctrin

Re: [PHP-DEV] [RFC] [Discussion] Adding return types to internal methods

2021-04-18 Thread Máté Kocsis
Thank you, Nikita, for the wise wrap-up about the general problem and the possible solutions! I think as far as the original motivation is concerned (adding return types > to internal methods), the RFC as proposed does well. The only thing I would > change is to add the ReflectionMethod::getTentat