Re: [PHP-DEV] [VOTE] Object scoped RNG implementation

Hi Morrison. > Sorry if I missed an optional "intent to vote soon" thread. I thought I had announced it here, but I did not indicate the specific dates. I apologize for that. https://externals.io/message/113720 > simply based on the fact that namespaced things are going into`ext/standard`. Yes,

Re: [PHP-DEV] [VOTE] noreturn type

> On Apr 1, 2021, at 2:03 PM, Levi Morrison via internals > wrote: > > I do not care which name is chosen, but if we are going to have this > sort of thing in the language, it ought to be a bottom type, not an > attribute. > You make an excellent point Levi. I initially chose `noreturn` simpl

Re: [PHP-DEV] Changes to Git commit workflow

On Thu, Apr 1, 2021 at 10:17 PM CHU Zhaowei wrote: > Hi Nikita, > > Can I check with you if the hook integrating with bugs.php.net still > works? I just committed a bug fix on doc-zh repo, and the bug report has > been updated. Thanks. > > Regards, > CHU Zhaowei > This issue is probably fixed by

RE: [PHP-DEV] Changes to Git commit workflow

Hi Nikita, Can I check with you if the hook integrating with bugs.php.net still works? I just committed a bug fix on doc-zh repo, and the bug report has been updated. Thanks. Regards, CHU Zhaowei -Original Message- From: Nikita Popov Sent: Monday, March 29, 2021 6:52 AM To: PHP inter

Re: [PHP-DEV] [VOTE] Object scoped RNG implementation

On Wed, Mar 31, 2021 at 10:39 PM Go Kudo wrote: > > Hello everyone. > > Object scoped RNG RFC vote is now open. > https://wiki.php.net/rfc/object_scope_prng > > The deadline for voting is April 15. > > Previous discussions can be viewed below. > > https://externals.io/message/112765 > https://exte

Re: [PHP-DEV] [VOTE] noreturn type

On Thu, Apr 1, 2021 at 6:59 AM Matthew Brown wrote: > > On Thu, 1 Apr 2021 at 04:56, Benjamin Eberlei wrote: > > > This RFC is using the declaration of the return type, to specify that it > > never returns. As such noreturn or never is a keyword a long the lines of > > public or final, but it is

Re: [PHP-DEV] [VOTE] noreturn type

On 1. 4. 2021 19:24:35, Bruce Weirdan wrote: > Since `throw` is an expression (since PHP 8.0, > https://wiki.php.net/rfc/throw_expression), it must have a type for its > result, > as any expression has a type. And it's result is exactly `noreturn` (or > `never`, as this option seems to be preferr

Re: [PHP-DEV] [RFC] noreturn type

On Thu, 1 Apr 2021 at 15:05, Matthew Brown wrote: > > On Tue, 30 Mar 2021 at 13:51, Ilija Tovilo wrote: > > > Hi Matthew > > > > > I like the proposal. I also support the covariance. > > > > > > One question though. > > > The RFC mentions possible future use of "nothing" as a bottom type for > >

Re: [PHP-DEV] [VOTE] noreturn type

On Thu, Apr 1, 2021 at 6:07 PM Benjamin Eberlei wrote: > > ```php > if (!isset($user)) { >throw new NotFoundException(); > } > ``` > Since `throw` is an expression (since PHP 8.0, https://wiki.php.net/rfc/throw_expression), it must have a type for its result, as any expression has a type. An

Re: [PHP-DEV] Changes to Git commit workflow

On Thu, Apr 1, 2021 at 12:24 PM Sara Golemon wrote: > On Thu, Apr 1, 2021 at 11:19 AM Rowan Tommins > wrote: > > > On 01/04/2021 15:59, Sara Golemon wrote: > > > On Thu, Apr 1, 2021 at 9:21 AM Bishop Bettini > > > wrote: > > > > > > I also added a FAQ. > > > > > > > >

Re: [PHP-DEV] Changes to Git commit workflow

On Thu, Apr 1, 2021 at 11:19 AM Rowan Tommins wrote: > On 01/04/2021 15:59, Sara Golemon wrote: > > On Thu, Apr 1, 2021 at 9:21 AM Bishop Bettini > > wrote: > > > > I also added a FAQ. > > > > > > I disagree with the position this document takes on immortal keys. We >

Re: [PHP-DEV] Changes to Git commit workflow

On 01/04/2021 15:59, Sara Golemon wrote: On Thu, Apr 1, 2021 at 9:21 AM Bishop Bettini > wrote: I also added a FAQ. I disagree with the position this document takes on immortal keys.  We should encourage best-practices with the knowledge that some people will weake

Re: [PHP-DEV] [VOTE] noreturn type

On 01.04.21 17:07, Benjamin Eberlei wrote: I don't know, you are arguing that you forgot a return, but you also did not forget to add a never return type. You could easily fix this by inlining the exception instead. ```php if (!isset($user)) { throw new NotFoundException(); } ``` Even when y

Re: [PHP-DEV] Changes to Git commit workflow

On Thu, Apr 1, 2021 at 11:32 AM Christoph M. Becker wrote: > On 01.04.2021 at 17:09, Kalle Sommer Nielsen wrote: > > > Den tor. 1. apr. 2021 kl. 07.55 skrev Bishop Bettini : > > > >> I've documented why we need signing, and how to set it up: > >> > >> https://wiki.php.net/vcs/commit-signing > >>

Re: [PHP-DEV] Changes to Git commit workflow

On 01.04.2021 at 17:09, Kalle Sommer Nielsen wrote: > Den tor. 1. apr. 2021 kl. 07.55 skrev Bishop Bettini : > >> I've documented why we need signing, and how to set it up: >> >> https://wiki.php.net/vcs/commit-signing >> >> Feedback welcomed! > > Great guide, Yes, thanks for that, Bishop! > any

Re: [PHP-DEV] Changes to Git commit workflow

Hi Bishop Den tor. 1. apr. 2021 kl. 07.55 skrev Bishop Bettini : > I've documented why we need signing, and how to set it up: > > https://wiki.php.net/vcs/commit-signing > > Feedback welcomed! Great guide, any chance to add some Windows information here? -- regards, Kalle Sommer Nielsen ka...@

Re: [PHP-DEV] [VOTE] noreturn type

On Thu, Apr 1, 2021 at 3:56 PM Andreas Leathley wrote: > On 01.04.21 10:56, Benjamin Eberlei wrote: > > This RFC is using the declaration of the return type, to specify that it > > never returns. As such noreturn or never is a keyword a long the lines of > > public or final, but it is not a retur

Re: [PHP-DEV] Changes to Git commit workflow

On Thu, Apr 1, 2021 at 9:21 AM Bishop Bettini wrote: > I also added a FAQ. > > I disagree with the position this document takes on immortal keys. We should encourage best-practices with the knowledge that some people will weaken their security with an immortal key, not start from a weak position

Re: [PHP-DEV] [VOTE] Object scoped RNG implementation

Hi Xavier > If I understand correctly, this would > - provide us with performant object-encapsulated (isolated from global state) equivalents of the existing `mt_srand()`/`mt_rand()` and `random_int()` functions as well as a new "XorShift128+"; along with some global functions for usability, nota

Re: [PHP-DEV] Changes to Git commit workflow

On Thu, Apr 1, 2021 at 9:22 AM Rowan Tommins wrote: > On 01/04/2021 05:54, Bishop Bettini wrote: > > I've documented why we need signing, and how to set it up: > > > > https://wiki.php.net/vcs/commit-signing > > > > Feedback welcomed! > > > This looks great, and very easy to follow. > > One edit

Re: [PHP-DEV] [VOTE] noreturn type

On 01.04.21 10:56, Benjamin Eberlei wrote: This RFC is using the declaration of the return type, to specify that it never returns. As such noreturn or never is a keyword a long the lines of public or final, but it is not a return type. I don't think the argument for potential optimizations in Op

Re: [PHP-DEV] Changes to Git commit workflow

On 01/04/2021 05:54, Bishop Bettini wrote: I've documented why we need signing, and how to set it up: https://wiki.php.net/vcs/commit-signing Feedback welcomed! This looks great, and very easy to follow. One edit I would strongly suggest though: Remove the "Passphrase:" line from the --gen

Re: [PHP-DEV] Re: Changes to Git commit workflow

On Thu, Apr 1, 2021 at 2:59 AM Sebastian Bergmann wrote: > Am 01.04.2021 um 09:58 schrieb Jan Ehrhardt: > > Will PHP 8.0.4 and 7.4.17 be postponed because of this? They haven't been > > released yet. The usual day for tagging always was Tuesday or Wednesday. > > Yes, see https://twitter.com/offic

Re: [PHP-DEV] [RFC] noreturn type

On Tue, 30 Mar 2021 at 13:51, Ilija Tovilo wrote: > Hi Matthew > > > I like the proposal. I also support the covariance. > > > > One question though. > > The RFC mentions possible future use of "nothing" as a bottom type for > > parameters in generics. This makes a lot of sense to me. Even withou

Re: [PHP-DEV] [VOTE] noreturn type

On Thu, 1 Apr 2021 at 04:56, Benjamin Eberlei wrote: > This RFC is using the declaration of the return type, to specify that it > never returns. As such noreturn or never is a keyword a long the lines of > public or final, but it is not a return type. > > I don't think the argument for potential

Re: [PHP-DEV] Why is assert limited to a debugging feature only?

Hi, On 1 April 2021 09:24:54 BST, Arnold Daniels wrote: >The documentation of `assert` >([https://php.net/assert)](https://www.php.net/manual/en/function.assert.php)) >states that's debugging only. This is further enforced by php.ini flags >to disable assertions in production. This is, in a sen

[PHP-DEV] [VOTE] Deprecate implicit non-integer-compatible float to int conversions

Hello internals, It's been a couple of weeks and no further comments have been made as such voting is now open: https://wiki.php.net/rfc/implicit-float-int-deprecate It will run for two weeks until the 14th of April 2021. Best regards, George P. Banyard

Re: [PHP-DEV] [VOTE] Object scoped RNG implementation

On Thu, Apr 1, 2021 at 6:39 AM Go Kudo wrote: > Hello everyone. > > Object scoped RNG RFC vote is now open. > https://wiki.php.net/rfc/object_scope_prng > > The deadline for voting is April 15. > > Previous discussions can be viewed below. > > https://externals.io/message/112765 > https://externa

Re: [PHP-DEV] Changes to Git commit workflow

Hi Bishop, On 01.04.21 06:54, Bishop Bettini wrote: I've documented why we need signing, and how to set it up: https://wiki.php.net/vcs/commit-signing Feedback welcomed! I'm not even the target audience in terms of php-src access, but rarely have I seen such a good tutorial approach on this

Re: [PHP-DEV] Why is assert limited to a debugging feature only?

Le 01/04/2021 à 10:50, Olle Härstedt a écrit : Dunno about the motivation of the implementors, but usually assertions are used for internal invariants and mental checks while exceptions should be used for interaction with the outside world (database errors, user input errors etc). If you follow t

Re: [PHP-DEV] Why is assert limited to a debugging feature only?

On Thu, Apr 1, 2021 at 10:50 AM Olle Härstedt wrote: > 2021-04-01 10:24 GMT+02:00, Arnold Daniels : > > Hi, > > > > The documentation of `assert` > > ([ > https://php.net/assert)](https://www.php.net/manual/en/function.assert.php > )) > > states that's debugging only. This is further enforced by

Re: [PHP-DEV] [VOTE] noreturn type

Am 01.04.2021 um 10:56 schrieb Benjamin Eberlei: I voted no, because i think this should at the maximum be an attribute. This RFC is using the declaration of the return type, to specify that it never returns. As such noreturn or never is a keyword a long the lines of public or final, but it is n

Re: [PHP-DEV] [VOTE] noreturn type

On Tue, Mar 30, 2021 at 5:07 PM Matthew Brown wrote: > Hey everyone! > > The vote for adding noreturn is now open: > > https://wiki.php.net/rfc/noreturn_type > > Voting will run through April 13th > > Best wishes, > > Matt and Ondrej > I voted no, because i think this should at the maximum be an

Re: [PHP-DEV] Why is assert limited to a debugging feature only?

2021-04-01 10:24 GMT+02:00, Arnold Daniels : > Hi, > > The documentation of `assert` > ([https://php.net/assert)](https://www.php.net/manual/en/function.assert.php)) > states that's debugging only. This is further enforced by php.ini flags to > disable assertions in production. > > Why are the use

[PHP-DEV] Why is assert limited to a debugging feature only?

Hi, The documentation of `assert` ([https://php.net/assert)](https://www.php.net/manual/en/function.assert.php)) states that's debugging only. This is further enforced by php.ini flags to disable assertions in production. Why are the use cases of this feature being limited to debugging? We can

Re: [PHP-DEV] Re: Changes to Git commit workflow

Am 01.04.2021 um 09:58 schrieb Jan Ehrhardt: Will PHP 8.0.4 and 7.4.17 be postponed because of this? They haven't been released yet. The usual day for tagging always was Tuesday or Wednesday. Yes, see https://twitter.com/official_php/status/1377339882645905408 -- PHP Internals - PHP Runtime De

[PHP-DEV] Re: Changes to Git commit workflow

Nikita Popov in php.internals (Mon, 29 Mar 2021 00:52:24 +0200): >We're reviewing the repositories for any corruption beyond the two >referenced commits. Will PHP 8.0.4 and 7.4.17 be postponed because of this? They haven't been released yet. The usual day for tagging always was Tuesday or Wednesda