Re: [PHP-DEV] RFC: Support for multi-line arrow functions

2020-10-07 Thread Rowan Tommins
Hi Brent, On 06/10/2020 09:53, Brent Roose wrote: We can have the discussion again on whether we like short closures or not, but it turned out most of internals_and_ userland devs do — based on the vote count in the sigle line RFC and the reaction on Nuno's PR, as well as my experience from

Re: [PHP-DEV] Attributes and constructor property promotion

2020-10-07 Thread Nikita Popov
On Tue, Oct 6, 2020 at 6:59 PM Rowan Tommins wrote: > On Tue, 6 Oct 2020 at 17:20, Andreas Leathley wrote: > > > From my understanding suppressing the validation errors in this > > particular case would be a good solution, or are there any serious > > downsides to that? > > > > > The downside pr

Re: [PHP-DEV] Attributes and constructor property promotion

2020-10-07 Thread Markus Fischer
Hi! On 06.10.20 17:15, Sara Golemon wrote: My opinion on constructor property promotion (CPP) is that it's something for small value object classes and should probably be regarded as code-smell on larger classes. At the same time, annotations belong with more complex objects and not so much with