Re: [PHP-DEV] Add interface implementation to class in separate file

2020-09-16 Thread Olle Härstedt
2020-09-16 3:30 GMT, Mike Schinkel : > > >> On Sep 13, 2020, at 3:49 PM, Olle Härstedt >> wrote: >> >> 2020-09-13 17:58 GMT, Benjamin Eberlei > >: >>> On Sat, Sep 12, 2020 at 10:23 PM Olle Härstedt >>> wrote: >>> Hi internals! Separation of data and beha

Re: [PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-16 Thread Matteo Beccati
Hi Nikita, On 16/09/2020 12:46, Nikita Popov wrote: > No, this just means that your CI is running tests that our CI doesn't. > In this case, you are probably using a different MySQL version and thus > run a different subset of tests. I know that, and that's why I keep it running it ;-) I was jus

[PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-16 Thread Matteo Beccati
Hey everybody, I've noticed a test failing today on my CI and went through my local php-cvs ML archive to see what could have caused it, without finding a match. That has happened a few times already and I believe it was always with some "Closes GH-XXX" commits. I'm just guessing here, but maybe

Re: [PHP-DEV] Git workflow, PRs and php-cvs ML

2020-09-16 Thread Nikita Popov
On Wed, Sep 16, 2020 at 12:44 PM Matteo Beccati wrote: > Hey everybody, > > I've noticed a test failing today on my CI and went through my local > php-cvs ML archive to see what could have caused it, without finding a > match. That has happened a few times already and I believe it was always > wi