Re: [PHP-DEV] SQLite3, PDO/SQLite and driver specific methods

2020-06-21 Thread Dan Ackroyd
On Sat, 20 Jun 2020 at 15:22, Peter Bowyer wrote: > > Digging into the PHP source code is a fun challenge. It really isn't. Collecting and publishing information on how to work on PHP core, is one thing that takes a lot of time, that we should make easier for people to contribute to. > I've got

Re: [PHP-DEV] [RFC] [DISCUSSION] Make constructors and destructors return void

2020-06-21 Thread Rowan Tommins
Hi Andreas, On 18/06/2020 17:02, Andreas Hennings wrote: I am ok with restricting the use of "return *;" inside a constructor. But I don't like allowing the ": void" declaration. The way I look at it, constructors are mostly declared like a normal method - they use the keyword "function"; can

Re: [PHP-DEV] New functions `hash_serialize` and `hash_unserialize`?

2020-06-21 Thread Eddie Kohler
Hi all, I've opened up a pull request and responded to this message there. I'd love any further comments. https://github.com/php/php-src/pull/5702 Eddie On Thu, Jun 11, 2020 at 5:42 PM Sara Golemon wrote: > WARNING: Harvard cannot validate this message was sent from an authorized > system. P