Re: [PHP-DEV] Revisiting proposal for addition of `get_class_constants()`

2020-06-12 Thread Chuck Adams
> 1. It aligns with the addition of the functions referenced in the original post (`str_[contains|starts_with|ends_with]()`), and one their stated reasons of simplifying the API for userland developers. Two reactions to this: One, reflection isn't a facility for novices, so there's no need to cate

Re: [PHP-DEV] RFC: separate inheritance from subtyping (PHP v8)

2020-06-12 Thread Michael Morris
PHP's notion of "implements" is identical to that of Java and C#. This is not by accident, many programmers have to work in multiple programming languages. The less a language does things "differently" the better. And honestly, the upsides of this proposal are not worth the BC breaks created with

Re: [PHP-DEV] Revisiting proposal for addition of `get_class_constants()`

2020-06-12 Thread Nikita Popov
On Fri, Jun 12, 2020 at 6:32 AM Troy McCabe wrote: > Hey Nikita, > > Thanks for the thoughts. > > > Could you please explain in more detail *why* we should duplicate > existing reflection functionality into free-standing functions? > > In terms of the *why*, there were three main reasons: > 1. It

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-12 Thread Rowan Tommins
On Fri, 12 Jun 2020 at 10:30, Jakob Givoni wrote: > > Token names shouldn't show up. Everyone is agreeing with that statement. > > Universally. Let's fix that problem rather than create new ones by not > > addressing the underlying issue. > > Are you saying that this RFC is creating a new probl

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-12 Thread Guilliam Xavier
> So please, let the parser tell me not only the line of the error, but also the colum. > Other information currently missing from the message - e.g. column > number, hints about unclosed blocks - is likely to be far more useful >> a) Character count (at line 456, character 23) > >> > >> b) Quote

Re: [PHP-DEV][RFC] Rename T_PAAMAYIM_NEKUDOTAYIM to T_DOUBLE_COLON

2020-06-12 Thread Jakob Givoni
On Thu, Jun 11, 2020 at 12:14 AM Sara Golemon wrote: > > You know what shows up unambiguously in a google search? "Paamayim > Nekudotayim". > You know what ISN'T unambiguous in a google search? "Double Colon" Straw man. The point being that you wouldn't have to Google "Double Colon" because it is

Re: [PHP-DEV] Revisiting proposal for addition of `get_class_constants()`

2020-06-12 Thread Rowan Tommins
On Fri, 12 Jun 2020 at 05:32, Troy McCabe wrote: > > > You do mention performance as a benefit, but it's not immediately > obvious to me which use-cases are bottlenecked by class constant reflection. > > Enum implementations are the big case for this. > I've also used it in the past for generat