Re: [PHP-DEV] Proposal For Return-If / Early Return / Guard Clause Syntax

2020-05-18 Thread Manuel Canga
Hi, Internals, En dom, 17 may 2020 06:33:51 +0200 Peter Stalman escribió > A few thoughts: > > > 1. I agree with the sentiment that this syntactic sugar doesn't > actually save any verbosity, so it's not really syntactic sugar at > all. > > > 2. There appears to now b

Re: [PHP-DEV] SPL development interest

2020-05-18 Thread Johannes Schlüter
On Sat, 2020-05-16 at 16:37 +0200, Jakob Givoni wrote: > The reason I was wondering about it was mostly for understanding > where > one would put Classes, Interfaces and Traits that should be essential > parts of the language. > F.ex. it seems the Countable interface should have been in the core >

Re: [PHP-DEV] SPL development interest

2020-05-18 Thread Levi Morrison via internals
In my opinion, another key takeaway: inheritance as a code reuse mechanism can really bite you. SplStack extends SplDoublyLinkedList and this exposes a bunch of methods on a stack that don't make any sense. It also means there are constraints on how well you can optimize the stack, because you have

Re: [PHP-DEV] SPL development interest

2020-05-18 Thread Johannes Schlüter
On Fri, 2020-05-15 at 12:53 +0100, Dan Ackroyd wrote: > Obviously, all of the following is my own personal opinion, and other > people may have different opinions. > > There are two main lessons learnt from the SPL experience. > > i) Some APIs need to evolve separately from the PHP release > sche

Re: [PHP-DEV] Graceful timeout

2020-05-18 Thread Johannes Schlüter
On Sat, 2020-05-16 at 19:15 +0100, Derick Rethans wrote: > sleep(2) should not trigger a 1 second timeout. Currently the time > counted for max_execution_time timeouts is CPU time, not wall time. I might remember wrongly, but I think on Windows it uses wall time. One thing to consider when carin

Re: [PHP-DEV] [RFC] Add CMS Support

2020-05-18 Thread Dan Ackroyd
On Mon, 18 May 2020 at 10:55, Eliot Lear wrote: > > there is an open question as > to whether it should be an RFC I don't think it should be. The questions and problems related to cryptography are far too detailed for a useful conversation to be had for anyone who doesn't understand them deeply.

Re: [PHP-DEV] [RFC] Add CMS Support

2020-05-18 Thread Eliot Lear
Aannd as a reminder, this RFC is open, and there is an open question as to whether it should be an RFC ;-) Over the last week I did spot one additional problem in the code that I fixed.  Additional review is always welcome, and in particular I am interested in any code that would exercise the flag