Re: [PHP-DEV] Re: PR #5251 adds support for CMS (RFC5662)

Hi! On 12.05.20 17:10, G. P. B. wrote: > Does this really require an RFC? > This seems like just exposing some underlying functionality from OpenSSL > to userland which I wouldn't have expected to need an RFC to be added. Whether or not you wish to use the full process (voting and all) is not som

Re: [PHP-DEV] Re: PR #5251 adds support for CMS (RFC5662)

On Mon, 11 May 2020 at 12:45, Christoph M. Becker wrote: > On 11.05.2020 at 11:59, Eliot Lear wrote: > > > Hi everyone, > > > > I am new to the PHP development process, so please forgive me if I have > > this wrong. > > > > In PR #5251[1] I’ve created OpenSSL CMS functions that are nearly direct

Re: [PHP-DEV] [RFC] Make sorting stable

Am 12.05.2020 um 16:39 schrieb Nikita Popov: I'd prefer to avoid an extra option. PHP is a high-level language, and the user should not have to concern themselves with sort stability considerations. +1 -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.ph

Re: [PHP-DEV] [RFC] Make sorting stable

On Tue, May 12, 2020 at 4:29 PM Nicolas Grekas wrote: > Hi Nikita, > > Thanks for another nice RFC. > > This was previously discussed in https://externals.io/message/108841, but >> I >> figured it would make sense to create an RFC for this change: >> https://wiki.php.net/rfc/stable_sorting >> >>

Re: [PHP-DEV] [RFC] Make sorting stable

Hi Nikita, Thanks for another nice RFC. This was previously discussed in https://externals.io/message/108841, but I > figured it would make sense to create an RFC for this change: > https://wiki.php.net/rfc/stable_sorting > > As before, the implementation approach is to stick with the existing qs

[PHP-DEV] [RFC] Make sorting stable

Hi internals, This was previously discussed in https://externals.io/message/108841, but I figured it would make sense to create an RFC for this change: https://wiki.php.net/rfc/stable_sorting As before, the implementation approach is to stick with the existing qsort and use a fallback comparison

Re: [PHP-DEV] Re: Making all Traversables an Iterator or IteratorAggregate

> I do not believe we should expose the Zend term into userland. > Dunno if it helps or not, but there is a precedent here: ReflectionZendExtension Nicolas

Re: [PHP-DEV] Re: Making all Traversables an Iterator or IteratorAggregate

On Tue, 12 May 2020, Sara Golemon wrote: > On Tue, May 12, 2020 at 3:26 AM Nikita Popov wrote: > > // WeakMap::getIterator(): Iterator > > ZEND_METHOD(WeakMap, getIterator) > > { > > if (zend_parse_parameters_none() == FAILURE) { > > return; > > } > > zend_create_internal_iter

[PHP-DEV] Re: [RFC] Always available JSON extension

Hi internals, One update before I start the vote for  https://wiki.php.net/rfc/always_enable_json tomorrow (May 13th). - After feedback from extension authors and php contributors, the C define `HAVE_JSON` will not be removed as part of this RFC. I'll leave it to others to decide which php ver

Re: [PHP-DEV] Re: Making all Traversables an Iterator or IteratorAggregate

On Tue, 12 May 2020 at 13:49, Sara Golemon wrote: > > This might be one of those rare occasions where > exposing "Zend" into userspace makes sense. I think 'Engine' would be easier for userland people to grok. Also, for those brave souls who are implementing PHP in other technologies, avoiding u

Re: [PHP-DEV] Re: Making all Traversables an Iterator or IteratorAggregate

Hey Sara, > Am 12.05.2020 um 14:49 schrieb Sara Golemon : > > On Tue, May 12, 2020 at 3:26 AM Nikita Popov wrote: >> // WeakMap::getIterator(): Iterator >> ZEND_METHOD(WeakMap, getIterator) >> { >>if (zend_parse_parameters_none() == FAILURE) { >>return; >>} >>zend_create_inte

[PHP-DEV] OpenSSL 3.0 Alpha1 released

Hi all, a few weeks ago OpenSSL 3.0 Alpha1 has been released[1]. It seems to me that we should check what needs to be adapted in php-src to support OpenSSL 3.0 as soon as possible. Even if OpenSSL 3.0 will not be ready by the time PHP 8.0.0 will be released, any potentially required BC breaks fr

Re: [PHP-DEV] Re: Making all Traversables an Iterator or IteratorAggregate

On Tue, May 12, 2020 at 3:26 AM Nikita Popov wrote: > // WeakMap::getIterator(): Iterator > ZEND_METHOD(WeakMap, getIterator) > { > if (zend_parse_parameters_none() == FAILURE) { > return; > } > zend_create_internal_iterator_zval(return_value, ZEND_THIS); > } > Given that the b

[PHP-DEV] [VOTE] Unbundle ext/xmlrpc

Hi all, I have opened the voting for The voting period ends on 2020-05-26 (12:00 UTC). Thanks, Christoph -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: Making all Traversables an Iterator or IteratorAggregate

On Wed, Mar 11, 2020 at 10:50 AM Nikita Popov wrote: > Hi internals, > > Userland classes that implement Traversable must do so either through > Iterator or IteratorAggregate. The same requirement does not exist for > internal classes: They can implement the internal get_iterator mechanism, > wit