Re: [PHP-DEV] Optimizing assembly for spl_object_id(), fdiv(), etc in the JIT?

2020-04-25 Thread tyson andre
Hi Nikita, > Our general approach to this is to first add a VM opcode for the operation, > which will also provide a benefit if the JIT is not used. > There's already plenty of those, see ZEND_STRLEN for example. > Adding JIT support for the opcode would then be the natural second step. I've seen

Re: [PHP-DEV] Optimizing assembly for spl_object_id(), fdiv(), etc in the JIT?

2020-04-25 Thread Nikita Popov
On Sat, Apr 25, 2020 at 6:44 PM tyson andre wrote: > Hi internals, > > I was wondering if the maintainers of the Opcache Jit would be open to > work on optimizing functions such as intdiv(), fdiv(), and spl_object_id() > in the JIT to assembly code when it was safe to do so. > These functions hav

[PHP-DEV] Optimizing assembly for spl_object_id(), fdiv(), etc in the JIT?

2020-04-25 Thread tyson andre
Hi internals, I was wondering if the maintainers of the Opcache Jit would be open to work on optimizing functions such as intdiv(), fdiv(), and spl_object_id() in the JIT to assembly code when it was safe to do so. These functions have simple C implementations, so the performance overhead of ca

Re: [PHP-DEV] [VOTE] match expression

2020-04-25 Thread tyson andre
Hi Ilija, 1. I was confused by the vote announcement email about what "block statements" meant - https://github.com/php/php-src/pull/5371#discussion_r415079802 > Thus I have decided to move block expressions to a separate RFC. This is clarified in https://wiki.php.net/rfc/match_expression#bloc

Re: [PHP-DEV] [VOTE] match expression

2020-04-25 Thread Ilija Tovilo
Hi Dan > I like this idea, and would like to see 'match' in PHP. At the same > time, is there any need to have the vote right now? The deadline for > PHP 8 feature freeze is July 27 2020. I understand you sentiment. Let me put it this way: I've announced the first version of this RFC four weeks a

Re: [PHP-DEV] [VOTE] match expression

2020-04-25 Thread Bob Weinand
> Am 25.04.2020 um 12:39 schrieb Ilija Tovilo : > > Hi internals > > I have opened the voting on the match expression RFC. It will end on > 9th of May, 2020. > https://wiki.php.net/rfc/match_expression > > Here are the last changes: > > In the last update I mentioned allowing return values in b

Re: [PHP-DEV] [VOTE] match expression

2020-04-25 Thread Dan Ackroyd
On Sat, 25 Apr 2020 at 11:40, Ilija Tovilo wrote: > > Hi internals > > I have opened the voting on the match expression RFC. It will end on > 9th of May, 2020. > https://wiki.php.net/rfc/match_expression > > Here are the last changes: Hi Ilija, I like this idea, and would like to see 'match' in

[PHP-DEV] [VOTE] match expression

2020-04-25 Thread Ilija Tovilo
Hi internals I have opened the voting on the match expression RFC. It will end on 9th of May, 2020. https://wiki.php.net/rfc/match_expression Here are the last changes: In the last update I mentioned allowing return values in blocks. Unfortunately, we discovered some technical difficulties (memo

Re: [PHP-DEV] [VOTE] Round two, PHP 8.0 RM

2020-04-25 Thread Derick Rethans
On Sat, 25 Apr 2020, Pierre Joye wrote: > On Thu, Apr 23, 2020 at 1:44 AM Derick Rethans wrote: > > > as I mentioned, the first STV round ran into a tie, so there is a > > current run-off between the two candidates that tied, Gabriel and > > Ben, at: https://wiki.php.net/todo/php80#round_two >

Re: [PHP-DEV] Re: [RFC] PHP Namespace Policy

2020-04-25 Thread Rowan Tommins
Hi Michael, On 25 April 2020 00:00:32 BST, Michael Morris wrote: >Changing function names and argument orders would lead to BC breaks so >massive people would move away without a transition plan that was >sustainable long term. Namespaces give that opportunity, I think. You're not the first pe

Re: [PHP-DEV] [VOTE] Round two, PHP 8.0 RM

2020-04-25 Thread Pierre Joye
HI, On Thu, Apr 23, 2020 at 1:44 AM Derick Rethans wrote: > Hi, > > as I mentioned, the first STV round ran into a tie, so there is a > current run-off between the two candidates that tied, > Gabriel and Ben, at: https://wiki.php.net/todo/php80#round_two Is it Over? or edit error? I can vote