Re: [PHP-DEV] Re: RFCs should mention all BC breaks (was Re: [PHP-DEV] PHP 7.4 BC break with openssl_random_pseudo_bytes())

2019-09-24 Thread Pierre Joye
On Tue, Sep 24, 2019, 3:11 PM Christian Schneider wrote: > > So here is my question: Am I the only one who thinks BC breaks should be > fully covered in an RFC before voting? > If I am not mistaken this is the rule yes. A specific section should exist to list BC breaks. Also a BC break is not

Re: [PHP-DEV] [RFC] Union Types v2

2019-09-24 Thread Sara Golemon
On Tue, Sep 24, 2019 at 12:24 PM Claude Pache wrote: > The choice of supporting precisely the two literal values `null` and `false` > is not arbitrary: They are the two values that are the most often used as > sentinel values (for indicating failure or absence). It is true that `true` is > also so

Re: [PHP-DEV] [RFC] Union Types v2

2019-09-24 Thread Claude Pache
> Le 23 sept. 2019 à 22:14, Benjamin Morel a écrit : > > > So although true as a type does not have the same historical background as > false, it does seem that it's being used by enough packages to be worth > considering; what do you think? > Considering to support `true` will raise severa

Re: [PHP-DEV] Shutdown Memory Allowance (aka Soft Memory Limit)

2019-09-24 Thread Nikita Popov
On Tue, Sep 24, 2019 at 6:42 PM Dan Ackroyd wrote: > On Tue, 24 Sep 2019 at 07:26, Peter Stalman wrote: > > > > So I would like to suggest an option for setting a shutdown memory > allowance, > > which would be the amount of additional memory allowed to be used by any > > registered error handle

Re: [PHP-DEV] Shutdown Memory Allowance (aka Soft Memory Limit)

2019-09-24 Thread Dan Ackroyd
On Tue, 24 Sep 2019 at 08:01, Bishop Bettini wrote: > > Perhaps I am misunderstanding the scenario. Could you elaborate further, > perhaps provide a concrete example demonstrating where a parachute would be > needed? > For some things, catching exceptions so that other resources/locks can be rele

Re: [PHP-DEV] Shutdown Memory Allowance (aka Soft Memory Limit)

2019-09-24 Thread Dan Ackroyd
On Tue, 24 Sep 2019 at 07:26, Peter Stalman wrote: > > So I would like to suggest an option for setting a shutdown memory allowance, > which would be the amount of additional memory allowed to be used by any > registered error handlers or shutdown functions. I can see the need, and what problem y

Re: [PHP-DEV] PHP 7.4 BC break with openssl_random_pseudo_bytes()

2019-09-24 Thread Rowan Tommins
On Tue, 24 Sep 2019 at 15:26, Larry Garfield wrote: > And no, random_int(0,0) does what it says on the tin: return a random int > between 0 and 0. If you call it that way, well, it's your own PEBCAK. But > it throws an exception if the underlying sources of entropy are not working > for some re

Re: [PHP-DEV] PHP 7.4 BC break with openssl_random_pseudo_bytes()

2019-09-24 Thread Larry Garfield
On Mon, Sep 23, 2019, at 11:34 AM, Christian Schneider wrote: > Am 23.09.2019 um 17:16 schrieb Larry Garfield : > > I cannot speak for OpenSSL, but random_bytes() and random_int() were > > changed very late in the 7.0 cycle to throw exceptions so that they "fail > > closed". Otherwise if you ex

Re: [PHP-DEV] Shutdown Memory Allowance (aka Soft Memory Limit)

2019-09-24 Thread Peter Stalman
On Tue, Sep 24, 2019 at 12:01 AM Bishop Bettini wrote: > > On Tue, Sep 24, 2019 at 2:26 AM Peter Stalman wrote: >> >> When PHP runs out of memory, a fatal error is triggered and whatever shutdown >> functions or error handlers take over. >> >> However, in the case of error logging, or just loggin

[PHP-DEV] Re: RFCs should mention all BC breaks (was Re: [PHP-DEV] PHP 7.4 BC break with openssl_random_pseudo_bytes())

2019-09-24 Thread Christian Schneider
Am 24.09.2019 um 06:18 schrieb Pierre Joye : > On Mon, Sep 23, 2019 at 10:17 PM Larry Garfield > wrote: > >> I cannot speak for OpenSSL, but random_bytes() and random_int() were >> changed very late in the 7.0 cycle to throw exceptions so that they "fail >> closed". Otherwise if you expect a

Re: [PHP-DEV] Shutdown Memory Allowance (aka Soft Memory Limit)

2019-09-24 Thread Bishop Bettini
On Tue, Sep 24, 2019 at 2:26 AM Peter Stalman wrote: > When PHP runs out of memory, a fatal error is triggered and whatever > shutdown > functions or error handlers take over. > > However, in the case of error logging, or just logging in general, there > often > needs to be additional memory used