Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Nicolas Grekas
Le mer. 6 déc. 2017 à 20:50, Nikita Popov a écrit : > Hi internals, > > I'd like propose optional support for explicitly marking by-reference > argument passing at the call-site, in addition to the declaration-site: > > https://wiki.php.net/rfc/explicit_send_by_ref > > In short, while current

RE: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Zeev Suraski
> I'm sorry Stas, but I will not be reading your mails in the future. I think > you mean > well and do raise legitimate points, but I have noticed over a long period of > time > that I find arguing with you to be extremely mentally exhaustive, while > ultimately deriving very little actionable

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Stanislav Malyshev
Hi! > I'm referring to the compiler and optimizer here. Especially in > namespaced code we pretty much always don't have a hard guarantee on > what function will get called. This means that we have to generate code > that dynamically dispatches between by-val passing and by-ref passing > (this is

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Björn Larsson
Den 2019-07-30 kl. 00:27, skrev Björn Larsson: Den 2019-07-29 kl. 20:00, skrev Stephen Reay: On 29 Jul 2019, at 22:34, Rowan Collins wrote: I guess what I had in mind was that *in the long-term*, out/inout parameters would replace & parameters, Excuse my ignorance (presumably about the comple

Re: [PHP-DEV] Re: [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Björn Larsson
Den 2019-07-25 kl. 14:32, skrev Nikita Popov: On Wed, Dec 6, 2017 at 8:49 PM Nikita Popov wrote: Hi internals, I'd like propose optional support for explicitly marking by-reference argument passing at the call-site, in addition to the declaration-site: https://wiki.php.net/rfc/explicit_

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Björn Larsson
Den 2019-07-29 kl. 20:00, skrev Stephen Reay: On 29 Jul 2019, at 22:34, Rowan Collins wrote: I guess what I had in mind was that *in the long-term*, out/inout parameters would replace & parameters, Excuse my ignorance (presumably about the complexity involved) if this is obvious, but if out/i

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Nikita Popov
On Mon, Jul 29, 2019 at 11:05 PM Stanislav Malyshev wrote: > Hi! > > > This discussion seems to have lost track of the context ... the original > > quote (which Stas cherry-picked in a way that lost the original meaning): > > > >> I think nowadays it is well known that by-reference passing is to

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Stanislav Malyshev
Hi! > Do your teams actively remove direct calls to array_push() and > array_multisort()? In any case, I’m sure that most PHP developers don’t. > > > Yes: usually replaced by `[]` or wrappers of those functions that > de-reference the variables, so that no references are used. Again, by

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Stanislav Malyshev
Hi! > This discussion seems to have lost track of the context ... the original > quote (which Stas cherry-picked in a way that lost the original meaning): > >> I think nowadays it is well known that by-reference passing is to be > avoided and I don't see it particularly commonly in user code. By-

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Stephen Reay
> On 29 Jul 2019, at 22:34, Rowan Collins wrote: > > I guess what I had in mind was that *in the long-term*, > out/inout parameters would replace & parameters, Excuse my ignorance (presumably about the complexity involved) if this is obvious, but if out/inout parameters are considered to be

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Claude Pache
> Le 29 juil. 2019 à 16:40, Nikita Popov a écrit : > > > You seem to be agreeing with what I originally said: That by-reference > passing is mainly useful to interoperate with by-reference internal > functions, which don't exactly leave you with a choice. > To be clear: No, I’m not agreein

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Rowan Collins
On Mon, 29 Jul 2019 at 15:41, Nikita Popov wrote: > This proposal (at least combined with a declare that enforces use of > call-site annotations) addresses that concern. out/inout parameters do not > address this concern, because they are an mechanism that would be used *in > addition* to normal

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Nikita Popov
On Mon, Jul 29, 2019 at 10:40 AM Claude Pache wrote: > > > > Le 28 juil. 2019 à 21:12, Marco Pivetta a écrit : > > > > On Sun, Jul 28, 2019 at 9:06 PM Stanislav Malyshev > > wrote: > > > >> Hi! > >> > >>> Nah, by-ref is pretty much avoided in OSS packages, but we can surely > >>> survey the eco

Re: [PHP-DEV] Re: [RFC] Namespace-scoped declares, again

2019-07-29 Thread Michał Brzuchalski
Hi, niedz., 28 lip 2019 o 05:17 Stanislav Malyshev napisał(a): > > Based on the received feedback, I plan to change this proposal from being > > "namespace-scoped" to being "directory-scoped" instead. This should both > > I don't think it improves much, in my opinion, and it also introduces > ha

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Marco Pivetta
On Mon, Jul 29, 2019, 10:40 Claude Pache wrote: > > > > Le 28 juil. 2019 à 21:12, Marco Pivetta a écrit : > > > > On Sun, Jul 28, 2019 at 9:06 PM Stanislav Malyshev > > wrote: > > > >> Hi! > >> > >>> Nah, by-ref is pretty much avoided in OSS packages, but we can surely > >>> survey the ecosyste

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2019-07-29 Thread Claude Pache
> Le 28 juil. 2019 à 21:12, Marco Pivetta a écrit : > > On Sun, Jul 28, 2019 at 9:06 PM Stanislav Malyshev > wrote: > >> Hi! >> >>> Nah, by-ref is pretty much avoided in OSS packages, but we can surely >>> survey the ecosystem to verify this. >> >> I literally work with code that uses refe

Re: [PHP-DEV] Merging fuzzing SAPI into core

2019-07-29 Thread Nikita Popov
On Mon, Jul 29, 2019 at 2:48 AM Stanislav Malyshev wrote: > Hi! > > As you probably know, we've been running PHP fuzzing under Google's > OSS-Fuzz[1] project for a while now (and found and fixed some bugs due > to it). > > This has been enabled by the PHP fuzzing API SAPI[2] which currently > liv