Re: [PHP-DEV] [RFC] Strict operators directive

2019-07-09 Thread Nikita Popov
On Tue, Jun 25, 2019 at 3:10 PM Arnold Daniels wrote: > Hi all, > > I would like to open the discussion for RFC: "Strict operators directive". > > This RFC proposes a new directive 'strict_operators'. When enabled, > operators may cast operands to the expected type, but must comply to; > > * Type

Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.4

2019-07-09 Thread Nikita Popov
On Tue, Jul 9, 2019 at 3:22 PM Claude Pache wrote: > > Le 8 juil. 2019 à 21:27, Nikita Popov a écrit : > > Hi internals, > > I've opened voting on the deprecations for PHP 7.4 RFC: > https://wiki.php.net/rfc/deprecations_php_7_4 > > As usual, each deprecation has it's own vote and requires its o

Re: [PHP-DEV] [VOTE] Deprecations for PHP 7.4

2019-07-09 Thread Claude Pache
> Le 8 juil. 2019 à 21:27, Nikita Popov a écrit : > > Hi internals, > > I've opened voting on the deprecations for PHP 7.4 RFC: > https://wiki.php.net/rfc/deprecations_php_7_4 > > As usual, each deprecation has it's own vote and requires its own, > independent 2/3 majority to pass. Voting clos

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Stephen Reay
> On 9 Jul 2019, at 17:06, Christian Schneider wrote: > > When you drop the declaration on top of the file the semantics of your > operators suddenly change, e.g. > "42" < "7" > changes from true to false and you get subtle bugs. If you OPT IN to strict operators, the onus is on you to

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Arnold Daniels
On Tue, Jul 9, 2019 at 12:22 PM Claude Pache wrote: > > > > Le 9 juil. 2019 à 12:09, Andreas Heigl a écrit : > > > > > > > > Am 09.07.19 um 12:06 schrieb Christian Schneider: > >> Am 09.07.2019 um 11:30 schrieb Marco Pivetta : > >>> I wasn't sure about the full implications of this, but after so

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Claude Pache
> Le 9 juil. 2019 à 12:09, Andreas Heigl a écrit : > > > > Am 09.07.19 um 12:06 schrieb Christian Schneider: >> Am 09.07.2019 um 11:30 schrieb Marco Pivetta : >>> I wasn't sure about the full implications of this, but after some thought, >>> the worst that can happen is excessive strictness,

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Nikita Popov
On Tue, Jul 9, 2019 at 9:19 AM CHU Zhaowei wrote: > Although I like this idea, I'm wondering if such a big change should go > for php 8 instead of 7.4. > > Regards, CHU Zhaowei > Right. I really wouldn't want to merge this kind of large change on the very day of feature freeze. I would feel a l

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Marco Pivetta
On Tue, Jul 9, 2019, 12:06 Christian Schneider wrote: > Am 09.07.2019 um 11:30 schrieb Marco Pivetta : > > I wasn't sure about the full implications of this, but after some > thought, > > the worst that can happen is excessive strictness, requiring to drop a > > single declaration on top of a fil

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Andreas Heigl
Am 09.07.19 um 12:06 schrieb Christian Schneider: > Am 09.07.2019 um 11:30 schrieb Marco Pivetta : >> I wasn't sure about the full implications of this, but after some thought, >> the worst that can happen is excessive strictness, requiring to drop a >> single declaration on top of a file 👍 > >

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Christian Schneider
Am 09.07.2019 um 11:30 schrieb Marco Pivetta : > I wasn't sure about the full implications of this, but after some thought, > the worst that can happen is excessive strictness, requiring to drop a > single declaration on top of a file 👍 When you drop the declaration on top of the file the semantic

Re: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread Marco Pivetta
On Tue, Jul 9, 2019, 03:56 Arnold Daniels wrote: > Hi internals, > > I've opened voting on the strict operators directive: > https://wiki.php.net/rfc/strict_operators > > As promised, a patch and tests have been prepared. This is available on > https://github.com/php/php-src/pull/4375 > > Regards

Re: [PHP-DEV] [VOTE] Voting opens for str_starts_with and ends_with functions

2019-07-09 Thread Claude Pache
> Le 9 juil. 2019 à 09:40, Peter Bowyer a écrit : > > On Mon, 8 Jul 2019 at 19:09, Björn Larsson > wrote: > >> Having this _ci postfix is a new way of indicating case insensitivity. >> I think that it might add to negative votes. Personally I think it's a >> good idea to mimic existing ways

Re: [PHP-DEV] [VOTE] Voting opens for str_starts_with and ends_with functions

2019-07-09 Thread Peter Bowyer
On Mon, 8 Jul 2019 at 19:09, Björn Larsson wrote: > Having this _ci postfix is a new way of indicating case insensitivity. > I think that it might add to negative votes. Personally I think it's a > good idea to mimic existing ways, even if they are a bit awkward. > > How about using a flag or fo

RE: [PHP-DEV] [VOTE] Strict operators directive

2019-07-09 Thread CHU Zhaowei
Although I like this idea, I'm wondering if such a big change should go for php 8 instead of 7.4. Regards, CHU Zhaowei > -Original Message- > From: Arnold Daniels > Sent: Tuesday, July 9, 2019 9:56 AM > To: PHP Internals > Subject: [PHP-DEV] [VOTE] Strict operators directive > > Hi i