Re: [PHP-DEV] [RFC] Escape PDO "?" parameter placeholder

2019-07-02 Thread Matteo Beccati
Hi Nikita, On 02/07/2019 15:07, Nikita Popov wrote: > Friendly reminder that this RFC needs to go into voting until Monday > (preferably earlier) to make it into 7.4. Thanks! Without the reminder, I would probably have missed it. > Here's my feedback: > > * I would prefer to make escaping not

Re: [PHP-DEV] [RFC] [Vote] Base convert changes

2019-07-02 Thread Nikita Popov
On Mon, Jul 1, 2019 at 4:09 PM Scott Dutton wrote: > Hi all > > I have made a PR for 7.4 for just the ignoring invalid input. I will > open a similar one for PHP 8. > > https://github.com/php/php-src/pull/4328 > > All tests have been fixed for linux, there is one failure for windows > which I am

Re: [PHP-DEV] [RFC] Escape PDO "?" parameter placeholder

2019-07-02 Thread Nikita Popov
On Tue, Jul 2, 2019 at 4:42 PM Thomas Hruska wrote: > On 7/2/2019 6:07 AM, Nikita Popov wrote: > > that it also exists elsewhere). The RFC argues against this because it > > makes writing a literal \? harder (which would be ?), but I think > that > > \\? should result in the correct string.

Re: [PHP-DEV] [RFC] Escape PDO "?" parameter placeholder

2019-07-02 Thread Thomas Hruska
On 7/2/2019 6:07 AM, Nikita Popov wrote: that it also exists elsewhere). The RFC argues against this because it makes writing a literal \? harder (which would be ?), but I think that \\? should result in the correct string. ? adds in an extra backslash. -- Thomas Hruska CubicleSoft Pr

Re: [PHP-DEV] [RFC] Escape PDO "?" parameter placeholder

2019-07-02 Thread Nikita Popov
On Fri, May 31, 2019 at 1:27 PM Matteo Beccati wrote: > Hi everyone, > > following some recent unrest in the comments of the related PR, I've > decided to invest a bit of time on it and finally move it to draft status: > > https://wiki.php.net/rfc/pdo_escape_placeholders > > The PR is currently c