Re: [PHP-DEV] [RFC] Allow throwing exceptions from __toString()

2019-04-30 Thread Bishop Bettini
On Tue, Apr 30, 2019 at 2:49 PM Stanislav Malyshev wrote: > > That said, the work done on the patch is super impressive. I am > reasonably sure that Nikita caught as many instances of something going > wrong when string conversion fails as humanly possible. And I agree that > banning exceptions d

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Mark Randall
On 01/05/2019 01:19, Peter Kokot wrote: I haven't seen code with short tags for such a long time now that this is for me a problem on a scale of a fly. Because we've simply upgraded all very very long time ago or in other words even never thought of writing something in these tags anymore. I t

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Peter Kokot
On Wed, 1 May 2019 at 00:56, Stanislav Malyshev wrote: > > Hi! > > > Worth noting another inconsistency here that we've missed. PHP 7.4 has > > introduced many BC breaks actually already. Without this level of > > problems: > > Exactly, without. There's a difference between removing an unmaintaine

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-30 Thread Bishop Bettini
On Tue, Apr 30, 2019, 19:14 Theodore Brown On Tue, Apr 30, 2019 at 3:59 PM Bishop Bettini wrote: > > > Excellent. I hope we can make the case this time. Please > > request Wiki karma [1], and we'll iterate on it there. > > I was granted karma, and published an initial RFC draft: > https://wiki.ph

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Stanislav Malyshev
Hi! > Worth noting another inconsistency here that we've missed. PHP 7.4 has > introduced many BC breaks actually already. Without this level of > problems: Exactly, without. There's a difference between removing an unmaintained extension which is barely used and setting people up for displaying

[PHP-DEV] [RFC] [Vote] Change the precedence of the concatenation operator

2019-04-30 Thread Bob Weinand
Hey, As announced yesterday, I'm now starting the vote on this RFC. I'm confident that the impact is really that minimal that a relatively quick deprecation and change path is preferred. https://wiki.php.net/rfc/concatenation_precedence The vote ends on May 15. Thanks, Bob

[PHP-DEV] Re: Wiki RFC karma request

2019-04-30 Thread Christoph M. Becker
On 30.04.2019 at 23:51, Theodore Brown wrote: > Hi, I'd like to resurrect the RFC for underscore separators in numeric > literals. Could someone grant me the necessary wiki karma? My username is > theodorejb. You should have rfc karma. Best of luck with the RFC! -- Christoph M. Becker -- PHP

[PHP-DEV] Wiki RFC karma request

2019-04-30 Thread Theodore Brown
Hi, I'd like to resurrect the RFC for underscore separators in numeric literals. Could someone grant me the necessary wiki karma? My username is theodorejb. Thanks, Theodore Brown -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-30 Thread Bishop Bettini
On Tue, Apr 30, 2019 at 4:41 PM Theodore Brown wrote: > On Mon, Apr 29, 2019 at 2:33 AM Bishop Bettini wrote: > > > Well said. > > > > One need not agree with an implementation to appreciate the improved > > readability. > > > > If you'd like to re-open this for voting, I'm able to assist with >

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-30 Thread Theodore Brown
On Mon, Apr 29, 2019 at 2:33 AM Bishop Bettini wrote: > Well said. > > One need not agree with an implementation to appreciate the improved > readability. > > If you'd like to re-open this for voting, I'm able to assist with > the RFC process and any code changes. Thanks! I drafted a preliminary

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Bishop Bettini
On Wed, Apr 24, 2019 at 8:19 PM Michael Kliewe wrote: > Some random thoughts: > - What happens to .phar files? Do we have to scan the contents? > Phar relies upon the engine's tokenizer. If your phar build script uses createDefaultStub('index.php'); $phar->setStub($stub); $ php -d phar.

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Peter Kokot
Hello, On Tue, 30 Apr 2019 at 20:25, Zeev Suraski wrote: > > On Tue, Apr 30, 2019 at 8:14 PM Derick Rethans wrote: > > > On Mon, 29 Apr 2019, Zeev Suraski wrote: > > > > > On Sun, Apr 28, 2019 at 11:32 PM G. P. B. > > wrote: > > > > > > > I think this just boils down to what is an acceptable ma

Re: [PHP-DEV] POC: Docker container with support for PHP and Nginx based on Debian Stretch

2019-04-30 Thread Peter Cowburn
Hi Jan, On Tue, 30 Apr 2019 at 19:51, Jan Malaník wrote: > Hi, > I'd like to introduce new variant of PHP Docker image with support for > Nginx webserver based on Debian Stretch. > I'm not sure if this is managed by you. The Docker "Official image" for PHP is not maintained by the PHP Project.

[PHP-DEV] POC: Docker container with support for PHP and Nginx based on Debian Stretch

2019-04-30 Thread Jan Malaník
Hi, I'd like to introduce new variant of PHP Docker image with support for Nginx webserver based on Debian Stretch. I'm not sure if this is managed by you. Can you please review the PR and give me comments? https://github.com/docker-library/php/pull/821 Thank you Jan

Re: [PHP-DEV] [RFC] Allow throwing exceptions from __toString()

2019-04-30 Thread Stanislav Malyshev
Hi! > Please could someone anyone who understands the implications for what > this means for the internals of the PHP engine provide some detailed > reasons for why this shouldn't be approved, if there are any reasons. > > Otherwise voters might 'irresponsibly' vote yes, without being aware of th

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread M. W. Moe
Hello, a bit of fuzz; no need having a dramatic posture either; php RFC system needs to be matured; the same way than c++ fellowship (I don't say it was without dramas over the years); in my opinion there are two many of them opened at the same time; some targets strictly the userspace; some langu

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Zeev Suraski
On Tue, Apr 30, 2019 at 8:14 PM Derick Rethans wrote: > On Mon, 29 Apr 2019, Zeev Suraski wrote: > > > On Sun, Apr 28, 2019 at 11:32 PM G. P. B. > wrote: > > > > > I think this just boils down to what is an acceptable majority, if > > > 2/3 is not enough then 3/4 but this is another debate altog

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Stanislav Malyshev
Hi! > Why the hell should I start compromising with someone who thinks the > project, and by > extensions the contributors to the project small or large, don't behave > responsibly?! Without getting into generalities about all contributors over all the project lifetime, I personally think what ha

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Zeev Suraski
On Tue, Apr 30, 2019 at 7:03 PM Levi Morrison wrote: > On Tue, Apr 30, 2019 at 9:01 AM Zeev Suraski wrote: > > > > On Tue, Apr 30, 2019 at 2:14 PM G. P. B. > wrote: > > > > > On Mon, 29 Apr 2019 at 16:53, Zeev Suraski wrote: > > > > > >> On Mon, Apr 29, 2019 at 5:19 PM Dan Ackroyd > > >> wrot

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Matteo Beccati
Hi Björn, On 24/04/2019 23:12, Björn Larsson wrote: > I did a quick check on two open source libraries that I'm using, > namely Smarty templating library and Revive ad server. A quick > glance at hand shows that they both uses the latest release. Smarty 3.1.33 was released 17/9 2018 and > Revive

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Derick Rethans
On Mon, 29 Apr 2019, Zeev Suraski wrote: > On Sun, Apr 28, 2019 at 11:32 PM G. P. B. wrote: > > > I think this just boils down to what is an acceptable majority, if > > 2/3 is not enough then 3/4 but this is another debate altogether. > > > > I've argued in the past that it would make sense to

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Levi Morrison
On Tue, Apr 30, 2019 at 9:01 AM Zeev Suraski wrote: > > On Tue, Apr 30, 2019 at 2:14 PM G. P. B. wrote: > > > On Mon, 29 Apr 2019 at 16:53, Zeev Suraski wrote: > > > >> On Mon, Apr 29, 2019 at 5:19 PM Dan Ackroyd > >> wrote: > >> > Please stop doing this. > >> > >> I will gladly do so, once the

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread Zeev Suraski
On Tue, Apr 30, 2019 at 2:14 PM G. P. B. wrote: > On Mon, 29 Apr 2019 at 16:53, Zeev Suraski wrote: > >> On Mon, Apr 29, 2019 at 5:19 PM Dan Ackroyd >> wrote: >> > Please stop doing this. >> >> I will gladly do so, once the project starts behaving responsibly again. >> > > Honnestly, this comme

Re: [PHP-DEV] [RFC] Allow throwing exceptions from __toString()

2019-04-30 Thread Dan Ackroyd
On Tue, 30 Apr 2019 at 14:33, Nikita Popov wrote: > > Hi internals, > > I've already brought up this topic on list a couple of weeks ago... I've > now updated the implementation based on feedback at the time, and turned > this into a proper RFC: This RFC is probably beyond the capabilities of mos

[PHP-DEV] [RFC] Allow throwing exceptions from __toString()

2019-04-30 Thread Nikita Popov
Hi internals, I've already brought up this topic on list a couple of weeks ago... I've now updated the implementation based on feedback at the time, and turned this into a proper RFC: https://wiki.php.net/rfc/tostring_exceptions Regards, Nikita

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-30 Thread G. P. B.
On Mon, 29 Apr 2019 at 16:53, Zeev Suraski wrote: > On Mon, Apr 29, 2019 at 5:19 PM Dan Ackroyd > wrote: > > Please stop doing this. > > I will gladly do so, once the project starts behaving responsibly again. > Honnestly, this comment right here Zeev just makes me want to not compromise at all