RE: [PHP-DEV] TCO: Tail Call Optimization

2019-04-29 Thread CHU Zhaowei
Hi David, TCO modifies the call stack, which means features relying on it are not reliable any more, e.g. debug_backtrace, stack trace of an exception, etc. As a result, ES6 only ask to enable TCO in strict mode, which dropped support for func.arguments and func.caller. PHP don't have similar

Re: [PHP-DEV] [RFC] Change the precedence of the concatenation operator

2019-04-29 Thread Niklas Keller
Am Mo., 29. Apr. 2019 um 09:03 Uhr schrieb Bob Weinand : > > > Am 25.04.2019 um 11:52 schrieb Nikita Popov > mailto:nikita@gmail.com>>: > > On Thu, Mar 28, 2019 at 2:33 PM Bob Weinand > mailto:bobw...@hotmail.com>> wrote: > Hey, > > I feel like concatenation having the same precedence than ad

Re: [PHP-DEV] Don't silence chr function arguments error

2019-04-29 Thread Sara Golemon
On Mon, Apr 29, 2019 at 2:37 AM Nikita Popov wrote: > > The idea is to merge in PHP-7.4, but if there's a consensus that this >> > should go into PHP 8 only, so it is :) >> > >> > Technically a BC break, so 8.0 would be the preferred branch IMO. >> > > As this would be a TypeError on 8.0, I think

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-29 Thread Zeev Suraski
On Mon, Apr 29, 2019 at 5:19 PM Dan Ackroyd wrote: > On Mon, 29 Apr 2019 at 13:29, Zeev Suraski wrote: > > > > If we go in this direction, though, then unless George agrees to withdraw > >this RFC > > Zeev, > > I do not think you behaviour is appropriate. > > It's not appropriate to put pressure

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-29 Thread Zeev Suraski
On Mon, Apr 29, 2019 at 5:26 PM Zeev Suraski wrote: > > ... wholesale compatibility break-fast ... > * break-fest

[PHP-DEV] Re: Issuing CVEs for PHP

2019-04-29 Thread Lior Kaplan
On Mon, Apr 29, 2019 at 6:51 AM Stanislav Malyshev wrote: > Hi! > > I have set up PHP as CNA (CVE Identifiers authority) with MITRE. That > means that we will be assigning our own CVEs from now on. The process in > broad strokes works like this: > > 1. We request a block of numbers > 2. When we h

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-29 Thread Dan Ackroyd
On Mon, 29 Apr 2019 at 13:29, Zeev Suraski wrote: > > If we go in this direction, though, then unless George agrees to withdraw >this RFC Zeev, I do not think you behaviour is appropriate. It's not appropriate to put pressure on an RFC author to withdraw an RFC after it has been voted on. It's

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-29 Thread Zeev Suraski
On Mon, Apr 29, 2019 at 11:17 AM Nikita Popov wrote: > > Keep in mind that for example the FFI RFC passed with something like 60% > majority, even lower than this RFC. I think you're cherry-picking a bit > here, when it comes to what should and shouldn't pass ;) > You're right, but I think that'

Re: [PHP-DEV] [RFC] Change the precedence of the concatenation operator

2019-04-29 Thread Clint Priest
Nikita, I'm a bit worried that using this as a standard test suite may (repeatedly?) give us a false sense of security to go ahead with compatibility breaking changes. Composer packages, almost by definition - tend to be of higher quality than the 'average' PHP code (at the very least they're

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-29 Thread Lester Caine
On 29/04/2019 09:01, Zeev Suraski wrote: It's absolutely fine to dislike short tags. It's absolutely fine to believe it shouldn't have been introduced. But the gap between that, and thinking it's fine to remove it - is very, very big. And how long after it's removed will 'https://lsces.co.uk/

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-29 Thread Nikita Popov
On Sun, Apr 28, 2019 at 10:02 AM Zeev Suraski wrote: > On Wed, Apr 24, 2019 at 9:08 PM Reinis Rozitis wrote: > > > Also imo the reason why people write now (and not in the discussion > > phase) because for some time in the voting there wasn't the 2/3 majority > > for the 7.4 (so no sense to clu

Re: [PHP-DEV] [RFC] Change the precedence of the concatenation operator

2019-04-29 Thread Zeev Suraski
On Mon, Apr 29, 2019 at 10:55 AM Nikita Popov wrote: > On Mon, Apr 29, 2019 at 9:34 AM Zeev Suraski wrote: > > > > > > > On Thu, Apr 25, 2019 at 12:52 PM Nikita Popov > > wrote: > > > >> On Thu, Mar 28, 2019 at 2:33 PM Bob Weinand > wrote: > >> > >> > Hey, > >> > > >> > I feel like concatenati

Re: [PHP-DEV] [RFC] [VOTE] Deprecate PHP's short open tags

2019-04-29 Thread Zeev Suraski
On Sun, Apr 28, 2019 at 11:32 PM G. P. B. wrote: > On Sun, 28 Apr 2019 at 14:36, Zeev Suraski wrote: > >> As I said numerous times in the past, I'm a firm believer that controversial RFCs (ones that generate a lot of votes with a substantial number of opposers) should not pass. I thin

Re: [PHP-DEV] [RFC] Change the precedence of the concatenation operator

2019-04-29 Thread Nikita Popov
On Mon, Apr 29, 2019 at 9:34 AM Zeev Suraski wrote: > > > On Thu, Apr 25, 2019 at 12:52 PM Nikita Popov > wrote: > >> On Thu, Mar 28, 2019 at 2:33 PM Bob Weinand wrote: >> >> > Hey, >> > >> > I feel like concatenation having the same precedence than addition and >> > subtraction is promoting pr

Re: [PHP-DEV] Don't silence chr function arguments error

2019-04-29 Thread Nikita Popov
On Mon, Apr 29, 2019 at 3:44 AM Sara Golemon wrote: > On Sun, Apr 28, 2019 at 6:05 PM Gabriel Caruso > wrote: > > > Currently, if you pass an argument that is not an integer, it will simply > > return an empty string: https://3v4l.org/FF2nA. > > > Not entirely accurate. It outputs a one-characte

Re: [PHP-DEV] [RFC] Change the precedence of the concatenation operator

2019-04-29 Thread Zeev Suraski
On Thu, Apr 25, 2019 at 12:52 PM Nikita Popov wrote: > On Thu, Mar 28, 2019 at 2:33 PM Bob Weinand wrote: > > > Hey, > > > > I feel like concatenation having the same precedence than addition and > > subtraction is promoting programmers to make mistakes. Albeit typically > > easy to catch ones,

Re: [PHP-DEV] Revive Number Format Separator RFC

2019-04-29 Thread Bishop Bettini
On Sun, Apr 28, 2019 at 1:47 PM Theodore Brown wrote: > On Sat, Apr 27, 2019 at 10:25 PM Stanislav Malyshev > wrote: > > > I am not exactly against this feature, but the potential for abuse > > \- like enabling people using integers for things that are not > > integers and should not be stored a

Re: [PHP-DEV] [RFC] Change the precedence of the concatenation operator

2019-04-29 Thread Bob Weinand
Am 25.04.2019 um 11:52 schrieb Nikita Popov mailto:nikita@gmail.com>>: On Thu, Mar 28, 2019 at 2:33 PM Bob Weinand mailto:bobw...@hotmail.com>> wrote: Hey, I feel like concatenation having the same precedence than addition and subtraction is promoting programmers to make mistakes. Albeit