Re: [PHP-DEV] [RFC] Saner string to number comparisons

2019-02-26 Thread Dmitry Stogov
Hi Nikita, Yeah, this is a big BC break, but I think, it's a good time to make some "cleanup" in PHP-8. The only thing, I don't like is a difference between leading and trailing spaces. They should behave in the same way. Thanks. Dmitry. From: Nikita Popov

Re: [PHP-DEV] [RFC][Vote] Weakrefs

2019-02-26 Thread Sebastian Bergmann
Am 26.02.2019 um 21:37 schrieb Marco Pivetta: Just posting to clarify on my "No" vote: I am generally against having more features that (by design) introduce spooky action as a distance behavior, especially on references. I voted "No" for similar reasons. -- PHP Internals - PHP Runtime Develop

Re: [PHP-DEV] [RFC][Vote] Weakrefs

2019-02-26 Thread Marco Pivetta
Hi Joe, On Fri, Feb 22, 2019 at 12:54 PM Joe Watkins wrote: > Morning all, > > The vote for weakrefs is open: https://wiki.php.net/rfc/weakrefs > > Cheers > Joe > Just posting to clarify on my "No" vote: I am generally against having more features that (by design) introduce spooky action as a d

[PHP-DEV] Re: [RFC] New custom object serialization mechanism

2019-02-26 Thread Nikita Popov
On Tue, Feb 19, 2019 at 11:42 AM Nicolas Grekas < nicolas.grekas+...@gmail.com> wrote: > > > Le mar. 19 févr. 2019 à 11:31, Nikita Popov a > écrit : > >> On Mon, Feb 18, 2019 at 4:12 PM Nicolas Grekas < >> nicolas.grekas+...@gmail.com> wrote: >> >>> Hi Nikita, >>> >>> I'd like to propose a new cu

Re: [PHP-DEV] [RFC] Saner string to number comparisons

2019-02-26 Thread Rowan Collins
On 26 February 2019 13:26:24 GMT+00:00, Nikita Popov wrote: >I'm mentioning this, because it is a precedent for tweaking the string >to >string numeric comparison rules to prevent unexpected and possibly >security >critical equalities. I think we could add similar special handling for >the >"0eNN

Re: [PHP-DEV] [RFC] Saner string to number comparisons

2019-02-26 Thread Nikita Popov
On Tue, Feb 26, 2019 at 2:06 PM Rowan Collins wrote: > On Tue, 26 Feb 2019 at 12:27, Nikita Popov wrote: > > > I'd like to bring forward an RFC for PHP 8 to change the semantics of == > > and other non-strict comparisons, when used between a number and a > string: > > > > https://wiki.php.net/rf

Re: [PHP-DEV] [RFC] Saner string to number comparisons

2019-02-26 Thread Rowan Collins
On Tue, 26 Feb 2019 at 12:27, Nikita Popov wrote: > I'd like to bring forward an RFC for PHP 8 to change the semantics of == > and other non-strict comparisons, when used between a number and a string: > > https://wiki.php.net/rfc/string_to_number_comparison > Hi Nikita, Thanks for tackling th

Re: [PHP-DEV] [RFC] Saner string to number comparisons

2019-02-26 Thread G. P. B.
On Tue, 26 Feb 2019 at 13:27, Nikita Popov wrote: > Hi internals, > > I think it is well known that == in PHP is a pretty big footgun. It doesn't > have to be. I think that type juggling comparisons in a language like PHP > have some merit, it's just that the particular semantics of == in PHP mak

[PHP-DEV] [RFC] Saner string to number comparisons

2019-02-26 Thread Nikita Popov
Hi internals, I think it is well known that == in PHP is a pretty big footgun. It doesn't have to be. I think that type juggling comparisons in a language like PHP have some merit, it's just that the particular semantics of == in PHP make it so dangerous. The biggest WTF factor is probably that 0