[PHP-DEV] setcookie() doesn't follow the RFC in 7.3

2018-09-19 Thread Nicolas Grekas
Hi all, yesterday I submitted https://bugs.php.net/76906 to report that I wasn't able to set the "samesite" attribute on cookies while I followed what's been approved in https://wiki.php.net/rfc/same-site-cookie Damian answered on the bug report that the $options argument has swallowed the lifeti

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Christian Stoller
> -Ursprüngliche Nachricht- > Von: Rowan Collins > Gesendet: Mittwoch, 19. September 2018 23:47 > An: PHP Internals List > Betreff: Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2 > > On 19/09/2018 22:30, Marco Pivetta wrote: > > > > At least the approach without nullable properties will lea

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Marco Pivetta
On Wed, Sep 19, 2018 at 11:46 PM Rowan Collins wrote: > On 19/09/2018 22:30, Marco Pivetta wrote: > > > > At least the approach without nullable properties will lead to a > > Throwable when a read is attempted on an uninitialized object, which > > is still better than nullability checks all over

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Rowan Collins
On 19/09/2018 22:30, Marco Pivetta wrote: At least the approach without nullable properties will lead to a Throwable when a read is attempted on an uninitialized object, which is still better than nullability checks all over the place. Is it? Doesn't it just mean writing this: try {     so

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Marco Pivetta
On Wed, Sep 19, 2018 at 11:17 PM Rowan Collins wrote: > On 19/09/2018 21:04, Levi Morrison wrote: > > I think this code should be allowed: > > > > class User { > > public int $id; > > public string $preferred_name; > > public string $username; > > } > > Why? Wh

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Rowan Collins
On 19/09/2018 21:04, Levi Morrison wrote: I think this code should be allowed: class User { public int $id; public string $preferred_name; public string $username; } Why? What contract is being enforced by that class that is not enforced by this class?

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Levi Morrison
On Wed, Sep 19, 2018 at 1:06 PM Rasmus Schultz wrote: > > On Wed, Sep 19, 2018 at 7:43 PM Rowan Collins wrote: > > > I agree that this is a hard problem, but I don't agree that this decision > > is being made "for now". If we allow "non-nullable but uninitialized" > > properties now, it will be e

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Rasmus Schultz
On Wed, Sep 19, 2018 at 7:43 PM Rowan Collins wrote: > I agree that this is a hard problem, but I don't agree that this decision > is being made "for now". If we allow "non-nullable but uninitialized" > properties now, it will be extremely hard to change their behaviour in > future. I'm with Row

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Rowan Collins
On Wed, 19 Sep 2018 at 16:57, Levi Morrison wrote: > I posit that this code: > > class Foo { > public Foo $foo; > } > > Is superior to this code: > > class Foo { > public ?Foo $foo = null; > } > > If after "initialization" that `$foo` is guaranteed to always contai

Re: [PHP-DEV] Unbundle libsqlite3?

2018-09-19 Thread BohwaZ
On Wed, 19 Sep 2018 19:41:11 +0200 / "Christoph M. Becker" said : > PR #2698[2] seems to require an RFC. IMHO, it's best to present RFCs > and voting on them as early as possible (instead of rushing them at > the last moment). :) Yeah there was an RFC and it was voted no: https://wiki.php.net/r

Re: [PHP-DEV] Unbundle libsqlite3?

2018-09-19 Thread Christoph M. Becker
On 19.09.2018 at 18:53, BohwaZ wrote: > On Mon, 17 Sep 2018 15:16:13 +0200 / "Christoph M. Becker" > said : > >> ext/sqlite3 requires libsqlite ≥ 3.3.9[1] which has been released on >> 2007-01-04[2] (i.e. more than eleven years ago!). ext/pdo_sqlite has >> no specific version requirement; there

Re: [PHP-DEV] Unbundle libsqlite3?

2018-09-19 Thread BohwaZ
On Mon, 17 Sep 2018 15:16:13 +0200 / "Christoph M. Becker" said : > Hi! > > We bundle an unmodified libsqlite3 for at least two years. Since then > all updates go into any dev, alpha and beta releases, while security > patches (usually backports from libsqlite3) go into stable branches. > > ex

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Levi Morrison
On Wed, Sep 19, 2018 at 6:38 AM Rowan Collins wrote: > > On Tue, 11 Sep 2018 at 08:05, Bob Weinand wrote: > > > Hey, > > > > As announced, we are starting the vote on typed properties today. > > > > The voting period is two weeks, until sometime in the evening on Tuesday > > 25-09-2018. > > > > P

Re: [PHP-DEV] [RFC] [VOTE] Typed properties v2

2018-09-19 Thread Rowan Collins
On Tue, 11 Sep 2018 at 08:05, Bob Weinand wrote: > Hey, > > As announced, we are starting the vote on typed properties today. > > The voting period is two weeks, until sometime in the evening on Tuesday > 25-09-2018. > > Please find the RFC at https://wiki.php.net/rfc/typed_properties_v2. > For

[PHP-DEV] RFC Vote: Make the hash extension always available

2018-09-19 Thread Kalle Sommer Nielsen
Hi After a two week period without any objections to the RFC, I have gone ahead of opening the voting polls for making the hash extension a permanent part of PHP. RFC: https://wiki.php.net/rfc/permanent_hash_ext Vote: https://wiki.php.net/rfc/permanent_hash_ext#vote This vote will run for two we