Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Levi Morrison
On Mon, Feb 5, 2018 at 9:54 AM, Benjamin Eberlei wrote: > On Sun, Feb 4, 2018 at 10:56 PM, Stanislav Malyshev > wrote: > >> Hi! >> >> > To get the same benefits (jit and such) wouldn't it be better to >> introduce >> > a "use function root;" or similar statement or a declare() to specify >> this

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Benjamin Eberlei
On Sun, Feb 4, 2018 at 10:56 PM, Stanislav Malyshev wrote: > Hi! > > > To get the same benefits (jit and such) wouldn't it be better to > introduce > > a "use function root;" or similar statement or a declare() to specify > this > > file imports all root functions? > > We already have this right

[PHP-DEV] [RFC][DISCUSSION] Argon2id in Password Hash

2018-02-05 Thread Charles R. Portwood II
Hello Internals, I would like to propose adding Argon2id to the password_* functions in PHP 7.3. An RFC[1] has been prepared which covers implementation details, and some common questions & concerns that I have anticipated. This RFC also includes a tested and working implementation[2] to illustra

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Marco Pivetta
On Mon, Feb 5, 2018 at 3:39 PM, Michael Morris wrote: > > > On Mon, Feb 5, 2018 at 8:33 AM, Marco Pivetta wrote: > >> >> On Mon, Feb 5, 2018 at 3:28 PM, Michael Morris >> wrote: >> >>> The problem is that behavior has been around so long that any attempt to >>> change it would incur a massive a

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Michael Morris
On Mon, Feb 5, 2018 at 8:33 AM, Marco Pivetta wrote: > > On Mon, Feb 5, 2018 at 3:28 PM, Michael Morris wrote: > >> The problem is that behavior has been around so long that any attempt to >> change it would incur a massive amount of changes. Using the E_STRICT >> notice level instead of E_DEPRE

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Marco Pivetta
On Mon, Feb 5, 2018 at 3:28 PM, Michael Morris wrote: > The problem is that behavior has been around so long that any attempt to > change it would incur a massive amount of changes. Using the E_STRICT > notice level instead of E_DEPRECATED has been floated as one fix for this, > but this doesn't

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Michael Morris
May I propose a compromise? If I understand what I've read over, the default of functions and constants to global scope is the primary blocking issue for creating an autoloader for these elements. Where that not PHP's behavior this functionality could have been implemented by now. The problem is

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Christoph M. Becker
On 04.02.2018 at 22:56, Stanislav Malyshev wrote: >> To get the same benefits (jit and such) wouldn't it be better to introduce >> a "use function root;" or similar statement or a declare() to specify this >> file imports all root functions? > > We already have this right now, […] Do we? AFAIK,

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Rowan Collins
On 5 February 2018 at 12:54, Marco Pivetta wrote: > On Mon, Feb 5, 2018 at 1:52 PM, Rowan Collins > wrote: > >> None of these options is particularly appealing, and this will all be for >> a >> hypothetical future improvement to the language. >> > > Would proposing a function autoloading RFC tog

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Marco Pivetta
On Mon, Feb 5, 2018 at 1:52 PM, Rowan Collins wrote: > None of these options is particularly appealing, and this will all be for a > hypothetical future improvement to the language. > Would proposing a function autoloading RFC together with this improve the situation? Marco Pivetta http://twit

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Rowan Collins
On 5 February 2018 at 10:53, Marco Pivetta wrote: > > See https://externals.io/message/101745#101752 > > The problem is always with routines (not functions)) that rely on shared > global mutable state. > > Mocking those is generally a problem, as it exposes a dependency inversion > issue, rather

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Marco Pivetta
Hey Ivan, On 5 Feb 2018 11:18, "Ivan Enderlin" wrote: Hello :-), Thank you for the RFC. I really appreciate it, for sure, but I would like to raise a concern regarding the atoum test framework [1]. atoum provides 3 mock engines, resp. for class-like entitites, functions, and constants. The fu

Re: [PHP-DEV] Potential adoption of run-tests.php replacement

2018-02-05 Thread Johannes Schlüter
On So, 2018-02-04 at 01:53 -0800, Stanislav Malyshev wrote: > - Section support - I think besides TEST, the following will be > needed: > * XFAIL: unfortunately, those are still needed > * ENV: there are a lot of environment-dependent tests as it seems > * FILE_EXTERNAL: is pretty widely used > * T

Re: [PHP-DEV] [RFC][DISCUSSION] Deprecation of fallback to root scope

2018-02-05 Thread Ivan Enderlin
Hello :-), Thank you for the RFC. I really appreciate it, for sure, but I would like to raise a concern regarding the atoum test framework [1]. atoum provides 3 mock engines, resp. for class-like entitites, functions, and constants. The function and constant mock engines are both based on t