Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Michał Brzuchalski
2017-12-13 6:04 GMT+01:00 Michał Brzuchalski : > > > 2017-12-13 5:38 GMT+01:00 Michał Brzuchalski : > >> >> >> 2017-12-13 5:24 GMT+01:00 Andreas Hennings : >> >>> On 13 December 2017 at 05:04, Michał Brzuchalski >>> wrote: >>> > >>> > If we're going to introduce someday a namespace file, then IMO

Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Ivan Enderlin
On 11.12.17 14:43, Nikita Popov wrote: Some time ago I introduced the following proposal for namespace-scoped declares: https://wiki.php.net/rfc/namespace_scoped_declares The idea is to allow specifying declare directives for a whole library or project using: namespace_declare('Vendo

Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Michał Brzuchalski
2017-12-13 5:38 GMT+01:00 Michał Brzuchalski : > > > 2017-12-13 5:24 GMT+01:00 Andreas Hennings : > >> On 13 December 2017 at 05:04, Michał Brzuchalski >> wrote: >> > >> > If we're going to introduce someday a namespace file, then IMO it >> should not >> > be putted outside namespace folder. >> >

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2017-12-12 Thread Sara Golemon
On Tue, Dec 12, 2017 at 2:43 AM, Johannes Schlüter wrote: > The issue, as you well know, is that references disable copy-on-write. Thus > assume you have code like this: > > function with_ref(&$a) { >count ($a); > } > > function no_ref($a) { > count($a); > } > > The count in with_ref() will

Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Michał Brzuchalski
2017-12-13 5:24 GMT+01:00 Andreas Hennings : > On 13 December 2017 at 05:04, Michał Brzuchalski > wrote: > > > > If we're going to introduce someday a namespace file, then IMO it should > not > > be putted outside namespace folder. > > For eg class Acme\Animal\Cat in src/Acme/Animal/Cat.php shoul

Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Andreas Hennings
On 13 December 2017 at 05:04, Michał Brzuchalski wrote: > > If we're going to introduce someday a namespace file, then IMO it should not > be putted outside namespace folder. > For eg class Acme\Animal\Cat in src/Acme/Animal/Cat.php should have > namespace file in src/Acme/Aniimal/namespace.php >

Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Michał Brzuchalski
2017-12-13 1:16 GMT+01:00 Andreas Hennings : > I agree with all of Stanislav's emails in this thread so far. > > On 12 December 2017 at 14:43, Nikita Popov wrote: > > On Tue, Dec 12, 2017 at 8:46 AM, Stanislav Malyshev > > > wrote: > > > >> Hi! > >> > >> > The idea is to allow specifying declare

Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Andreas Hennings
I agree with all of Stanislav's emails in this thread so far. On 12 December 2017 at 14:43, Nikita Popov wrote: > On Tue, Dec 12, 2017 at 8:46 AM, Stanislav Malyshev > wrote: > >> Hi! >> >> > The idea is to allow specifying declare directives for a whole library or >> > project using: >> > >> >

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-12 Thread Stanislav Malyshev
Hi! >> I think the best solution here would be to have another variable to >> override this. > > The issue with this approach would be that every distribution has to set > this variable. I know it's the same with SOURCE_DATE_EPOCH, but that is > well established. All distros that want reproducib

Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Stanislav Malyshev
Hi! > There is no dependence on loading order. The implementation is careful > to ensure that the used declare state is consistent. It's not possible > to call namespace_declare() twice on the same namespace. It's not > possible to first load some files from a namespace, do the > namespace_declare

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-12 Thread Levi Morrison
On Mon, Dec 11, 2017 at 2:11 PM, Jelle van der Waa wrote: > Hi all, > > Debian, Arch Linux and other distro's are trying to get full > reproducible builds. There are some issues in PHP's codebase which makes > builds unreproducible. Reprodicuble builds are currently reproduced in > Arch Linux by b

Re: [PHP-DEV] [RFC] Reproducible Builds Support

2017-12-12 Thread Jelle van der Waa
On 12/11/17 at 11:33pm, Stanislav Malyshev wrote: > Hi! > > > Once issue is the PHP_BUILD_DATE, which makes the build > > non-reproducible. I've made a PR which uses SOURCE_DATE_EPOCH which is > > set in the reprodiculbe build env. This should keep the current > > functionality intact, while addin

[PHP-DEV] Re: [RFC] Namespace-scoped declares, again

2017-12-12 Thread Christoph M. Becker
On 11.12.2017 at 14:43, Nikita Popov wrote: > Some time ago I introduced the following proposal for namespace-scoped > declares: > > https://wiki.php.net/rfc/namespace_scoped_declares > > The idea is to allow specifying declare directives for a whole library or > project using: > > name

Re: [PHP-DEV] Outstanding php.net account requests

2017-12-12 Thread Thomas Hruska
On 12/5/2017 7:21 AM, Johannes Schlüter wrote: On Di, 2017-12-05 at 14:57 +0100, Christoph M. Becker wrote: On 05.12.2017 at 14:34, Pedro Magalhães wrote: On Tue, Dec 5, 2017 at 12:49 PM, Johannes Schlüter wrote: we currently have 118 outstanding php.net account requests going back to Oct

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2017-12-12 Thread Nikita Popov
On Tue, Dec 12, 2017 at 8:43 AM, Johannes Schlüter wrote: > > > On December 12, 2017 7:38:54 AM GMT+01:00, Stanislav Malyshev < > smalys...@gmail.com> wrote: > >Hi! > > > >> I would rather discourage usage of references. Since PHP 7 the cost > >of > >> breaking cow isn't as expensive anymore, but

Re: [PHP-DEV] [RFC] Namespace-scoped declares, again

2017-12-12 Thread Nikita Popov
On Tue, Dec 12, 2017 at 8:46 AM, Stanislav Malyshev wrote: > Hi! > > > The idea is to allow specifying declare directives for a whole library or > > project using: > > > > namespace_declare('Vendor\Lib', ['strict_types' => 1]); > > I am not sure I like this. Namespace is a prefix to a class n

Re: [PHP-DEV] [RFC] Explicit call-site send-by-ref syntax

2017-12-12 Thread Johannes Schlüter
On December 12, 2017 8:51:42 AM GMT+01:00, Stanislav Malyshev wrote: >Hi! > >> The issue, as you well know, is that references disable >copy-on-write. Thus assume you have code like this: >> >> function with_ref(&$a) { >>count ($a); >> } >> >> function no_ref($a) { >> count($a); >> } >>