Re: [PHP-DEV] Consistent indentation for test files

2017-10-29 Thread Kalle Sommer Nielsen
2017-10-29 22:30 GMT+01:00 Anatol Belski : > Whichever way would be chosen, implementing a pre commit hook would make > sense to be done. To mention, tabs were easier for me, too, but not a big > deal anyway. I'm on the same boat as Anatol here, whatever is choosen is fine with me, tho I general

Re: [PHP-DEV] [RFC] [VOTE] Implement missing SQLite feature "openBlob" in PDO

2017-10-29 Thread Dan Ackroyd
The vote for this should have ended..3 days ago. At which point I believe the vote was actually passing. cheers Dan On 9 October 2017 at 23:12, BohwaZ/PHP wrote: > Kia ora, > > After some more discussions, I don't think we have much left to discuss on > that topic, so… > > Voting is now ope

RE: [PHP-DEV] Consistent indentation for test files

2017-10-29 Thread Anatol Belski
Hi, > -Original Message- > From: jakub@gmail.com [mailto:jakub@gmail.com] On Behalf Of Jakub > Zelenka > Sent: Sunday, October 29, 2017 7:41 PM > To: Nikita Popov > Cc: PHP internals > Subject: Re: [PHP-DEV] Consistent indentation for test files > > On Sat, Oct 28, 2017 at 12:59

[PHP-DEV] Weird PHP 7.2 bug

2017-10-29 Thread Derick Rethans
Hi, running: https://raw.githubusercontent.com/xdebug/xdebug/master/tests/bug01263.inc with: $ php -n -dzend_extension=opcache.so -dopcache.enable_cli=1 tests/bug01263.inc Produces the following output with PHP 7.2 build at Oct 29 2017 18:49:58: In function PHP_CodeCoverage::addUncoveredFilesFr

Re: [PHP-DEV] Consistent indentation for test files

2017-10-29 Thread Jakub Zelenka
On Sat, Oct 28, 2017 at 12:59 PM, Nikita Popov wrote: > Hi internals, > > Right now we do not have a consistent standard for the indentation of PHPT > files. Some people create space-indented files, others create tab-indented > files. Over time, indentation invariably starts to mix, because devel