[PHP-DEV] Remove FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED

2017-10-28 Thread Christoph M. Becker
Hi internals! Bug #75442[1] correctly mentions that the constants FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED are practically unused as of PHP 5.2.1. (Well, they have been used in a single test case, but I have just removed them[2]). So I suggest to deprecate these constants as of

[PHP-DEV] Re: Consistent indentation for test files

2017-10-28 Thread Christoph M. Becker
On 28.10.2017 at 13:59, Nikita Popov wrote: > Right now we do not have a consistent standard for the indentation of PHPT > files. Some people create space-indented files, others create tab-indented > files. Over time, indentation invariably starts to mix, because developers > with different indent

Re: [PHP-DEV] [RFC] Flexible Heredoc and Nowdoc Syntaxes

2017-10-28 Thread Stephen Reay
> On 28 Oct 2017, at 18:17, Thomas Punt wrote: > > Hi Stephen, > > > I disagree. To me this change would simply mean that the literal exact > > white-space string preceding the end marker is removed as a prefix from all > > lines. > > > > So if you have an end marker intended by two tab char

[PHP-DEV] Consistent indentation for test files

2017-10-28 Thread Nikita Popov
Hi internals, Right now we do not have a consistent standard for the indentation of PHPT files. Some people create space-indented files, others create tab-indented files. Over time, indentation invariably starts to mix, because developers with different indentation settings work on one file. Here

Re: [PHP-DEV] [RFC] Flexible Heredoc and Nowdoc Syntaxes

2017-10-28 Thread Thomas Punt
Hi Stephen, > I disagree. To me this change would simply mean that the literal exact > white-space string preceding the end marker is removed as a prefix from all > lines. > > So if you have an end marker intended by two tab characters, but all the > ‘content’ lines of the heredoc are indented

Re: [PHP-DEV] [RFC] Flexible Heredoc and Nowdoc Syntaxes

2017-10-28 Thread Stephen Reay
> On 24 Oct 2017, at 4:58 pm, Nikita Popov wrote: > > On Tue, Oct 24, 2017 at 11:27 AM, Thomas Punt wrote: > >> Hi Christopher, >> >> >>> I like the added flexibility in placement of the end token, but I think >> requiring only tabs or spaces, and stripping whitespace from all >> {here|now}

Re: [PHP-DEV] Constants and Access Modifiers

2017-10-28 Thread Fleshgrinder
On 10/27/2017 11:15 PM, Nikita Popov wrote: > PHP does not permit self-referencing constants. > > However, this is only checked when the constant is first accessed. In your > first example the constant is never accessed, so no error is thrown. This > has nothing to do with subclasses defining the