Re: [PHP-DEV] Strict type declarations not enforced for Reflection API invocation

2017-10-10 Thread Sebastian Bergmann
Am 10.10.2017 um 18:53 schrieb Nikita Popov: > The problem are not internal function calls, the problem are callbacks. In > fact, the proposed fix does not actually fix the problem you encountered in > PHPUnit, as it is going to use the strictness mode at the reflection > call-site, not the strictn

Re: [PHP-DEV] Re: Strict type declarations not enforced forReflection API invocation

2017-10-10 Thread Christoph M. Becker
On 10.10.2017 at 18:41, Niklas Keller wrote: > 2017-10-10 17:10 GMT+02:00 li...@rhsoft.net : > All in all, two typing modes were a bad idea to begin with, mostly because > nobody payed attention to callbacks. "nobody" is not quite right. If I remember correctly, this issue has first been brough

Re: [PHP-DEV] Strict type declarations not enforced for Reflection API invocation

2017-10-10 Thread Nikita Popov
On Tue, Oct 10, 2017 at 3:41 PM, Sebastian Bergmann wrote: > https://bugs.php.net/bug.php?id=75345 is about the fact that strict type > declarations are not enforced when a function or method is invoked via the > Reflection API. > > There is a pull request that addresses this (as well as > https:

Re: [PHP-DEV] Re: Strict type declarations not enforced for Reflection API invocation

2017-10-10 Thread li...@rhsoft.net
Am 10.10.2017 um 18:41 schrieb Niklas Keller: 2017-10-10 17:10 GMT+02:00 li...@rhsoft.net mailto:li...@rhsoft.net>>: Am 10.10.2017 um 16:57 schrieb Christoph M. Becker: On 10.10.2017 at 15:41, Sebastian Bergmann wrote: I consider this a ser

Re: [PHP-DEV] Re: Strict type declarations not enforced for Reflection API invocation

2017-10-10 Thread Niklas Keller
2017-10-10 17:10 GMT+02:00 li...@rhsoft.net : > > Am 10.10.2017 um 16:57 schrieb Christoph M. Becker: > >> On 10.10.2017 at 15:41, Sebastian Bergmann wrote: >> >> I consider this a serious bug that leads to unexpected, confusing problems >>> such as >>> https://github.com/sebastianbergmann/phpunit

Re: [PHP-DEV] Re: Strict type declarations not enforced for Reflection API invocation

2017-10-10 Thread li...@rhsoft.net
Am 10.10.2017 um 16:57 schrieb Christoph M. Becker: On 10.10.2017 at 15:41, Sebastian Bergmann wrote: I consider this a serious bug that leads to unexpected, confusing problems such as https://github.com/sebastianbergmann/phpunit/issues/2796#issuecomment-335180273. I understand Nikita's point

[PHP-DEV] Re: Strict type declarations not enforced for Reflection API invocation

2017-10-10 Thread Christoph M. Becker
On 10.10.2017 at 15:41, Sebastian Bergmann wrote: > I consider this a serious bug that leads to unexpected, confusing problems > such as > https://github.com/sebastianbergmann/phpunit/issues/2796#issuecomment-335180273. > > I understand Nikita's point of view (see > https://github.com/php/php-src

Re: [PHP-DEV] Parallelised run-tests.php (patch)

2017-10-10 Thread Johannes Schlüter
On Di, 2017-10-10 at 13:35 +0100, Andrea Faulds wrote: > > This is cool! I also see (from very very very) short look on the > > github diff that you have a parallelization protection for some > > tests, which  might share resources. Very good! > I'm glad you like it! Although I discover now that I

Re: [PHP-DEV] Strict type declarations not enforced for Reflection API invocation

2017-10-10 Thread li...@rhsoft.net
Am 10.10.2017 um 15:41 schrieb Sebastian Bergmann: https://bugs.php.net/bug.php?id=75345 is about the fact that strict type declarations are not enforced when a function or method is invoked via the Reflection API. There is a pull request that addresses this (as well as https://bugs.php.net/bu

[PHP-DEV] Strict type declarations not enforced for Reflection API invocation

2017-10-10 Thread Sebastian Bergmann
https://bugs.php.net/bug.php?id=75345 is about the fact that strict type declarations are not enforced when a function or method is invoked via the Reflection API. There is a pull request that addresses this (as well as https://bugs.php.net/bug.php?id=74750) at https://github.com/php/php-src/pull/

Re: [PHP-DEV] Parallelised run-tests.php (patch)

2017-10-10 Thread Andrea Faulds
Hi Johannes, Johannes Schlüter wrote: On So, 2017-10-08 at 04:47 +0100, Andrea Faulds wrote: Have you long since ABANDONED every test directory besides Zend/tests? ... or ran only eext/foo/tests ;) …*ahem*. Okay, enough terrible salesmanship. I felt like parallelising run-tests.php, so I di

Re: [PHP-DEV] Parallelised run-tests.php (patch)

2017-10-10 Thread Johannes Schlüter
On So, 2017-10-08 at 04:47 +0100, Andrea Faulds wrote: > Have you long since ABANDONED every test directory besides > Zend/tests? ... or ran only eext/foo/tests ;) > …*ahem*. Okay, enough terrible salesmanship. I felt like > parallelising  > run-tests.php, so I did it. If you give it the flag -jX

Re: [PHP-DEV] Parallelised run-tests.php (patch)

2017-10-10 Thread Andrea Faulds
Hi! Ferenc Kovacs wrote: On Tue, Oct 10, 2017 at 9:01 AM, Michael Wallner wrote: Hi! On 08/10/17 05:47, Andrea Faulds wrote:> Hi there, Then I've got just the trick for you! Ha, welcome to the club! I'm glad someone else feels the need, too. https://github.com/php/php-src/compare/master..

Re: [PHP-DEV] Parallelised run-tests.php (patch)

2017-10-10 Thread Ferenc Kovacs
On Tue, Oct 10, 2017 at 9:01 AM, Michael Wallner wrote: > Hi! > > On 08/10/17 05:47, Andrea Faulds wrote:> Hi there, > > > > Do you spend HOURS every day AGONISING over how long run-tests.php takes > > to complete? > Yes! > > > > > Have you long since ABANDONED every test directory besides Zend/t

Re: [PHP-DEV] Parallelised run-tests.php (patch)

2017-10-10 Thread Michael Wallner
Hi! On 08/10/17 05:47, Andrea Faulds wrote:> Hi there, > > Do you spend HOURS every day AGONISING over how long run-tests.php takes > to complete? Yes! > > Have you long since ABANDONED every test directory besides Zend/tests? > > Does it feel like your eight CPU cores are pointlessly WASTED by >